From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id 533616B004F for ; Tue, 6 Oct 2009 23:21:54 -0400 (EDT) Received: from spaceape10.eur.corp.google.com (spaceape10.eur.corp.google.com [172.28.16.144]) by smtp-out.google.com with ESMTP id n973LlWt001856 for ; Wed, 7 Oct 2009 04:21:48 +0100 Received: from pzk34 (pzk34.prod.google.com [10.243.19.162]) by spaceape10.eur.corp.google.com with ESMTP id n973LiYm024925 for ; Tue, 6 Oct 2009 20:21:45 -0700 Received: by pzk34 with SMTP id 34so4470714pzk.11 for ; Tue, 06 Oct 2009 20:21:44 -0700 (PDT) Date: Tue, 6 Oct 2009 20:21:40 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH 3/11] hugetlb: factor init_nodemask_of_node In-Reply-To: <20091006031757.22576.97427.sendpatchset@localhost.localdomain> Message-ID: References: <20091006031739.22576.5248.sendpatchset@localhost.localdomain> <20091006031757.22576.97427.sendpatchset@localhost.localdomain> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Lee Schermerhorn Cc: linux-mm@kvack.org, linux-numa@vger.kernel.org, akpm@linux-foundation.org, Mel Gorman , Randy Dunlap , Nishanth Aravamudan , Adam Litke , Andy Whitcroft , eric.whitney@hp.com List-ID: On Mon, 5 Oct 2009, Lee Schermerhorn wrote: > [PATCH 3/11] - hugetlb: factor init_nodemask_of_node() > > Against: 2.6.31-mmotm-090925-1435 > > New in V5 of series > > V6: + rename 'init_nodemask_of_nodes()' to 'init_nodemask_of_node()' > + redefine init_nodemask_of_node() as static inline fcn > + move this patch back 1 in series > > V8: + factor 'init_nodemask_of_node()' from nodemask_of_node() > + drop alloc_nodemask_of_node() -- not used any more > > V9: + remove extra parens around arguments now that init_nodemask_of_node > is not longer a macro. > I don't see this change in v9, the extra parentheses are still there in the inline function. > Factor init_nodemask_of_node() out of the nodemask_of_node() > macro. > > This will be used to populate the huge pages "nodes_allowed" > nodemask for a single node when basing nodes_allowed on a > preferred/local mempolicy or when a persistent huge page > pool page count is modified via a per node sysfs attribute. > > Signed-off-by: Lee Schermerhorn > Acked-by: Mel Gorman > > include/linux/nodemask.h | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > Index: linux-2.6.31-mmotm-090925-1435/include/linux/nodemask.h > =================================================================== > --- linux-2.6.31-mmotm-090925-1435.orig/include/linux/nodemask.h 2009-09-30 11:19:52.000000000 -0400 > +++ linux-2.6.31-mmotm-090925-1435/include/linux/nodemask.h 2009-09-30 11:22:01.000000000 -0400 > @@ -245,14 +245,19 @@ static inline int __next_node(int n, con > return min_t(int,MAX_NUMNODES,find_next_bit(srcp->bits, MAX_NUMNODES, n+1)); > } > > +static inline void init_nodemask_of_node(nodemask_t *mask, int node) > +{ > + nodes_clear(*(mask)); > + node_set((node), *(mask)); > +} > + > #define nodemask_of_node(node) \ > ({ \ > typeof(_unused_nodemask_arg_) m; \ > if (sizeof(m) == sizeof(unsigned long)) { \ > m.bits[0] = 1UL<<(node); \ > } else { \ > - nodes_clear(m); \ > - node_set((node), m); \ > + init_nodemask_of_node(&m, (node)); \ > } \ > m; \ > }) > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org