From: David Rientjes <rientjes@google.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Nick Piggin <npiggin@suse.de>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Christoph Lameter <cl@linux-foundation.org>,
heiko.carstens@de.ibm.com, sachinp@in.ibm.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Tejun Heo <tj@kernel.org>
Subject: Re: [RFC PATCH 0/3] Fix SLQB on memoryless configurations V2
Date: Tue, 22 Sep 2009 10:31:47 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.1.00.0909221018380.7114@chino.kir.corp.google.com> (raw)
In-Reply-To: <20090922152649.GG25965@csn.ul.ie>
On Tue, 22 Sep 2009, Mel Gorman wrote:
> Lumping the per-cpu allocator to cover per-cpu and per-node feels a bit
> confusing. Maybe it would have been easier if there simply were never
> memoryless nodes and cpus were always mapped to their closest, instead of
> their local, node. There likely would be a few corner cases though and memory
> hotplug would add to the mess. I haven't been able to decide on a sensible
> way forward that doesn't involve a number of invasive changes.
>
I strongly agree with removing memoryless node support from the kernel,
but I don't think we should substitute it with a multiple cpu binding
approach because it doesn't export the true physical topology of the
system.
If we treat all cpus equally with respect to a region of memory when one
happens to be more remote, userspace can no longer use sched_setaffinity()
for latency-sensitive apps nor can it correctly interleave with other
nodes. Reduced to its simplest form, a machine now with a single node
because memoryless nodes have been obsoleted would incorrectly report that
all cpus are true siblings.
While memoryless nodes are inconvenient for the implementation, they do
have the benefit of being able to represent the actual physical topology
when binding cpus to their nearest node, even though it may not be local,
would not.
It's important to accurately represent the physical topology, and that can
be done with the device class abstraction model as I described in
http://lkml.org/lkml/2009/9/22/97 of which a node is only a locality of a
particular type.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2009-09-22 17:31 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-21 16:10 Mel Gorman
2009-09-21 16:10 ` [PATCH 1/3] powerpc: Allocate per-cpu areas for node IDs for SLQB to use as per-node areas Mel Gorman
2009-09-21 17:17 ` Daniel Walker
2009-09-21 17:24 ` Randy Dunlap
2009-09-21 17:29 ` Daniel Walker
2009-09-21 17:42 ` Mel Gorman
2009-09-22 0:01 ` Tejun Heo
2009-09-22 9:32 ` Mel Gorman
2009-09-21 16:10 ` [PATCH 2/3] slqb: Record what node is local to a kmem_cache_cpu Mel Gorman
2009-09-21 16:10 ` [PATCH 3/3] slqb: Allow SLQB to be used on PPC Mel Gorman
2009-09-22 9:30 ` Heiko Carstens
2009-09-22 9:32 ` Mel Gorman
2009-09-21 17:46 ` [RFC PATCH 0/3] Fix SLQB on memoryless configurations V2 Mel Gorman
2009-09-21 17:54 ` Christoph Lameter
2009-09-21 18:05 ` Pekka Enberg
2009-09-21 18:07 ` Mel Gorman
2009-09-21 18:17 ` Christoph Lameter
2009-09-22 10:05 ` Mel Gorman
2009-09-22 10:21 ` Pekka Enberg
2009-09-22 10:24 ` Mel Gorman
2009-09-22 5:03 ` Sachin Sant
2009-09-22 10:07 ` Mel Gorman
2009-09-22 12:55 ` Mel Gorman
2009-09-22 13:05 ` Sachin Sant
2009-09-22 13:20 ` Mel Gorman
[not found] ` <363172900909220629j2f5174cbo9fe027354948d37@mail.gmail.com>
2009-09-22 13:38 ` Mel Gorman
2009-09-22 23:07 ` Christoph Lameter
2009-09-22 0:00 ` Benjamin Herrenschmidt
2009-09-22 0:19 ` David Rientjes
2009-09-22 6:30 ` Christoph Lameter
2009-09-22 7:59 ` David Rientjes
2009-09-22 8:11 ` Benjamin Herrenschmidt
2009-09-22 8:44 ` David Rientjes
2009-09-22 15:26 ` Mel Gorman
2009-09-22 17:31 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0909221018380.7114@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=benh@kernel.crashing.org \
--cc=cl@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=npiggin@suse.de \
--cc=penberg@cs.helsinki.fi \
--cc=sachinp@in.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox