From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id 783DD6B012B for ; Mon, 21 Sep 2009 05:14:05 -0400 (EDT) Received: from zps38.corp.google.com (zps38.corp.google.com [172.25.146.38]) by smtp-out.google.com with ESMTP id n8L9E5gV021273 for ; Mon, 21 Sep 2009 10:14:05 +0100 Received: from pzk10 (pzk10.prod.google.com [10.243.19.138]) by zps38.corp.google.com with ESMTP id n8L9E2rE019329 for ; Mon, 21 Sep 2009 02:14:02 -0700 Received: by pzk10 with SMTP id 10so2054603pzk.19 for ; Mon, 21 Sep 2009 02:14:02 -0700 (PDT) Date: Mon, 21 Sep 2009 02:13:59 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH] remove duplicate asm/mman.h files In-Reply-To: <200909211031.25369.arnd@arndb.de> Message-ID: References: <200909181848.42192.arnd@arndb.de> <200909211031.25369.arnd@arndb.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Andrew Morton , Fenghua Yu , Tony Luck Cc: ebmunson@us.ibm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-man@vger.kernel.org, mtk.manpages@gmail.com, randy.dunlap@oracle.com, rth@twiddle.net, ink@jurassic.park.msu.ru, linux-ia64@vger.kernel.org, Arnd Bergmann List-ID: On Mon, 21 Sep 2009, Arnd Bergmann wrote: > > > -#define MCL_CURRENT 1 /* lock all current mappings */ > > > -#define MCL_FUTURE 2 /* lock all future mappings */ > > > +#define MAP_GROWSUP 0x0200 /* register stack-like segment */ > > > > > > #ifdef __KERNEL__ > > > #ifndef __ASSEMBLY__ > > > > ia64 doesn't use MAP_GROWSUP, so it's probably not necessary to carry it > > along with your cleanup. > > ia64 is the only architecture defining it, nobody uses it in the kernel. > If the ia64 maintainers want to remove it in a separate patch, that > would probably be a good idea. > I'll do it then. > I tried not to change the ABI in any way in my patch, and there is > a theoretical possibility that some user space program on ia64 currently > depends on that definition. > I don't buy that as justification, if some userspace program uses it based on the false belief that it actually does what it says, it's probably better to break their build than perpetuating the lie that it's different than ~MAP_GROWSDOWN. ia64: remove definition for MAP_GROWSUP MAP_GROWSUP is unused. Signed-off-by: David Rientjes --- diff --git a/arch/ia64/include/asm/mman.h b/arch/ia64/include/asm/mman.h --- a/arch/ia64/include/asm/mman.h +++ b/arch/ia64/include/asm/mman.h @@ -11,7 +11,6 @@ #include #define MAP_GROWSDOWN 0x00100 /* stack-like segment */ -#define MAP_GROWSUP 0x00200 /* register stack-like segment */ #define MAP_DENYWRITE 0x00800 /* ETXTBSY */ #define MAP_EXECUTABLE 0x01000 /* mark it as an executable */ #define MAP_LOCKED 0x02000 /* pages are locked */ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org