From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with ESMTP id EEA196B004D for ; Thu, 10 Sep 2009 15:50:19 -0400 (EDT) Received: from zps35.corp.google.com (zps35.corp.google.com [172.25.146.35]) by smtp-out.google.com with ESMTP id n8AJoLXK031991 for ; Thu, 10 Sep 2009 20:50:21 +0100 Received: from pzk13 (pzk13.prod.google.com [10.243.19.141]) by zps35.corp.google.com with ESMTP id n8AJnqji032247 for ; Thu, 10 Sep 2009 12:50:18 -0700 Received: by pzk13 with SMTP id 13so322393pzk.5 for ; Thu, 10 Sep 2009 12:50:18 -0700 (PDT) Date: Thu, 10 Sep 2009 12:50:13 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH 5/6] hugetlb: add per node hstate attributes In-Reply-To: <1252592774.6947.163.camel@useless.americas.hpqcorp.net> Message-ID: References: <20090909163127.12963.612.sendpatchset@localhost.localdomain> <20090909163158.12963.49725.sendpatchset@localhost.localdomain> <20090910123233.GB31153@csn.ul.ie> <1252592774.6947.163.camel@useless.americas.hpqcorp.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Lee Schermerhorn Cc: Mel Gorman , linux-mm@kvack.org, linux-numa@vger.kernel.org, Andrew Morton , Randy Dunlap , Nishanth Aravamudan , Adam Litke , Andy Whitcroft , eric.whitney@hp.com List-ID: On Thu, 10 Sep 2009, Lee Schermerhorn wrote: > PATCH 5/7 - hugetlb: promote NUMA_NO_NODE to generic constant > > Against: 2.6.31-rc7-mmotm-090827-1651 > > Move definition of NUMA_NO_NODE from ia64 and x86_64 arch specific > headers to generic header 'linux/numa.h' for use in generic code. > NUMA_NO_NODE replaces bare '-1' where it's used in this series to > indicate "no node id specified". Ultimately, it can be used > to replace the -1 elsewhere where it is used similarly. > > Note that in arch/x86/include/asm/topology.h, NUMA_NO_NODE is > now only defined when CONFIG_NUMA is defined. This seems to work > for current usage of NUMA_NO_NODE in x86_64 arch code, with or > without CONFIG_NUMA defined. > > Signed-off-by: Lee Schermerhorn Acked-by: David Rientjes Thought I recommended this in http://marc.info/?l=linux-mm&m=125201173730752 You could now convert NID_INVAL to NUMA_NO_NODE and remove the duplicate constant as I earlier suggested to cleanup the acpi code. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org