From: Vincent Li <macli@brc.ubc.ca>
To: Fernando Carrijo <fcarrijo@yahoo.com.br>
Cc: Vincent Li <macli@brc.ubc.ca>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/vmscan: rename zone_nr_pages() to zone_lru_nr_pages()
Date: Fri, 21 Aug 2009 10:29:43 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.1.00.0908211025420.3187@mail.selltech.ca> (raw)
In-Reply-To: <1250817819.4835.21.camel@pc-fernando>
On Thu, 20 Aug 2009, Fernando Carrijo wrote:
> On Thu, 2009-08-20 at 11:42 -0700, Vincent Li wrote:
> > Name zone_nr_pages can be mis-read as zone's (total) number pages, but it actually returns
> > zone's LRU list number pages.
> >
> > I know reading the code would clear the name confusion, want to know if patch making sense.
>
> In case this patch gets an ack, wouldn't it make sense to try to keep
> some consistency by renaming the function mem_cgroup_zone_nr_pages to
> mem_cgroup_zone_lru_nr_pages, since it also deals with an specific LRU?
>
> Fernando Carrijo
>
I thought about renaming mem_cgroup_zone_nr_pages too, but not sure if the
patch make sense when I submit, so I kept the changes as small as
possible.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2009-08-21 17:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 18:42 Vincent Li
2009-08-20 23:00 ` Andrew Morton
2009-08-21 0:19 ` Vincent Li
2009-08-21 0:22 ` Andrew Morton
2009-08-21 17:32 ` Fernando Carrijo
2009-08-21 17:36 ` Fernando Carrijo
2009-08-21 1:23 ` Fernando Carrijo
2009-08-21 17:29 ` Vincent Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0908211025420.3187@mail.selltech.ca \
--to=macli@brc.ubc.ca \
--cc=akpm@linux-foundation.org \
--cc=fcarrijo@yahoo.com.br \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox