From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 6 Mar 2008 21:15:33 -0800 (PST) From: David Rientjes Subject: Re: [PATCH] Add cgroup support for enabling controllers at boot time In-Reply-To: <20080307135839.918a849a.kamezawa.hiroyu@jp.fujitsu.com> Message-ID: References: <20080306185952.23290.49571.sendpatchset@localhost.localdomain> <47D0C76D.8050207@linux.vnet.ibm.com> <20080307135839.918a849a.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: KAMEZAWA Hiroyuki Cc: balbir@linux.vnet.ibm.com, Paul Menage , Andrew Morton , Pavel Emelianov , Hugh Dickins , Sudhir Kumar , YAMAMOTO Takashi , lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org, taka@valinux.co.jp, linux-mm@kvack.org List-ID: On Fri, 7 Mar 2008, KAMEZAWA Hiroyuki wrote: > > David Rientjes wrote: > > > On Fri, 7 Mar 2008, Balbir Singh wrote: > > > > > >> @@ -3010,3 +3020,16 @@ static void cgroup_release_agent(struct > > >> spin_unlock(&release_list_lock); > > >> mutex_unlock(&cgroup_mutex); > > >> } > > >> + > > >> +static int __init cgroup_disable(char *str) > > >> +{ > > >> + int i; > > >> + for (i = 0; i < CGROUP_SUBSYS_COUNT; i++) { > > >> + struct cgroup_subsys *ss = subsys[i]; > > >> + if (!strcmp(str, ss->name)) { > > >> + ss->disabled = 1; > > >> + break; > > >> + } > > >> + } > > >> +} > > >> +__setup("cgroup_disable=", cgroup_disable); > > > > > > This doesn't handle spaces very well, so isn't it possible for the name of > > > a current or future cgroup subsystem to be specified after cgroup_disable= > > > on the command line and have it disabled by accident? > > > > > > Hmm, cmdline like > > cgroup_disable=cpu,memory, ... > > should be written as > > cgroup_disable=cpu cgroup_disable=memory .... > Or just set the first space following cgroup_disable= to '\0' and you're done. strcmp() will take care of the rest. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org