linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Balbir Singh <balbir@linux.vnet.ibm.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Rik van Riel <riel@redhat.com>,
	Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
	Nick Piggin <npiggin@suse.de>
Subject: Re: [RFC][PATCH] page reclaim throttle take2
Date: Tue, 26 Feb 2008 23:56:39 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.1.00.0802262349090.21857@chino.kir.corp.google.com> (raw)
In-Reply-To: <20080227165139.18e5933e.kamezawa.hiroyu@jp.fujitsu.com>

On Wed, 27 Feb 2008, KAMEZAWA Hiroyuki wrote:

> Hmm, but kswapd, which is main worker of page reclaiming, is per-node.
> And reclaim is done based on zone.
> per-zone/per-node throttling seems to make sense.
> 

That's another argument for not introducing the sysctl; the number of 
nodes and zones are a static property of the machine that cannot change 
without a reboot (numa=fake, mem=, introducing movable zones, etc).  We 
don't have node hotplug that can suddenly introduce additional zones from 
which to reclaim.

My point was that there doesn't appear to be any use case for tuning this 
via a sysctl that isn't simply attempting to workaround some other reclaim 
problem when the VM is stressed.  If that's agreed upon, then deciding 
between a config option that is either per-cpu or per-node should be based 
on the benchmarks that you've run.  At this time, it appears that per-node 
is the more advantageous.

> I know his environment has 4cpus per node but throttle to 3 was the best
> number in his measurement. Then it seems num-per-cpu is excessive.
> (At least, ratio(%) is better.)

That seems to indicate that the NUMA topology is more important than lock 
contention for the reclaim throttle.

		David

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-02-27  7:56 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-26  2:32 KOSAKI Motohiro
2008-02-26 21:18 ` Peter Zijlstra
2008-02-27  0:50   ` KAMEZAWA Hiroyuki
2008-02-27  4:26   ` KOSAKI Motohiro
2008-02-27  4:27     ` Balbir Singh
2008-02-27  4:45       ` KOSAKI Motohiro
2008-02-27  5:00         ` KAMEZAWA Hiroyuki
2008-02-27  5:04           ` KOSAKI Motohiro
2008-02-27  5:03             ` Balbir Singh
2008-02-27  5:13               ` KOSAKI Motohiro
2008-02-27  5:19               ` David Rientjes
2008-02-27  5:33                 ` KOSAKI Motohiro
2008-02-27  5:47                   ` David Rientjes
2008-02-27  5:48                     ` Balbir Singh
2008-02-27  6:09                       ` David Rientjes
2008-02-27  7:10                         ` KOSAKI Motohiro
2008-02-27  7:19                           ` David Rientjes
2008-02-27  7:51                             ` KAMEZAWA Hiroyuki
2008-02-27  7:56                               ` David Rientjes [this message]
2008-02-27  8:09                                 ` KAMEZAWA Hiroyuki
2008-02-27 15:30                             ` Rik van Riel
2008-02-27  7:59                         ` Balbir Singh
2008-02-27  8:47                           ` David Rientjes
2008-02-27  9:01                             ` Balbir Singh
2008-02-27  9:44                               ` Peter Zijlstra
2008-02-27  6:52                       ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.00.0802262349090.21857@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=Lee.Schermerhorn@hp.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@suse.de \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox