From: David Rientjes <rientjes@google.com>
To: Andrea Arcangeli <andrea@cpushare.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 11 of 11] not-wait-memdie
Date: Thu, 3 Jan 2008 01:55:35 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.0.9999.0801030152540.25018@chino.kir.corp.google.com> (raw)
In-Reply-To: <504e981185254a12282d.1199326157@v2.random>
On Thu, 3 Jan 2008, Andrea Arcangeli wrote:
> Don't wait tif-memdie tasks forever because they may be stuck in some kernel
> lock owned by some task that requires memory to exit the critical section.
>
This increases the possibility that tasks will be needlessly killed in OOM
conditions. While the indefinite timeout is definitely not the ideal
solution, it does have the advantage of preventing unnecessary kills. The
OOM synchronization is good, but it's not _that_ good: it doesn't ensure
that the OOM killed task has fully exited before another invocation of the
OOM killer happens.
So I think we're moving in a direction of requiring OOM killer timeouts
and the only plausible way to do that is on a per-task level. It would
require another unsigned long addition to struct task_struct but would
completely fix OOM killer deadlocks.
David
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-01-03 9:55 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-03 2:09 [PATCH 00 of 11] oom deadlock fixes Andrea Arcangeli
2008-01-03 2:09 ` [PATCH 01 of 11] limit shrink zone scanning Andrea Arcangeli
2008-01-07 19:11 ` Christoph Lameter
2008-01-03 2:09 ` [PATCH 02 of 11] avoid oom deadlock in nfs_create_request Andrea Arcangeli
2008-01-07 19:13 ` Christoph Lameter
2008-01-03 2:09 ` [PATCH 03 of 11] prevent oom deadlocks during read/write operations Andrea Arcangeli
2008-01-07 19:15 ` Christoph Lameter
2008-01-07 19:26 ` Andrea Arcangeli
2008-01-03 2:09 ` [PATCH 04 of 11] avoid selecting already killed tasks Andrea Arcangeli
2008-01-03 9:40 ` David Rientjes
2008-01-03 13:41 ` Andrea Arcangeli
2008-01-03 18:47 ` David Rientjes
2008-01-03 19:54 ` Andrea Arcangeli
2008-01-03 20:49 ` David Rientjes
2008-01-07 19:17 ` Christoph Lameter
2008-01-03 2:09 ` [PATCH 05 of 11] reduce the probability of an OOM livelock Andrea Arcangeli
2008-01-07 19:32 ` Christoph Lameter
2008-01-03 2:09 ` [PATCH 06 of 11] balance_pgdat doesn't return the number of pages freed Andrea Arcangeli
2008-01-07 19:33 ` Christoph Lameter
2008-01-03 2:09 ` [PATCH 07 of 11] don't depend on PF_EXITING tasks to go away Andrea Arcangeli
2008-01-03 9:52 ` David Rientjes
2008-01-03 13:29 ` Andrea Arcangeli
2008-01-03 2:09 ` [PATCH 08 of 11] stop useless vm trashing while we wait the TIF_MEMDIE task to exit Andrea Arcangeli
2008-01-03 2:09 ` [PATCH 09 of 11] oom select should only take rss into account Andrea Arcangeli
2008-01-07 19:35 ` Christoph Lameter
2008-01-03 2:09 ` [PATCH 10 of 11] limit reclaim if enough pages have been freed Andrea Arcangeli
2008-01-07 19:37 ` Christoph Lameter
2008-01-08 7:28 ` Andrea Arcangeli
2008-01-03 2:09 ` [PATCH 11 of 11] not-wait-memdie Andrea Arcangeli
2008-01-03 9:55 ` David Rientjes [this message]
2008-01-03 13:06 ` Andrea Arcangeli
2008-01-03 18:54 ` David Rientjes
2008-01-07 19:43 ` Christoph Lameter
2008-01-08 1:57 ` David Rientjes
2008-01-08 3:25 ` Nick Piggin
2008-01-08 3:37 ` David Rientjes
2008-01-08 7:42 ` Nick Piggin
2008-01-08 7:45 ` Andrea Arcangeli
2008-01-08 7:37 ` Andrea Arcangeli
2008-01-08 7:31 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.0.9999.0801030152540.25018@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=andrea@cpushare.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox