From: David Rientjes <rientjes@google.com>
To: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <andrea@suse.de>,
Christoph Lameter <clameter@sgi.com>,
linux-mm@kvack.org
Subject: Re: [patch -mm 4/5] mm: test and set zone reclaim lock before starting reclaim
Date: Mon, 24 Sep 2007 21:34:29 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.0.9999.0709242129420.31515@chino.kir.corp.google.com> (raw)
In-Reply-To: <46F88DFB.3020307@linux.vnet.ibm.com>
On Tue, 25 Sep 2007, Balbir Singh wrote:
> > +
> > + if (zone_test_and_set_flag(zone, ZONE_RECLAIM_LOCKED))
> > + return 0;
>
> What's the consequence of this on the caller of zone_reclaim()?
> I see that the zone is marked as full and will not be re-examined
> again.
>
It's only marked as full in the zonelist cache for the zonelist that
__alloc_pages() was called with, which is an optimization. The zone is
already flagged as being in __zone_reclaim() so there's no need to
reinvoke it for this allocation attempt; that behavior is unchanged from
current behavior.
One thing that has been changed in -mm with regard to my last patchset is
that kswapd and try_to_free_pages() are allowed to call shrink_zone()
concurrently.
ZONE_RECLAIM_LOCKED will be cleared upon return from __zone_reclaim().
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-09-25 4:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-22 17:47 [patch -mm 1/5] oom: prevent including sched.h in header file David Rientjes
2007-09-22 17:47 ` [patch -mm 2/5] oom: add header file to Kbuild as unifdef David Rientjes
2007-09-22 17:47 ` [patch -mm 3/5] oom: convert zone_scan_lock from mutex to spinlock David Rientjes
2007-09-22 17:47 ` [patch -mm 4/5] mm: test and set zone reclaim lock before starting reclaim David Rientjes
2007-09-22 17:47 ` [patch -mm 5/5] oom: add sysctl to dump tasks memory state David Rientjes
2007-09-25 4:37 ` Balbir Singh
2007-09-25 4:57 ` David Rientjes
2007-09-26 20:06 ` Andrew Morton
2007-09-26 20:46 ` David Rientjes
2007-09-26 21:47 ` Andrew Morton
2007-09-27 6:15 ` David Rientjes
2007-09-24 19:05 ` [patch -mm 4/5] mm: test and set zone reclaim lock before starting reclaim Christoph Lameter
2007-09-24 19:14 ` David Rientjes
2007-09-24 20:11 ` Christoph Lameter
2007-09-24 21:02 ` David Rientjes
2007-09-24 21:09 ` Christoph Lameter
2007-09-25 4:26 ` Balbir Singh
2007-09-25 4:34 ` David Rientjes [this message]
2007-09-25 6:17 ` Balbir Singh
2007-09-25 6:29 ` David Rientjes
2007-09-25 21:15 ` Christoph Lameter
2007-09-25 21:19 ` David Rientjes
2007-09-25 21:39 ` Christoph Lameter
2007-09-25 21:43 ` David Rientjes
2007-09-25 21:14 ` Christoph Lameter
2007-09-25 21:17 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.0.9999.0709242129420.31515@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=andrea@suse.de \
--cc=balbir@linux.vnet.ibm.com \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox