Re: [RFC] memory unplug v5 [3/6] walk memory resources assist function.

[David Rientjes <rientjes@google.com>]

On Thu, 14 Jun 2007, KAMEZAWA Hiroyuki wrote:

> Index: devel-2.6.22-rc4-mm2/kernel/resource.c
> ===================================================================
> --- devel-2.6.22-rc4-mm2.orig/kernel/resource.c
> +++ devel-2.6.22-rc4-mm2/kernel/resource.c
> @@ -244,7 +244,7 @@ EXPORT_SYMBOL(release_resource);
>   * the caller must specify res->start, res->end, res->flags.
>   * If found, returns 0, res is overwritten, if not found, returns -1.
>   */
> -int find_next_system_ram(struct resource *res)
> +static int find_next_system_ram(struct resource *res)
>  {
>  	resource_size_t start, end;
>  	struct resource *p;
> @@ -277,6 +277,30 @@ int find_next_system_ram(struct resource
>  		res->end = p->end;
>  	return 0;
>  }
> +
> +int walk_memory_resource(unsigned long start_pfn, unsigned long nr_pages,
> +			 void *arg, walk_memory_callback_t func)
> +{
> +	struct resource res;
> +	unsigned long pfn, len;
> +	u64 orig_end;
> +	int ret;
> +	res.start = (u64) start_pfn << PAGE_SHIFT;
> +	res.end = ((u64)(start_pfn + nr_pages) << PAGE_SHIFT) - 1;
> +	res.flags = IORESOURCE_MEM;
> +	orig_end = res.end;
> +	while ((res.start < res.end) && (find_next_system_ram(&res) >= 0)) {
> +		pfn = (unsigned long)(res.start >> PAGE_SHIFT);
> +		len = (unsigned long)(res.end + 1 - res.start) >> PAGE_SHIFT;

This needs to be

	len = (unsigned long)((res.end + 1 - res.start) >> PAGE_SHIFT);

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>