From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7479BC27C53 for ; Wed, 19 Jun 2024 08:03:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE5D76B0343; Wed, 19 Jun 2024 04:03:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D981D6B0344; Wed, 19 Jun 2024 04:03:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAC6A6B0345; Wed, 19 Jun 2024 04:03:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A712D6B0343 for ; Wed, 19 Jun 2024 04:03:26 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 27CA71C0CE3 for ; Wed, 19 Jun 2024 08:03:26 +0000 (UTC) X-FDA: 82246898412.19.0135CF4 Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) by imf14.hostedemail.com (Postfix) with ESMTP id C44FF100023 for ; Wed, 19 Jun 2024 08:03:23 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=NEnCXcDV; spf=pass (imf14.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718784200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8L+tqoaWJl1XwNkhBVVMTi0+mCHVQ9FGNyYAra2Ol1s=; b=QqMNNUW1Mqo7ky3lr7lvqZGK8/tnhazLASB4qLcBM13MTOAGLlbny+dGVVFXyEGQodg7wu m65LaVkvPyg6qSxGDSI9FiAybAHbAnpIneHf8V/jnmwBPnkMhuuECWr7uVJAA7xEn81eMF sAKKhGpjNpSnrexav9EBdTNSMNWzchE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=NEnCXcDV; spf=pass (imf14.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718784200; a=rsa-sha256; cv=none; b=D1sMwhDa2KoyxlbYTwMt7XyX7Vwu6uDMGbc7GVN7RcDusVp6CdiuTvir9FxmiTbY3vE4tN st3Yq0BOqSmgxnSRkL8xd9GPmVNCmZebayMbtG3GhhW4UH/6qR9BifhG1FAt2ZuKScd+p6 qtSsZuKsEpdIwEqcv/GQeLQ98w/kplw= X-Envelope-To: mhocko@suse.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1718784201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8L+tqoaWJl1XwNkhBVVMTi0+mCHVQ9FGNyYAra2Ol1s=; b=NEnCXcDVag/2SJT2OM5h0I6lAS1C9ug+nsa8AnNRWNCEzjq+SGJSiXWm04splwx2xkewGZ DjYYr9kiLKtcPiv6jS7wlHUc0/X1BNmoCe7hCVX1mLFJEmsuFCFHouSvSrdXBIdKhsYVlw OP99D4PhPZaHMFBFCafWoJL60mLscdQ= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: torvalds@linux-foundation.org X-Envelope-To: kernel-team@meta.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: kyle@infradead.org Date: Wed, 19 Jun 2024 01:03:16 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Michal Hocko Cc: Andrew Morton , Linus Torvalds , kernel-team@meta.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kyle McMartin Subject: Re: [PATCH] mm: ratelimit oversized kvmalloc warnings instead of once Message-ID: References: <20240618213421.282381-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C44FF100023 X-Stat-Signature: n9ekctsc4dni8ejign4jq3okkrabm8nk X-HE-Tag: 1718784203-178790 X-HE-Meta: U2FsdGVkX1+AWZDX+qRZ/0XetiLk6fqG88ZZ0Obnlhppy68OX/N3a3hCQ/KDbwLH14j4Rit/6lp8CU9xUhpqFyrWUJTxeOpNH/EGVQY5ZAErRaFLmEfVEYt90GuFp5ii0RAyxAVQWzQkETyL38M++CB5Mh2yR1O5fKdhsp77R2Pvnxfgy0kK0ifzh8YB5W6/lrc5xF1hf6J4tR8SAWwrdA1JRKvYR7B+LUTJYOYfiNGqYwvN4cF4L3XGsmjj9LfRVY/U1D6cNd+IQ6RYoBOxVoFkesO9WenRslm3TPKVS0Eynnxzpi1WxAodSubduo3zzBWM7VbOZkoinMtxjpDyVhO/du+573UDmgwLfdp8NfmoLxDKypEsZDpAhxDOQYSUmiTc5gbJlvglUU06tOh7aNAqFq7ARqnyOOvy3g7VyZ5B5RnjlIoU/h7rlSH7y/JpDjNaoglvE5NPiUB5dWOfbtuzle7OKF0cjOxO6cCkA8+M+XDhOvDgndM5tTRt2UHBmI6ssRjH04S2kAmkFR8Zh9IoKpOucd9WlqcVTV87WEb1cHE2GjExZzndWfr9XOmLplexzRmGyHOdxxKyrsqe971sfQL4sJQjeudw7wASn+fd6AAaPfViq+b5rowbVteNA+EVxRJXHxzqywsX+0GQmf9njQx2E7o8kUfGaAlEzMVVNueLFOV+RZh+juoDpwYR+vV0+0QdIJEl6Qw3LT5YqdEsTkexBSOPzurX6PSpqQBOgsE/xGwN5haHPwoCWn226RA8ltfJFylQM20tAzuy/yYmL7fsoDf8bN7p3ZzJf0Q5KKiu3CaceXaxnKeEhLfZjDhrdL3AhuuYe+0frjQM2405ViQoPwlLFucARdubko7qK68H48AeFfAVQ51vLnRBFIKUjSOhN3IZmwY3rqaMSHdyEHp3oje2j3q2lbTKqgxJNUj8HHunNhmxdlhrXBW0AgOvx87eEzGI4RuJB9z SMGidNA/ ytyW7jpLxVbP46fviR+3jnBiVO+xWN6zZs3mQ7EWQEs/UZPwh14Et91C4FrQnk2jJdCnmPoCyH70zAtwwZlYKjxkrInmVM6pCn/Z+rHtWEZP+X6+dvUXBcjCa/A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 19, 2024 at 09:19:41AM GMT, Michal Hocko wrote: > On Tue 18-06-24 14:34:21, Shakeel Butt wrote: > > At the moment oversize kvmalloc warnings are triggered once using > > WARN_ON_ONCE() macro. One issue with this approach is that it only > > detects the first abuser and then ignores the remaining abusers which > > complicates detecting all such abusers in a timely manner. The situation > > becomes worse when the repro has low probability and requires production > > traffic and thus require large set of machines to find such abusers. In > > Mera production, this warn once is slowing down the detection of these > > abusers. Simply replace WARN_ON_ONCE with WARN_RATELIMIT. > > Long time ago, I've had a patch to do the once_per_callsite WARN. I > cannot find reference at the moment but it used stack depot to note > stacks that have already triggered. Back then there was no reponse on > the ML. Should I try to dig deep and recover it from my archives? I > think this is exactly kind of usecase where it would fit. > Do you mean something like warn once per unique call stack? If yes then I think that is better than the simple ratelimiting version as ratelimiting one may still miss some abusers and also may keep warning about the same abuser. Please do share your patch. Thanks, Shakeel