Re: [RFC PATCHv5 2/6] zram: add writeback batch size device attr

[Sergey Senozhatsky <senozhatsky@chromium.org>]

On (25/11/20 10:57), Brian Geffon wrote:
> > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> > index 37c1416ac902..7904159e9226 100644
> > --- a/drivers/block/zram/zram_drv.c
> > +++ b/drivers/block/zram/zram_drv.c
> > @@ -588,6 +588,42 @@ static ssize_t writeback_limit_show(struct device *dev,
> >         return sysfs_emit(buf, "%llu\n", val);
> >  }
> >
> > +static ssize_t writeback_batch_size_store(struct device *dev,
> > +                                         struct device_attribute *attr,
> > +                                         const char *buf, size_t len)
> > +{
> > +       struct zram *zram = dev_to_zram(dev);
> > +       u32 val;
> > +       ssize_t ret = -EINVAL;
> > +
> > +       if (kstrtouint(buf, 10, &val))
> > +               return ret;
> > +
> > +       if (!val)
> > +               val = 1;
> 
> IMO a value of 0 for the batch size doesn't make sense, -EINVAL?

Ack.