From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B54FC2BBCA for ; Fri, 21 Jun 2024 14:32:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 139678D0179; Fri, 21 Jun 2024 10:32:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C2AB8D0176; Fri, 21 Jun 2024 10:32:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E07738D0179; Fri, 21 Jun 2024 10:32:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BF80C8D0176 for ; Fri, 21 Jun 2024 10:32:14 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3C9CF80F14 for ; Fri, 21 Jun 2024 14:32:14 +0000 (UTC) X-FDA: 82255135788.17.F26B7D6 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by imf11.hostedemail.com (Postfix) with ESMTP id AC14D4000F for ; Fri, 21 Jun 2024 14:32:11 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=cHm2sXtH; spf=pass (imf11.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718980327; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UnMRPX1i8q+qeFAaffFluDAVp5tb+CaWws8RSCZO+4Q=; b=ckyKdRGCLWqf74JD1P8VLIXyNjr3ERJZpF/GFx9TVchRSc1NTQYihRLknk3/BXR/M5YwmX DIlAqN9ueN7vFxePHt2PKA23mnZDpHEfJgO2FFONHJrOB1JPcLbehtFcH6bkwRP27wpd1a DNktYSroqcURvSOQzn7LT2VL3Jrgnpk= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=cHm2sXtH; spf=pass (imf11.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718980327; a=rsa-sha256; cv=none; b=nFbiCFN1788kRXdWUft/zYJSY+IWAMkfhYAltqbxdOcHRokV+SlbNVpArxDflAhIGfSNV/ P5D7lzpxvb4iF2waJEEY4NXqk8JiyLXdtQqYGRbYgTPe8YAZnLJQJLqz5ddPtEzxV7jAYu +jISqyISXMrPAtUkvSN5x4aqhbzVPhw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718980332; x=1750516332; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=SCV4XnLDPwX4vm7ZchPPteJullsBv/S+vDAJVlZdLhA=; b=cHm2sXtH1ehq0HZMpO5q/bHBgvnfZsxvTslUVieGMZ1UBhxt04SaCC1f M0PhVL5sRQ0T0vRduaRHBVANGsDAguoO96aXaWFU0G2GZVDBuPQNwt9yn Ts03k97p5g4ctJS5RNVIJPB8iX4Di7ZeQUMhFBLbqfH/6CIu35swg4R9D 0evF941VbyeETwn8ZR39kULELI8UecgMG3prm5xFin7wk3R2DOJ+NXiIp uvtfwdWnX7TJbbwvZELNkKraah4aio3AiYldAO+aaVB9OWuTF7iDHhhRh a9idXFH+woiXto9Igvn97jqjgKE8tIQ/wP6PZObe34Pfsn4yCH/aju9MA A==; X-CSE-ConnectionGUID: cno6e3LjTYGadiBJePS2JA== X-CSE-MsgGUID: URERbQR5QoqzUWCN2ARG+Q== X-IronPort-AV: E=McAfee;i="6700,10204,11110"; a="41420520" X-IronPort-AV: E=Sophos;i="6.08,254,1712646000"; d="scan'208";a="41420520" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2024 07:32:10 -0700 X-CSE-ConnectionGUID: qwXb30wBQOKcJIT2kbiqwA== X-CSE-MsgGUID: NYXjrJQvTViS1Ij6Y5vCtg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,254,1712646000"; d="scan'208";a="42706810" Received: from bmurrell-mobl.amr.corp.intel.com (HELO [10.124.221.70]) ([10.124.221.70]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2024 07:32:08 -0700 Message-ID: Date: Fri, 21 Jun 2024 07:32:09 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/7] mm/x86: Make pud_leaf() only cares about PSE bit To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: x86@kernel.org, Borislav Petkov , Dave Jiang , "Kirill A . Shutemov" , Ingo Molnar , Oscar Salvador , Matthew Wilcox , Vlastimil Babka , Dan Williams , Andrew Morton , Hugh Dickins , Michael Ellerman , Dave Hansen , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, Christophe Leroy , Rik van Riel , Mel Gorman , "Aneesh Kumar K . V" , Nicholas Piggin , Huang Ying References: <20240621142504.1940209-1-peterx@redhat.com> <20240621142504.1940209-6-peterx@redhat.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240621142504.1940209-6-peterx@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: AC14D4000F X-Stat-Signature: 47iqa7zmwskhnoqntz3qth6weam7mjhz X-HE-Tag: 1718980331-571503 X-HE-Meta: U2FsdGVkX1/YLRwgaCRT7v1fz+kNRMqCrxu+Ak4bre8G8b/Jb6Rw9f7MzIth8ATcpA4ajjejZApGEbEAByKCey8Ul6z9aYfIPKkpMn64NAGJM18yP8pysmypkIw+AXhPN1OJz1CLkKPMHbDUhON4IgYJymciAxq1sahcu9glpbPTWUnsMs32b0r7hJLF2zw6AwK8Tr/JusP7RUB6BOh8Qgorwwcx7XA9/D0PBY5Vps8KmoCjpdICcxCN3hfKgLb+uZNLevbeA0OhZEoD12ByXpc4Y7eIguX0574u9N/gHfXNxB6j9ita6PHMRxRjlUuSdmMI8xkOItBuaip2ef1Jlc/ts790a5bpsgQuMSk2XLtrd8DaPcvy3lj/DOukvs753gdaSNtKDoOehjfFmSEvy7uCmydjCaSmncJq7F8VxlS6Bq0oM18C64FdQgFXOgWSOMiMAIjAlRT2DxRwHpvPuC070JD6kxY8nvHBd2M35SOw0zugv3JSQMeKie0Rfks2LxMGoGugOgE1AQ0D3Bw0pJ39kZHcuiT/uPaBYlDXcHPLe2/bjBDL3/Be1/6i9QitUnRiU09eAEaW12pgTBOKLxb6INNSZKtVTvj40pMg8N7kgoz+L4qvqWr5++jDkxmKIV/aHiAqcdTn8VetaXzCG99y6lj6IxCx3IsArJbgRfhfvkooS+OPNzSrCE5XtAnZYtSQkn3LfU3riPvKEuoeTKontABLEYTm3YkmvC4+6LCT/NYyyOq2t1R6FICxl0/Szsh3yOWHlE4Rb+b15qFrwXm32uASlIlYBmRlYYDmkkJN3u/uLI07Ocryk3CpESRc/FHKy2Vg94SH9Ydsi1klmus+NvZ1sIT43kZ70u4umTMZkR2oRAzP9HpfnRhbyALfkD9RUYdeuVvIFvhyFbfy1UEixZcTflguzRysAlw3NIKI+YKOy/iBus6ydVhSxxcPx4qV7ILFRyuIRzsx9Is O8BjeWIs SPzOJICPezDrGvR4Dm3cmnq3I30JiFy3CYV+J3+adW4nAPC9nLU13K16JZndPwt1ew6+mbNlcIN7sSOHeYLHJGfzlSvfKkmxqCYDCSea5Jdpv31PFC1gjR5JLQ56t11e81nxT7FD0WL2yUp9e2m10QqxDptoI5/u9wedkU7NeauXx0sgUPCnMpABwuerkiPl8gRGW7aup8myiFNbisEj+H9C2ceSNEUwKUx5FSJvhxSDaALs+/XqeRrjsvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/21/24 07:25, Peter Xu wrote: > An entry should be reported as PUD leaf even if it's PROT_NONE, in which > case PRESENT bit isn't there. I hit bad pud without this when testing dax > 1G on zapping a PROT_NONE PUD. Yeah, looks like pmd_leaf() got fixed up because of its involvement in THP, but PUDs got missed. This patch also realigns pmd_leaf() and pud_leaf() behavior, which is important. Acked-by: Dave Hansen