From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C73FC02198 for ; Mon, 10 Feb 2025 18:45:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF3616B0088; Mon, 10 Feb 2025 13:45:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D2A5C6B008C; Mon, 10 Feb 2025 13:45:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA3F16B0095; Mon, 10 Feb 2025 13:45:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9C24C6B0088 for ; Mon, 10 Feb 2025 13:45:19 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 28CFB160483 for ; Mon, 10 Feb 2025 18:45:19 +0000 (UTC) X-FDA: 83104912758.12.EAD391D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 765EAC0013 for ; Mon, 10 Feb 2025 18:45:16 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SVNbldM4; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739213116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KSceIq+QW6QfAQSxFrhFP3CSjeVr/8tSdt+enYDxg60=; b=d1m+D1VaDTdC3Ux4gLcpUlrtHKcgCjkgH8jU1P8t6uBMG8W+0MnrZe4CrTmLl4ddtwkzZ+ Ugkqs2mD0euSStknRdozMvNr1l3o4wP51bxHROuBiZN/yrT2PdUEOQa1C+4/RvD4jSNPWg Fpe5gKKRoK1NCJQ00G4KvWCTSheOP4M= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SVNbldM4; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739213116; a=rsa-sha256; cv=none; b=d8apXf+OVIBg+G2M7wZqSNvoehuVl/uUdg79a/LwPqtZ14hBFCWCl0weiBdxA3NPxruBee cAYJoMnf5eB0HQhOve3LQIsz9wEpvRMzBwcJDkLb8+v7nS1Kg0+mBerpUNc0aFa7t32Y59 YvbwQLfmJyHgI4Vf4G1Fl4nSfP0s4oo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739213115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KSceIq+QW6QfAQSxFrhFP3CSjeVr/8tSdt+enYDxg60=; b=SVNbldM4wwu/t97ErQfoCwqhA1QeLW3eHAr2WygoP9yu/5hBWAg8NddK7gL42wveboEou0 NlBjNedXkuGBq3nuDKmAmo9lgER6FGbuc87x9msszrRS9TTki0kb9PyXkrn44vRmFKyZXh QppMZ3YQY9eUCbrPlaTEPs9ywlOg2Y0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-374-KALsaWw0PrOC6NPd_Da-2A-1; Mon, 10 Feb 2025 13:45:14 -0500 X-MC-Unique: KALsaWw0PrOC6NPd_Da-2A-1 X-Mimecast-MFC-AGG-ID: KALsaWw0PrOC6NPd_Da-2A Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4393e8738b3so11417825e9.0 for ; Mon, 10 Feb 2025 10:45:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739213113; x=1739817913; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=KSceIq+QW6QfAQSxFrhFP3CSjeVr/8tSdt+enYDxg60=; b=Y4bw+S7u1sGjhDsSZRZFgdsEDtc+KQQFtBJkcb7gz+jORj40j7MjkmX1H1haVOsCeP 6CF3sRdSjWRrw+N+Ul8hpKOBmuVAO2OgLybnn6Kuj8vsIjKqNXd97spPwX+NFCxFs8IL JlZa/TvWU8QNU3JM+lD/WGj0faWoeV2WClmKs2Y3R4KIAfVCNFGzoqeyA/O3HjYjNlzO 6kzO0qGnDQjQEdF3tqZzel/dbkOhNdGQ8LE0sufutjgpHfYHm7ezdNB8dQHY5WqNYXf+ exaJhj1Dw37r5fvaiupb1z2o2wXzzkJ8V6wZI+PlOHI+ll5FM+PZlHK6o/gBkXCFZ2JK kaNg== X-Forwarded-Encrypted: i=1; AJvYcCXyqXrhx3DBFQqbwIxokeF1E/x7BOc699jTXLVgkAtrmzDCdR5cpXeXS23caDGu0Qa8vWy9Dr6HPA==@kvack.org X-Gm-Message-State: AOJu0YwN6rptZDU2X44rxnrYV/LwZ9PVQLf+YJemKp/BZtAaOgwMeFRD Pyfv6OXO93ZJl8zBXuQhZd6hCho5OYLNerar7ZsdPQBFPuGBStao7fxmUamznWgIwNHFvm+ZAs4 RjBokGmnoMZr6ahYRvXg2DhUbv+bOHmO+SUTFxg7IXIow0iQ1 X-Gm-Gg: ASbGncsv85GPV4AK8yotx/V/TlLEYSNTYtP30T83bHsTkYgOLecZH6XYLubDYMseeli f3aRWD/ER88YvkIuocIRPIeTgqPY+2+hBVvdDsnzK6msi4Dz4UbERP4KAycxtJngBzPaS5d45FR EOiWAWWinLwekeA8W3YGdgPzHcVEOgCuv6FFTX7lzjHl7WZEhzXoAfueXe1WWijfPH9l+IS/EJX sQ2Jc7yAfHYLKU/gsKvIlbX2cSUSqQswlgndpPI32JjrnP9jzsJ/eQvKxwGVLwf0aaOA188qg1J QvbtHTc9wzBYDuDyYEY4ZjbTv3e6gOnAc+T/mO3cuEt9STe5saXcKoFW1KIKAHcyj1BjGNKZgkF 0mEH01+6+6xxIXhmkya0tzWWUPL27nvjy X-Received: by 2002:a05:600c:4f89:b0:439:4b9e:45fc with SMTP id 5b1f17b1804b1-4394b9e4883mr19868695e9.4.1739213113282; Mon, 10 Feb 2025 10:45:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IG1DW8uYaNIQGndHHpAaZ/R379l1WaaDggkqsZF2ysLByrh9c9rDZgcYBCPGohQqt0EwrYjTg== X-Received: by 2002:a05:600c:4f89:b0:439:4b9e:45fc with SMTP id 5b1f17b1804b1-4394b9e4883mr19868135e9.4.1739213112852; Mon, 10 Feb 2025 10:45:12 -0800 (PST) Received: from ?IPV6:2003:cb:c734:b800:12c4:65cd:348a:aee6? (p200300cbc734b80012c465cd348aaee6.dip0.t-ipconnect.de. [2003:cb:c734:b800:12c4:65cd:348a:aee6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4391dc9ffd8sm151856745e9.10.2025.02.10.10.45.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Feb 2025 10:45:11 -0800 (PST) Message-ID: Date: Mon, 10 Feb 2025 19:45:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 16/20] huge_memory: Add vmf_insert_folio_pmd() To: Alistair Popple , akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org Cc: Alison Schofield , lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com, chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev References: <9f10e88441f3cb26eff6be0c9ef5997844c8c24e.1738709036.git-series.apopple@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <9f10e88441f3cb26eff6be0c9ef5997844c8c24e.1738709036.git-series.apopple@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _5eQwz7nzgx9UlCV6TAxiwUFipptV1KiFXBmzwxTS-s_1739213113 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 765EAC0013 X-Stat-Signature: nqaywd6te3uqzf4trzw5ur9jn7hijowb X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1739213116-483260 X-HE-Meta: U2FsdGVkX1+a2V5al23d7EmmyWGOIr8b3J/A34F5MVIAWDD10Hgq1KRY19ydkxZ/KorpREiLOYn68dWzszueLvBEPIVMvM5j2UfzWZbjyeHmq+2GvtcK5Q3liF2eEx8VENlB5H8C1w4eMKYgyMvtmWYWj99R9tvkVLQGe2YvvmZdqwlWOFTS9UZvYuOzmv6aEVSvYwT/EP3W6F1riVSw/XHKVQUK/FyQ1VwcHcZmSi5rfmaN4UIqyKdnczrYiDz2dKah/Lee2YzEMv2AcJVQENwJsDnVM+AyPwDesqdwXglnvtxnAW7dgEL4d2m7nqjlOJBCFrCh8/0WTW5bycApN7+R3TC79kb41MEhKt/3HA/EmXZ6/2v2usIEj4QYq9s8fjrAamhcGDHpph5HlV5qX+ZUIbgFPx2u1bILt3ErqJZkdqAtonkK8p/7vqZ9Qeh8WgNT0ogcCpR8N2mtMDg51HQ2Agof7Et6rB+OADGynY7UV9uhWwvKlv/xa3t2wP2G3EcwVWtRaMLJlm7fpkuLEScHa3pKFl4OL6z61Z958kHgiC/6MXwoZ7p0r0PCbVJShFjRxhv269uh2gh+L2iS+dLwARdmQ9MLiKp2w+jdvd6XoBs6EQz6KrjDrYVX1KSRQauxNiF1snXMfEXLOuLuPAOlo+A807TmFdG7gfXq+tyR4SoCXBMyrHye3R9YegohZ8InmqKUIDVajaRhaPdOicyQ3id+QYsiFha0DEZp3Kf1XEW2AfmDrWyw83g+DvBxObp8NJv0HS5KoCqioNxKVCkg2ralSW5T9GmaVT74qvIFv1VldAP22X1WtQY4LKs65rtVnsa6nlp84l74Wk1QdIxPXy14R9YnN9YYPeOrJJWZ4bCs58Qw6OcYdIbirw/wfG+e6Zgk0w3gM7QatXltxujXrdZEc/9RHoiJCPPd25jl1HPmRRKGVLZrI6Nwn2mGYeIFNm0tMo6LGnWxAgH WpX1nx8n GlXLpsDdJzWMnHiInj2lxcjm8kU0+qZ9SJ1B+2fvcQRHlS3xfKGo6T0CKdksV54rx7rz4OEhrEb3jJPWIGd8yHwgyf0lisXVwRkMTbK6JWaLN+NmINW5XxsVFb/AB0gF+kjfdCHvxWVzMRaZ4pGbf279rlb9A0jdhmkluA1GvzLxfgrlob0kXAXDkLaB+EamknlhxzfW3snVfAhOlgSbiJDjqivZ6vEGIJBaX7U7oPURJITy1CUDxM+S7iRasNmHEtBRg317b1+Kvm3iZdj2V5GMygd6vQtyE4TjEAfI838yLpgRoRRqqaxzst8Zqv0eDCTqfh+kvi7us95PW+s9x+lWEa2giQ99VJWt6nBz284p3HU1JbUBLzY/S/PVyb7k5/oo9Wl1CkZfT7KIby8uvCAVXmj+Y4Atylg00G2O+DudNXue8d26xekgFzAnC9HDNaSY7k/c6YQIGxpm2k8Zda/bOL/A846FaOhuTSwy+qFeuVcGqifjBdd/4h4sepsa8qe8glohlmLgiHsruNT5BN2fEXUEojh9Fy3Hj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.02.25 23:48, Alistair Popple wrote: > Currently DAX folio/page reference counts are managed differently to normal > pages. To allow these to be managed the same as normal pages introduce > vmf_insert_folio_pmd. This will map the entire PMD-sized folio and take > references as it would for a normally mapped page. > > This is distinct from the current mechanism, vmf_insert_pfn_pmd, which > simply inserts a special devmap PMD entry into the page table without > holding a reference to the page for the mapping. > > It is not currently useful to implement a more generic vmf_insert_folio() > which selects the correct behaviour based on folio_order(). This is because > PTE faults require only a subpage of the folio to be PTE mapped rather than > the entire folio. It would be possible to add this context somewhere but > callers already need to handle PTE faults and PMD faults separately so a > more generic function is not useful. > > Signed-off-by: Alistair Popple Nit: patch subject ;) > > --- > > Changes for v7: > > - Fix bad pgtable handling for PPC64 (Thanks Dan and Dave) Is it? ;) insert_pfn_pmd() still doesn't consume a "pgtable_t *" But maybe I am missing something ... -- Cheers, David / dhildenb