From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DEF9C4332F for ; Mon, 6 Nov 2023 14:26:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B553E8D000B; Mon, 6 Nov 2023 09:26:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B04C28D0002; Mon, 6 Nov 2023 09:26:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97FE88D000B; Mon, 6 Nov 2023 09:26:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8760B8D0002 for ; Mon, 6 Nov 2023 09:26:55 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 654D8407B1 for ; Mon, 6 Nov 2023 14:26:55 +0000 (UTC) X-FDA: 81427755990.20.350D0D2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 21DAD4000E for ; Mon, 6 Nov 2023 14:26:52 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gngeDs8x; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699280813; a=rsa-sha256; cv=none; b=Vsm3XKxGL9iF7IEw+E2xfdzM4M1X8goey6gEwVCKmUvnxeyJrlt6SJJwTIcjGwvPoFh0GG Vt/fMQ47pt2rLmX0DB9kGkPZI63008m76fhASQDe3MLwAcc00msQIEnzDg8E7LMeQFmPQ7 RjM1pXSNO3cBUk/ScMStDbmCKUC96Kw= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gngeDs8x; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699280813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EQEY0yLpyjybbnIksSuJ4Z5QD7aeTkworRxg3pV8noA=; b=H/AP2wvztegr+FyyuAHtshvCychoekTUx5Fd80RFBkcH2LTl1xVM3H8BLCxRio1Y0dgy+Q mPscMg3rvTgCL42LbHNpQ+JbjGbK5krCWjZXq1pk16To5Kroqruycdhkwr8jzDDd7n/Xka PUNhWocN4ADKbhcGa1ykzNjU6stJx4c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699280812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EQEY0yLpyjybbnIksSuJ4Z5QD7aeTkworRxg3pV8noA=; b=gngeDs8xAco83V7a6DRKrqE+hNpiHT5bhXsGGW4MZJnddCderUplkyn1FEahFcH98wTBpX /QItPlYRKrLs6TrSelDsBstgYAe9TFm5oXSwF1jxVvjf+KM9I8XsmsmlM2zC43btXoY0Jv GRqKptMnzjntXgEROSLgcAJrgV7pY3Y= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-541--7d_noxpN5W2cmt5W2OOww-1; Mon, 06 Nov 2023 09:26:49 -0500 X-MC-Unique: -7d_noxpN5W2cmt5W2OOww-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2c6eec16401so47425401fa.2 for ; Mon, 06 Nov 2023 06:26:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699280808; x=1699885608; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EQEY0yLpyjybbnIksSuJ4Z5QD7aeTkworRxg3pV8noA=; b=D4zJDmdQguyxl2IZu+L1jS+0fwoE2xX+404oxlE4Qv5UYVHFmxefwRD2ag2o7tXbB8 MEhI6xHqtmpN03WWYGQi0rOuL+TY81t5WKwxLFeIzn+i8mbLLQDecirYmQYJU3k5gTll etAkEcwAhJR45rcYudopAdMzdxxj3gGB7uM0O+gfIGgkEwqY1rGK7Cega2L+dFX73Wco 7i2mqs/PzpuQ2tp+2J/AdD1j8CNx+RC5Nk0VEsb38ANObGjYrLLeXi+2SX3+O2r3nCky SOAzJbvoQCPnGDCTzgI2S/AvFG1DCxHtbpQseSATXhjDUxSnzP4aQJV3eUFxV+ToAAli catw== X-Gm-Message-State: AOJu0YyixLlU/yz9nzk4s4TcWaD6Z+86C6CD8YxpF+4z6mYANW/6vjT2 zPzXdWTCyuMhp8CQLHghxs686D6sv/qzWOAvGmJBIVSj+TjVl5atIyNEYDJiGn1JFi7pdzsa+Q/ YhqkfT/dhrcc= X-Received: by 2002:a2e:b953:0:b0:2c5:2d02:ed14 with SMTP id 19-20020a2eb953000000b002c52d02ed14mr21572231ljs.23.1699280808167; Mon, 06 Nov 2023 06:26:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IGe0jlmDLWFqZf1fufd7JZlCly/w1zvo9x6RPHgHPz0rI92EPGNolcWdP4AapnywQ3Fs4WFBA== X-Received: by 2002:a2e:b953:0:b0:2c5:2d02:ed14 with SMTP id 19-20020a2eb953000000b002c52d02ed14mr21572194ljs.23.1699280807790; Mon, 06 Nov 2023 06:26:47 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.googlemail.com with ESMTPSA id l41-20020a05600c1d2900b004083a105f27sm12541348wms.26.2023.11.06.06.26.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Nov 2023 06:26:47 -0800 (PST) Message-ID: Date: Mon, 6 Nov 2023 15:26:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 31/34] KVM: selftests: Expand set_memory_region_test to validate guest_memfd() To: Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8?= =?UTF-8?Q?n?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-32-pbonzini@redhat.com> From: Paolo Bonzini Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <20231105163040.14904-32-pbonzini@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 21DAD4000E X-Stat-Signature: y9gzrmibx3nr8fensqsthwbz3ikytp4r X-HE-Tag: 1699280812-442954 X-HE-Meta: U2FsdGVkX18W2nxf7m1qeB8AX8FvTJxMESWXYy5xWLeKrJvYiAGt56S0/A0mEljaP3TAAGPGFwg8zb1Pn3gYX//m4AigLVRtezMsu6xVrQalEKf414LHr+0meQQ8/rq7qpVPdOENt9olhseNjM97su796w0gPzOUlLbteG9zAXbz0HpvLeGE61o+RR5aFUpo5LQJHxfnaxxAY8gqWZyTbBUr73C62cy1s0Qz5cVO0yIRq95YcKm119dcTvTorr8z7VFGyfymUNQQCmyTfGzm9KE01qcEL1FKSH4EBNs2Y6rJOoVjDZTEEuYAvSiCQcdyuzniYtHb062oLu4fJkM8BX4H39jk1Ki4RoaeEj5C0HisaGNJc/RPz1UNRd+2hxTKbB4M0ObYECFGZNWjw4wFLOBwQ6l5WLKD6y5xWqEIkuFDloY01UEm+UME3M/SI1Ow+ClG0mcxxTOaiWW0RNKKFl/iH0oPaDtrHKB30yCPvBNZudnJBGiCeNmTB2Tjj5wJM0lQJuS3ta6nnlMGhJBCxIKqmBFG1SbaXynkNe65wXH+/Gsf1sQDOdoB/qW8J6pp7NHLbSUlBp5QPzQXAzTIAPpEUzAnFuWk0HuEsGu3LRmsl4Blea7bB4fxe0FWA7EvWEyl2pvuzMVirF+4T/VocgR1PEMf9bhDSd/9Xc7ZJntFfxV7NqRgZRAvvYz+GGEC36DljP+j3eQVG5avxL4I2tkwTFa7wCYxnXjvfC9uu41N2Z561YKN8nlCAJycpQZ9KHziOPG8cR1UY4rPJuFE3YPMPUyeMR1FpCWBBF7idlLt/r2MrjgLybzMq4Li9OCt+/gtk5ZPGRc8yBUXmtU+P/Wy59XP0dS+KGH7lE53BSEl1FnTCZ06wVHGsFc6GXkYyh6yAeq1oFsRQWG2zaYU8fjrcakqkBmCxdsTWtfTD3gSPeytBApzQGSXZZhhK03uwN75o9jppj4Jgj9i1TB wmV6IUgT EyEXjCSTL6t7KLOP/uLKvLD2cGimY/gB8N1V+YBEdePB8TjH7wh/Wi+p/0UD3yglCFR+bzhtizz7q2CmPBgwbiFyLJF4KQuB/8YQR73sLFpWnFny+jfNwFRahM08Lzc3OeSRzQiqz4P6nHw88OzM292xusLN9PvCMra4OjiBvlTt/zGutaEJGovYsPike/F1f3wQSZjWO/k6GfjqYfpes8zr1p99cm07bOlodDtC+Jg2xb43bSJX7A31k2v8Q/5f/sSG6CNHIqKFaRkUIalPpS0Fs5O7TTuF+pRANRLiAE1A73LLd1b+OURE2z2XJpBQyPfH5ARoehnHZfC5z6i65FdeKoqxdJ8XyL3N+qWDUPYwShyFuSPOCqLEDgABAnOuBn2nG4W/PnoGtmmbtvv6jB3avNCcC4mz8VvrC4kvntY5vn99p1P9MuxVEng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/5/23 17:30, Paolo Bonzini wrote: > From: Chao Peng > > Expand set_memory_region_test to exercise various positive and negative > testcases for private memory. > > - Non-guest_memfd() file descriptor for private memory > - guest_memfd() from different VM > - Overlapping bindings > - Unaligned bindings This needs a small fixup: diff --git a/tools/testing/selftests/kvm/include/kvm_util_base.h b/tools/testing/selftests/kvm/include/kvm_util_base.h index e4d2cd9218b2..1b58f943562f 100644 --- a/tools/testing/selftests/kvm/include/kvm_util_base.h +++ b/tools/testing/selftests/kvm/include/kvm_util_base.h @@ -819,6 +819,7 @@ static inline struct kvm_vm *vm_create_barebones(void) return ____vm_create(VM_SHAPE_DEFAULT); } +#ifdef __x86_64__ static inline struct kvm_vm *vm_create_barebones_protected_vm(void) { const struct vm_shape shape = { @@ -828,6 +829,7 @@ static inline struct kvm_vm *vm_create_barebones_protected_vm(void) return ____vm_create(shape); } +#endif static inline struct kvm_vm *vm_create(uint32_t nr_runnable_vcpus) { diff --git a/tools/testing/selftests/kvm/set_memory_region_test.c b/tools/testing/selftests/kvm/set_memory_region_test.c index 1891774eb6d4..302c7a46955b 100644 --- a/tools/testing/selftests/kvm/set_memory_region_test.c +++ b/tools/testing/selftests/kvm/set_memory_region_test.c @@ -386,6 +386,7 @@ static void test_add_max_memory_regions(void) } +#ifdef __x86_64__ static void test_invalid_guest_memfd(struct kvm_vm *vm, int memfd, size_t offset, const char *msg) { @@ -476,14 +477,13 @@ static void test_add_overlapping_private_memory_regions(void) close(memfd); kvm_vm_free(vm); } +#endif int main(int argc, char *argv[]) { #ifdef __x86_64__ int i, loops; -#endif -#ifdef __x86_64__ /* * FIXME: the zero-memslot test fails on aarch64 and s390x because * KVM_RUN fails with ENOEXEC or EFAULT. @@ -493,6 +493,7 @@ int main(int argc, char *argv[]) test_add_max_memory_regions(); +#ifdef __x86_64__ if (kvm_has_cap(KVM_CAP_GUEST_MEMFD) && (kvm_check_cap(KVM_CAP_VM_TYPES) & BIT(KVM_X86_SW_PROTECTED_VM))) { test_add_private_memory_region(); @@ -501,7 +502,6 @@ int main(int argc, char *argv[]) pr_info("Skipping tests for KVM_MEM_GUEST_MEMFD memory regions\n"); } -#ifdef __x86_64__ if (argc > 1) loops = atoi_positive("Number of iterations", argv[1]); else in order to compile successfully on non-x86 platforms.