From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD285C54E49 for ; Tue, 12 Mar 2024 04:58:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B3506B0107; Tue, 12 Mar 2024 00:58:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 561AF8D000D; Tue, 12 Mar 2024 00:58:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 429646B010A; Tue, 12 Mar 2024 00:58:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 30A786B0107 for ; Tue, 12 Mar 2024 00:58:29 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 00AEE80E33 for ; Tue, 12 Mar 2024 04:58:28 +0000 (UTC) X-FDA: 81887181138.02.EE6985F Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) by imf25.hostedemail.com (Postfix) with ESMTP id 5E3C7A000C for ; Tue, 12 Mar 2024 04:58:27 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=h6QTprJc; spf=pass (imf25.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710219507; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YE1RJvCCOc/EPRwrM42zHZ3v+Ktd8fYS0EGnWpzzjWA=; b=PSq21HcA+s30xQwQkaGnssWXxjG8xW22ExbIjv+19yNzzTlx1M6ar3cBjizLj74m8LFPRi SKj4DgjBDo4GMTewJUMSK24WaApcwRlKRidc8q2pp9MEajVeajjKHvj3P+5KYtGBpqKdRK QhWAw3zFBr+uSpZKiH9eGknYC0Xfsgs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710219507; a=rsa-sha256; cv=none; b=UnWX/MXjiFW7nDjfdlspYkV1pNvodzx3sWReqvfbU2Fh1k7DS0AoUOkwcHhlUDkC60Nq4O MYGzSfbsU32aAGsrr9/SbffcxvzOsn/GubJkF70G0K8+f6eNxyvRsoiD7difYdOBmHoQ14 sAcS56LvXG+MAj2NzNInhqw37Czw9Sk= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=h6QTprJc; spf=pass (imf25.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1710219505; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YE1RJvCCOc/EPRwrM42zHZ3v+Ktd8fYS0EGnWpzzjWA=; b=h6QTprJcRwDIvZD9ZZ2dy/M0LKviyZxlEeF0pVMV+3Rg8bjsIXTCNvQnpFKjrPMJRdnq/1 RRWUkBUailildodP3WpTMS7+2BbBrVbSqY7vw9VcuhZvKF0ieZxxQg1VnwvVL06fjJZNJa HdljuodYuF+pBGJK2ctuaJMPs4OLFV4= Date: Tue, 12 Mar 2024 12:57:58 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] mm: zswap: remove unnecessary check in zswap_find_zpool() Content-Language: en-US To: Yosry Ahmed , Andrew Morton Cc: Johannes Weiner , Nhat Pham , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240311235210.2937484-1-yosryahmed@google.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <20240311235210.2937484-1-yosryahmed@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 5E3C7A000C X-Rspam-User: X-Stat-Signature: y1f8sp9nit1j1mcsxkfsqzw9yjrk3uz5 X-Rspamd-Server: rspam03 X-HE-Tag: 1710219507-546176 X-HE-Meta: U2FsdGVkX1/Jqya3C8akiAz+T6reA7I72CftzSp5Dx0ZXhWN34v5vAUlNT7/3AHw7xPETmsrBCf2OImc7BuU6tI7VwI3MctsZl0MWXx53O9XF5d3ea64ZpLmGGDQ6QfzrjuPR6Ve76khj+4g6j/QuYIZVfmyQKTzBMd4e3hTgOZQAP8p5JSWhIFQd9iQKY9R1IIjEeT5xbR8+vk7XXnrynh6xcSxucopyC6LOhuH+PW9psQPALQWgAnp71S/2z8mBibvfJa4wNVBAQjPOrhsA0TixP+5aahOEU2le0W/Qec+MAZTH7kvq2FhtvtjLtOqeySVzaxpyHWa9CWQyCZYyHBYdEyHscVYXJHCWj6Z+gbQgqVpxKs1lXZAG3X5IRUJFtshU2lnunFRQow4J20pSFTJmlBYeIr+EiQiGLweHD5A6vipw/j+Mzm2YP1YIQ7AtHSe/HtavCedtuQ+ONYJa3P5tVgU7Io3pjGF/1HROWM2OPK6+4vHafl+FY1BGG2eQSeh8IFWoALBydakRW/OSB6bCJbc1yfyp7PaXHHlg40BG9WoYwJNLSGgjTYf+550TUJthRYVQCkJFueT3DJYtdOOYEcNt8aMYVwZh1zS7g+zQTAUohyPMqyZWoDmlWdNimn9K+nXyQs/EoThXEegxTx0VE5bgt5zxuqv31qcv0qetbWY86o34vYEIlFJ5MlBfUr2ofGnv2KL0H9gccAnBPgGWE90Atw3DKM8DvFM5eA9I5EY9aaONkMkZf4pjGRFshx3m7UoF4HD5QEKqEU49LIFuydjioOdRCXcngaUfnqzMTH5Vk6jZWt9FmXA3BEzqKWNy2g82bGC/UnICX/kjAqeekVw/uUw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/3/12 07:52, Yosry Ahmed wrote: > zswap_find_zpool() checks if ZSWAP_NR_ZPOOLS > 1, which is always true. > This is a remnant from a patch version that had ZSWAP_NR_ZPOOLS as a > config option and never made it upstream. Remove the unnecessary check. > > Signed-off-by: Yosry Ahmed Looks good to me! Reviewed-by: Chengming Zhou Thanks. > --- > mm/zswap.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 9a32377520827..c6267b5e0999a 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -884,12 +884,7 @@ static void zswap_entry_cache_free(struct zswap_entry *entry) > > static struct zpool *zswap_find_zpool(struct zswap_entry *entry) > { > - int i = 0; > - > - if (ZSWAP_NR_ZPOOLS > 1) > - i = hash_ptr(entry, ilog2(ZSWAP_NR_ZPOOLS)); > - > - return entry->pool->zpools[i]; > + return entry->pool->zpools[hash_ptr(entry, ilog2(ZSWAP_NR_ZPOOLS))]; > } > > /*