From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A689E7716B for ; Wed, 4 Dec 2024 13:58:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A6986B0085; Wed, 4 Dec 2024 08:58:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 856956B0088; Wed, 4 Dec 2024 08:58:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CFE36B0089; Wed, 4 Dec 2024 08:58:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 461566B0085 for ; Wed, 4 Dec 2024 08:58:33 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C049D1A103E for ; Wed, 4 Dec 2024 13:58:32 +0000 (UTC) X-FDA: 82857431244.24.BE5079F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id BA34E100003 for ; Wed, 4 Dec 2024 13:58:02 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aciKFBDC; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733320703; a=rsa-sha256; cv=none; b=ZzFe9GpcU3hEpyDv6KAzSR323Hz3QcaJ4oXqiKPbwN038qUOZ+PaF9Ab8L6b+EyNhRNyYV MRSi1LeggtLPWb0jvedbKm7tuojXiVXTC66bBqt8xF2fZxTEpIbvDyv+t/Cux3M/MgN6Bp e9mnocHx5KICP47yDuaobB9n/RCwrL0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aciKFBDC; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733320703; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/Ge3P5QrwycOCY0A4lyMEdWhseu1xqi0rOs8L5YD5Q4=; b=6YKtH6r78SAVgVUJkqZr8zjp2IIMCFTK0qnsbmBbCJKevT5pvEVJv1Wwx6FIUf4/EHF0Kw OYMQaXax1ML/znGNXgkV8qz5zbOMEt3DTdHpzsdtK0HpaL7Ua1XJ8i8miZ/+ORKGDV5Ojf oHxB1gm0FBKVw6LbQcgc6kPMyJ1qzec= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733320709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/Ge3P5QrwycOCY0A4lyMEdWhseu1xqi0rOs8L5YD5Q4=; b=aciKFBDCLxkuzng3iF2jKG/u9Lz0A2U7Nje3vlk1ReZCU4nK5HZT7XpQoz3JY9H+0QUGep 5CsDdmNCJaj7oE4zx7a5FfqP6q7MYwAsOVBWXhbr3twlF/WgsdYm3t4T6ybHWXq+jTDK1P HrzUw+fr0NlaW5OViCcmDQHEElcDMyo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-328-7dsqpIZAMBWrO5YvYVCvcw-1; Wed, 04 Dec 2024 08:58:28 -0500 X-MC-Unique: 7dsqpIZAMBWrO5YvYVCvcw-1 X-Mimecast-MFC-AGG-ID: 7dsqpIZAMBWrO5YvYVCvcw Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43499c1342aso48638645e9.1 for ; Wed, 04 Dec 2024 05:58:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733320707; x=1733925507; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=/Ge3P5QrwycOCY0A4lyMEdWhseu1xqi0rOs8L5YD5Q4=; b=TIZlfbrGQPg82DoeGmgeamtCDQsGpSRAcli8yXCcvmKKY3cj20de6zBW8JlUB9A1I5 fwuoWD7UukBI5Tbm0se3WS/xW/1ZyImcVd3lGLSxzKiN6/AZ+ofk7aDurODlKQMlrcPA uL8Wq7TIHGweOQmguFsp7N4kn41/4BWdZI0dxwT7fMr2EtrfdWEXsSs32U0Q3JH8ycmH vGpdtx8Rt/Ybr/Imje6bePF5uqWBlh7WhDrID24A64HNjJPO6URB87EmlIXYi2CRMQ+V gMpKHOwvxmQ9kQyyE6QqtQ+uOhqnZuJIela1d257H3n77KNMCs/ArPiAwf5pyelClnGm nueA== X-Forwarded-Encrypted: i=1; AJvYcCVb5vI6hzlcVkdCmUpvKh3dinonW/J42Aj7CkaW4nv9QHTAwA+BAyqKbwlCEdFlLNKL+rr/y7I/vA==@kvack.org X-Gm-Message-State: AOJu0YyCXgaVZLM+1dk4BxnD0R5JnUZxfAxd3Rn3Ph19wfMTI9irBmzF dEED7mMO/Tv5UGajCHsIE4fb648582wZED796NwTUc8rL7CS8ZTfdCwIKbEd2kR0x36ZrxDZ//Q V27szQoumyJcV7tRapOgnwj7tlqpEKzGHFIyC2cSwjCN7lkZK X-Gm-Gg: ASbGncvoqmEHt3eB0QbD/gt+FbTQsGbT3QLhX5nZOxcvhw/b0IkzW76BqEc0+4/Gt09 Pkkp2NItBuVQ14o+ihNL2LWsEyWSIa4NEcnBHNYbugP8CsdWOwrG2Of94Rh7Q65/d8zy3JEdaKl zoKGzonQz/MYuLwh0TRZkgvTO36sYgbqIOf0H+anHZj+o4dHAjbcGE2uUZ/0TJHY1v4carmwLY2 mv8QH5XMPnEnzpfeHdeMcfJOyraga2wzb43LqA49FfIFYdjQaK0NyU6CEbsUJi6poK0hiycwwCK 5seTF4hvaur85nSJeVU2CfjiPcUY4vrt460StPtmpm8y/vUw7ORyiRIG1iW6J4KAOyjaNPQQ9JJ tvg== X-Received: by 2002:a05:600c:4588:b0:434:9c44:678b with SMTP id 5b1f17b1804b1-434d09c2766mr58473755e9.19.1733320707305; Wed, 04 Dec 2024 05:58:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IElN603lJlRKvtkNdKgM2pPPCehdsoYMZRNS4kbfLo5ohZQLR+a3pRZEpRzP5ENhNwbZc20gA== X-Received: by 2002:a05:600c:4588:b0:434:9c44:678b with SMTP id 5b1f17b1804b1-434d09c2766mr58473585e9.19.1733320707018; Wed, 04 Dec 2024 05:58:27 -0800 (PST) Received: from ?IPV6:2003:cb:c70b:e100:38d6:8aa1:11b0:a20a? (p200300cbc70be10038d68aa111b0a20a.dip0.t-ipconnect.de. [2003:cb:c70b:e100:38d6:8aa1:11b0:a20a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434d527eef8sm25224535e9.15.2024.12.04.05.58.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Dec 2024 05:58:25 -0800 (PST) Message-ID: Date: Wed, 4 Dec 2024 14:58:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 14/15] mm/mempolicy: Add alloc_frozen_pages() To: Vlastimil Babka , Zi Yan Cc: "Matthew Wilcox (Oracle)" , Andrew Morton , linux-mm@kvack.org, William Kucharski References: <20241125210149.2976098-1-willy@infradead.org> <20241125210149.2976098-15-willy@infradead.org> <2A0E6E69-5765-411C-8667-C49A2392F10F@nvidia.com> <0583ccce-538c-4291-89e8-2e0223b2c7fa@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XwCitaCZHZV7mjhIM-Ws3zdioQWfMMU8kHGgnhtuq0E_1733320707 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: BA34E100003 X-Stat-Signature: agoegxckq75e7so5nw9mtq8wdiqeghix X-HE-Tag: 1733320682-706691 X-HE-Meta: U2FsdGVkX18YAPmuT7SdW+/XmQLVFJbhFpLPTY9Ej2fzmb1JpMfRBc7YR2WMtsqxDraRR0wVx4ejFqViRKuyOFT0sOf59zCnOGjcDT+XdxQ6J3O4dWJVBSF3XURABqeZEhf9NKasnsaNfLf9Es0+GAcQbs3yxjuPYE5HV7hgnkiR1WPvAi3OmIYMRjwZAb5U77ED5AFap4WcnyioBiixAPfecn4wG59GBVaAjOYGYJq2jSw9PHSq0BXbBXyj7YGFnJxUVyp6LjZNK+dp164wPUaTvPFB/Z2tv++A/h1SwkORm6arqheMAoeedP8+oAtla8OcMvvhdlDMrGi9UXk+ga4sSfSA+iLIudk3DV7+KDtuz0xRxpYVp4IATTGUDDmSEX9bo/1dmG+h0KucLol7OKcN+ERbBgKYuy1K0GRKisSNBB6q32cpunq8/vti2NO73IaYnVqNDVRMGO+Tc7IUUTxSo10z3JGwwPjNdGOUEUI5bBWLdzI8zUcwwaTRjXzSQZE9MRUjcuZmf/t+QmrHIC4aaXCJ0Phv74/yg48DscEs8v/1+dv2NWOLeqXnJq6eujztedeX+zu1AJoGfFTWN3XyqF9NT+lvkqVFN8xJkp4tMr0/jcH6Ti73UcILfMNRD61xqtvlKEQabh9FOTUpFY6y6trbIYZWroPcjumpd1q9j/HZR3SbroDCpu7AG4541zWKUxwuC4uxqgrrMzH/WWwLwuNv2+WJ+6S+LWwMuWeOD3cEd7qP0Rliq1vlFdp4l1PK1PYCJZzifBUeJSShl7Bt9EOQxVZ6lT40Jh+V4/weJm1DzIUgH/JmYNJs2KHZN+yT10MM+UrJFdt8bfDBC6GI+y9T5dn8XN1khaX/nn4L4vCfEsO25sr7VEOkmE8xYVKAhOnG63rSNVgzOY/ju6mnu17kts7sCrNJyUl+sfoZTJoTf3AZZLiOS8smlqv04oPs8Yd320ZqxODPEtt MjVFeI3D 7i3HODdU4p2Hz//bZkgDeQUD7BKxqxh0LWRaY5dXHoYwxjscRpy5hjqOHD/2h3bzGRy2khAdMu27pWjAFkiIxrxWiUB6hk7lrS7NAmLnTsD6P/AYIuI5Qmrhb20vggMJySrUKrvF055WA4mAB9v7G7Dpzc/qRmeKPnMnsPQOUb5MshVeW0cSpWbBLQTnwJNUOEDCboGSq0Zyl38rdGnKSGBOx5Ur3JPfTYSpWM1zpXT+H0T7t4LO5e8Ch1MAy9Q6Uc74cpLePvDacUfZCJXoUpFZcm1cEDC9ISa1OuPrZWZifBEjNjrj8sEAqeWy+PSy3Lzxpn2tFXOErBwdJNFXahLbzZFV2Nads2qcHgNMaGOgWQVJrUIxOapGA4YgaNrk1+daPq5h8d088kZLTgobpkzkBukZ902Vzzpzk1vdz9angcWNgbGXMuzjRrBdA2kzbd2xR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.12.24 12:34, Vlastimil Babka wrote: > On 11/29/24 18:18, David Hildenbrand wrote: >> On 29.11.24 17:29, Zi Yan wrote: >>> On 29 Nov 2024, at 9:44, David Hildenbrand wrote: >>> >>>> On 25.11.24 22:01, Matthew Wilcox (Oracle) wrote: >>>> >>>> What I don't quite like is that we now have a bit of an inconsistency, that makes it harder to understand what gives you frozen and what doesn't give you frozen pages. >>>> >>>> alloc_pages(): non-frozen/refcounted >>>> alloc_frozen_pages(): frozen >>>> folio_alloc_mpol_noprof(): non-frozen/refcounted >>>> alloc_pages_mpol(): ... frozen pages? >>>> >>>> >>>> Ideally, it would be "alloc_pages": non-frozen, "alloc_frozen_pages": frozen. > > I don't mind it that much as long as it concerns only static functions. We > didn't add _frozen to all those in mm/page_alloc.c either. > > The exported ones seem consistent, AFAICS? alloc_frozen / free_frozen even only exists in mm/internal.h So at least to the outside world it is consistent. > >>>> The same concern applies to other internal functions, like "__alloc_pages_cpuset_fallback". >>> >>> Or all internal functions (with "__" prefix) give frozen pages and external >>> ones give non-frozen ones, unless with frozen in its name, i.e., alloc_frozen_pages()? >> >> If we go that path, we should make it consistent for __free_pages() as >> well I am afraid. > > That one seems to have many callers so not worth the churn. Agreed. -- Cheers, David / dhildenb