From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D012C83F1A for ; Fri, 18 Jul 2025 07:19:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00AC06B00B8; Fri, 18 Jul 2025 03:19:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFDC36B00BA; Fri, 18 Jul 2025 03:19:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEC446B00BB; Fri, 18 Jul 2025 03:19:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CA23F6B00B8 for ; Fri, 18 Jul 2025 03:19:17 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 693D9140323 for ; Fri, 18 Jul 2025 07:19:17 +0000 (UTC) X-FDA: 83676534354.20.43EF3D9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id E3B4D100004 for ; Fri, 18 Jul 2025 07:19:14 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jTcYNVEt; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752823155; a=rsa-sha256; cv=none; b=0K/IE0/zSczSTPWj/Q9ifgG5MdMl2GXuG6fK/GgHu/NhVCfgKwJrEuxupa2vmLRcp3UIct qaYq70z421RqHb9bMRy1GLW2v10uMBjNQYlzvjKI6QpyJ5yoA0lzHL7nsBLZWT5kEgCTv1 ofoKMuIEHLwwZtGbjWI8LMQxshi0Rtk= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jTcYNVEt; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752823155; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IUhvR7VOm0WPrltR9SY/XSH6JjtiTjQE95nzmI5fbR4=; b=1T5dNQ38AZ2Di26FTVku0G77OcbXyNWARqeL+wJ6RgRBUz1knlegrJGtAF7g7whjO6A3rM n6iqiRiEeyW+1DH6mxtPruwuZFBURQ6w/zfFostRyjs/7mzNc8EcOaNgC2CfjvVjX6EDjy rXzQHinrLpQl1lnJYLmlij9RPuvqio8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752823154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IUhvR7VOm0WPrltR9SY/XSH6JjtiTjQE95nzmI5fbR4=; b=jTcYNVEttRYkzY/xj1SBsoU5wfcA90t5duVx+j7yHNLJSEVgEt0fFimS3mh7RWL9vaPjur up07/fhX9UTitk/MemVTh1PFG8z7wG0GRkicSGGBx/oKRc/N7g3ur7QRDvYZEZx9PkBStz i+KlyY6aME8RN6e1phP2bA6uS969krI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-108-X8PuP0FBPYWllrwv6vrdfg-1; Fri, 18 Jul 2025 03:19:12 -0400 X-MC-Unique: X8PuP0FBPYWllrwv6vrdfg-1 X-Mimecast-MFC-AGG-ID: X8PuP0FBPYWllrwv6vrdfg_1752823151 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4561bc2f477so10717895e9.0 for ; Fri, 18 Jul 2025 00:19:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752823151; x=1753427951; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=IUhvR7VOm0WPrltR9SY/XSH6JjtiTjQE95nzmI5fbR4=; b=jarrmz/1ezoS6ZrurKlccBD81KVDKP75BGLY7qzW4qvhH35ooudhU/KfesR5vh6q1m 9v4z65/HIZZIjCx78uGmDErfulas9Bw32JIR0/pmIyTb2GiDfL4Oq8G4dUOD0qYARk40 yJfeYWd1Am3BCbMPAaNCilVIe5VkuX8e/zojUQ3UJCocg1stcsaqALDmXH5Ssr0sQYJa d3dJvUQghW6SZ309dD10YQUvJCfauASyDRQ6ffd/GOGTRp5fuIoZvB81LsxKtyrU5rnZ PdT2CJrajOQ6Sa/siHKST7q4qEGn3CFWWvYNgYjJjE/cGJ4kUkrQG3gYAfxH6465Ty5P Uh8w== X-Forwarded-Encrypted: i=1; AJvYcCW9UFe+zpOl7nyfZNFXoS4jShIafl7vyznpAXLLMtdVqlJdVp9nvRw8oAgNbblBj/4hdl63n7Mc5Q==@kvack.org X-Gm-Message-State: AOJu0YzCohbgjM1TU4kLkQo8rPD6B6H5DznWQ601EHSN+pR38wtFM0zk xj0nVm1d1nWrNlBrLxkELsc/j7zLSiLuiCLx53/WPuZDW6ebvHZAbdJMw85Ygq9wqksl1pIUorv wzGCVK/5WtZN5//Y2qTYNZSKiB35P/QQwohsKUgtH/YK1bVee2GZF X-Gm-Gg: ASbGnctUf+lTzQQ3EXJM6S0bEi4PafmjtXc0R+zm8BCcXP+dlWt48qZtkGvK9LKZqO7 EUoGt2wRTCuZRVIyB421X5gf9eka68ME/a2ekR3QCPFICpkpv7haMn5ldsx+XLO1xcRX8YOai9l nrbjUOPKUsw5J/Df/iNQSzoyrGjTR6s7scXe2fbp+YS15XWdqlWe/9ehsFmHPIdYZjjNoCim9YM mjbhbc4JxVWnbWu53pUZkIdNdgBJvKF6rQD8pi2gxiRoBwZTWuUbYs0riqFXO7zS7jjQQposIdq TNxRpbfjOlexWcgOom88Z0Ytcywl6MVAQfomVWEtNMRiJvkBmCtzjyNwMEYUxRap1DsJ0vLNCvO fskLn8pj7+Z2QWJ9pEc+9cBhQH83CTyYeD7RlXcKUDEukYT6W1SgUqQ6HgMdYJ5/gcko= X-Received: by 2002:a05:6000:2485:b0:3b5:e2c9:fa05 with SMTP id ffacd0b85a97d-3b60e4d0290mr6272128f8f.18.1752823151319; Fri, 18 Jul 2025 00:19:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFVaHQWGhSNDe/SvaSTIIU3JswwI1o5VmpVPWXfPfRYZ43l/Q9U+Bu3DhdqKMwRMYxqDkTb6w== X-Received: by 2002:a05:6000:2485:b0:3b5:e2c9:fa05 with SMTP id ffacd0b85a97d-3b60e4d0290mr6272108f8f.18.1752823150832; Fri, 18 Jul 2025 00:19:10 -0700 (PDT) Received: from ?IPV6:2003:d8:2f43:8900:f364:1333:2a67:d49e? (p200300d82f438900f36413332a67d49e.dip0.t-ipconnect.de. [2003:d8:2f43:8900:f364:1333:2a67:d49e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b61ca2dfe0sm1018368f8f.36.2025.07.18.00.19.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Jul 2025 00:19:10 -0700 (PDT) Message-ID: Date: Fri, 18 Jul 2025 09:19:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/6] mm/huge_memory: move unrelated code out of __split_unmapped_folio() To: Zi Yan , Lorenzo Stoakes , linux-mm@kvack.org Cc: Andrew Morton , Dan Carpenter , Antonio Quartulli , Hugh Dickins , Kirill Shutemov , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Balbir Singh , Matthew Brost , linux-kernel@vger.kernel.org References: <20250718023000.4044406-1-ziy@nvidia.com> <20250718023000.4044406-2-ziy@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <20250718023000.4044406-2-ziy@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qcRqJPtihXJ4EqhV4N4FcCFyNsiaQMDHv0-ieMyatuo_1752823151 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E3B4D100004 X-Stat-Signature: i9uixf7qy6o6mjnjngppe9uy86ch5qzq X-HE-Tag: 1752823154-69086 X-HE-Meta: U2FsdGVkX1+MVfcChch9F6OafJwZQSWcWJeEQT5B/Zj/d4/wWfoVNXAOIcUjMlNsBIaatej4vXcyZjh2tL0+MR4q5p1F/ckCVk9ej5q3d44ZPzBsDuGWii7Amzhz3CQHpzwpc3ynul3NnJJYHBRsTz5ypZEoNbjNn9aQnwxvhscZdzBD9H6jevQ5ZrwFio/t1M3YZPqgciMtvxGdVXQ/ba20AEIlGPXFuBamg30Fz5QRd+zJTsnsMjQhhIztRHV3rNcE6n2vGiY3n0O80/x1UafvVDYnfPfle2B438F59kqAny8F6hvO59R/TD9bHLb1MX45invzCBsESA5cvcU6c5Bz38hrTDv02tiEi86G9sFAAE+pKR5eh3DE14Q0NNkOtEZjfRmoJJgZCGzPAQNFRJpcwFabCKQEkAhnWV85TJzMUC3Kemumwr0Bm7Kqofi8A90RJsPOmkFdFuwhu5Ca6EyphuHe3nTn1fxsTCQuNzuLtXUVu7kR8hqR+6Bk6pqkg9D3ocPWsOVnSO3Ik3IN+DjzrrZLPZu2WFHKbUd2QQDXeFL8Xl0/rKaH6YSS+pVbJzYbJDxhGQBm8Fhq4df8YUoRoNC0PXcDmvrLVv13uBIgIebrnh2dxlaeqrKksfXLYv+164/52D9xwdpyYotiiEO95SDROWnoPuED2E+PBiScXJyzx8F1V20uiEnWzUwfjjjrdNRChBBUrcVKtmz2aXfx3t+0TBxdN1//jbHWXW9vqudeHnpH8WT/mphFh766DMC7Vw3369hOBOeSEvKxDwoag5g/cL38CdrXftpDOO1vNb9x8fAu1yz6eTzFNOw01CKEBOvMLOc1kCyUH6pE2zNcq/uu02fqj+7Uh/lNWGtbeictGft/SoO4oPopNACQp8qWfocZcYcCg6y+SFWsH61pDs9/qMZV9VDQKHetOCEj07kcmZ2z/k54tURjInvw7WI1HsATbMTPh2qEQ05 tZx+ypb+ FJH+OwlShGrSYGyhRFbGMbMAtnfkPUUd7iCoBIpD8W1FBNi8LwImSQTdai3OsoCwk3/+DBYBtIJ/TKQOXGIU9cjKzHmP7HdLsR4oTupAtWpguP/PjwBSFuDKTwjGEhumrNentQjDZs+90S+zC57dmUQpZs8ke0doavSrVbycthOBirdNC9TO7UP1rpO8f8NBxhb5Slzlwut1puGr00A+UGCpuBWq0zmur+egI96Oy3PNlHMdT2oV659IWE4NjJdI6itH34AHoZNCWs4HoNjyEyEPN8TKHbVHuWlLxqCJdvls1kIYAtXZJRvDY1eWpr6q2uU8qrlxhFWIAlHb6EPLKnrC/8trrlMFIVzpeQQYd2pwsFj5Q8pd4o66x4QJ2FaYqynboaaeQx3G5NJ01+t54nL9A6rAMdZbKL8TUAOaKDj9aiVQHHHOVKQ1ui/UA4/WHWzbn9C3g/otFM5LBZv3YsORciwptEWaDMVONsSIs/Ii3F6hdWw1HEwx4pZLPi1CW28oRcw660f3+8nFoPAIGkbG8QUVQDh4F1NNu1tEu76ppfaRNPX80QXd3v+bMNTsEY80N/wsCfeIh/dhpEraCe5Dbkg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.07.25 04:29, Zi Yan wrote: > remap(), folio_ref_unfreeze(), lru_add_split_folio() are not relevant to > splitting unmapped folio operations. Move them out to __folio_split() so > that __split_unmapped_folio() only handles unmapped folio splits. This > makes __split_unmapped_folio() reusable. > > Remove the swapcache folio split check code before __split_unmapped_folio() > call, since it is already checked at the beginning of __folio_split() in > uniform_split_supported() and non_uniform_split_supported(). > > Along with the code move, there are some variable renames: > > 1. release is renamed to new_folio, > 2. origin_folio is now folio, since __folio_split() has folio pointing to > the original folio already. > > Signed-off-by: Zi Yan > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb