From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D8D9C0015E for ; Thu, 13 Jul 2023 14:41:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A890E900031; Thu, 13 Jul 2023 10:41:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A393290001C; Thu, 13 Jul 2023 10:41:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90134900031; Thu, 13 Jul 2023 10:41:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7C9A990001C for ; Thu, 13 Jul 2023 10:41:55 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 27BD1C02D6 for ; Thu, 13 Jul 2023 14:41:55 +0000 (UTC) X-FDA: 81006852990.17.D9923E3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id CA6944001B for ; Thu, 13 Jul 2023 14:41:52 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i6D3RXwF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689259312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x2R6dDDtWkBzm8BK7gNECoNNAz90QfecM3mxU2f2ZR0=; b=IImpdJkc36beVU4AsvD1y49jiqqIXCsxwxqvWfcFAb4ewoonMkJte+i1UOfnbzJDK1uC4y JW6+oDUjpNdOZ8kR5Zs/sbpl54HU4MAL8bESW1oObkmjwRBezfTqLtRUOUDtGvLpA8vjry q9hFAzGOjaHngOr5L00thKEUy7mjO4c= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i6D3RXwF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689259312; a=rsa-sha256; cv=none; b=5pS6tKswc2nNdM/UonEj7FA9Buhj/DK7sjFdpe4EG17c+S0mC0MhV/Doj3WgNHjZo0LuiJ S6uCi0FiPRDOQUIVzwWHE4+S/WB0yuHz+3AyCivRg68975hTKl+v94ZexnB46w2bxUJg6Q KNvsisgUexxSTHEJfNqW5zhVjnPtvXc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689259311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x2R6dDDtWkBzm8BK7gNECoNNAz90QfecM3mxU2f2ZR0=; b=i6D3RXwFO0cat1t13IrNjkgH28Gj6FzJUT4LlSJqsleESXR5EXvsBl4TosRRjUCOyRvTeu JVxO7bxPuYMot2IFLKTdDGb4KkIkATDlDzriMu/dOmag5ZWaWX1OfhmUJiJB59UN6C/VUP ZwnnhB0iuLVk7gmbxxaij4EArO1ViHg= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-138-W_QZ3yvjPiCdgSeYvDKxpg-1; Thu, 13 Jul 2023 10:41:50 -0400 X-MC-Unique: W_QZ3yvjPiCdgSeYvDKxpg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-30e3ee8a42eso559084f8f.1 for ; Thu, 13 Jul 2023 07:41:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689259309; x=1691851309; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=x2R6dDDtWkBzm8BK7gNECoNNAz90QfecM3mxU2f2ZR0=; b=FTN9vZm+WPUV8shtdrDaNUJLJSrFf6DsMIVfCMyJEgsifaYfTrYuWRgBb8o/wBTH47 zQU+pGfw0cxugtnzJPBbULOUnflLfNwrDaY0E5U/ror3+PTrdrIp+t3eKgI/S+1vO5f3 ju30R4zcakZFLkO0/bL6zxvG7ajx3PVrIgZ91sRLmF+WoiuBVd3LZVJAiOaDY1PwCOs7 NCRHig3kQsv7OzApVIsZRAoczS1rNnbFq8fqXCThatQ+s+BdcNqJBa1lNHHF8bwY8KQz zpXyQdwhERk79kKMyHBTRItKiZqDRL9eTt+7r4K+MDcJasIFu/CYYFSn0iShmh3jgt72 RtAQ== X-Gm-Message-State: ABy/qLYTgIyYneewg6XGWXwVXXrk+oq3rDxdFp2hweWZHAzXgZMyI7lf F9JVYWIKox3dfiTsENQSWyucj+J6YLARoYzg87tyU/TkMB46rMKDDVJA5qNsKr1m8KEs55sw1bk t/8TQimw7r8g= X-Received: by 2002:a5d:5944:0:b0:313:fce9:c568 with SMTP id e4-20020a5d5944000000b00313fce9c568mr1555691wri.31.1689259309465; Thu, 13 Jul 2023 07:41:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlF8Y9wJtjwsoykc35+sgxyZLim850yFkZVhcdkP6y60VpV1mMg23WlUd55g5Z0yevQoGHHrqg== X-Received: by 2002:a5d:5944:0:b0:313:fce9:c568 with SMTP id e4-20020a5d5944000000b00313fce9c568mr1555675wri.31.1689259309129; Thu, 13 Jul 2023 07:41:49 -0700 (PDT) Received: from ?IPV6:2003:cb:c717:6100:2da7:427e:49a5:e07? (p200300cbc71761002da7427e49a50e07.dip0.t-ipconnect.de. [2003:cb:c717:6100:2da7:427e:49a5:e07]) by smtp.gmail.com with ESMTPSA id d6-20020adfe846000000b0030fd03e3d25sm8165077wrn.75.2023.07.13.07.41.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jul 2023 07:41:48 -0700 (PDT) Message-ID: Date: Thu, 13 Jul 2023 16:41:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1 6/9] selftests/mm: va_high_addr_switch should skip unsupported arm64 configs To: Ryan Roberts , Andrew Morton , Shuah Khan , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Mark Brown , John Hubbard , Florent Revest , "Liam R. Howlett" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20230713135440.3651409-1-ryan.roberts@arm.com> <20230713135440.3651409-7-ryan.roberts@arm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230713135440.3651409-7-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CA6944001B X-Stat-Signature: 5gh4g547h1sgtb3k8uqfc5761jurn31z X-HE-Tag: 1689259312-704649 X-HE-Meta: U2FsdGVkX1/RqJQKjTXpcQc7U7uSMEQO0j2OhpIRHId9o/hVd2fMzTdBmp6dStb+vyjZfamE8ubyWJBsVvctVpPNMrxaDTSATWUv+UpMI3XMqSAN69xxu+rO7B9ZL4SzVJrIkm+73XfayVI4LPcBFeI0X7M71iyFIYFYMhPt2rwaxC4mbH7Q/Asg5O9ue8nPWdmA1Om5LBBZeM42MrTd03ddMFwPVdBANZSUR4fAmlQhwpYV/RkE+6RpU1dr+gZHrYyhNWJz3pXKcUneyQiWs0n/5K2Y0AwRAg9qjiYPcAPGnTLT30v2JaSoIymEy+Ic03U9af+jNsa4LylcW4NH3CZ/17lAPtdZqoWwx8kb+1XBmtfkPqD3fjDsmbkGeJPsonwsob87D+Kdm01YVuY4AORUnc+OQWdztC9yIQKuOlKyVmUCymxH0yuCR2FE50qM1FS5NNmemYR/anTvIhIv7wYX3IbU0KJIeH5icv7hZH2P4nYB2Dm+jM+oyIQRRfSwwqEdOD4dQLHMPteryDAz1m6aT3Z6D9vy8bGt+54I7KiZyQbj6P1dfl1qP7jJaNkNS8IKekC6HmNd5AilJd0jK4g2g8aBY0RKZ8csvhqDcSKpPOn8+ej3zoP+84+ROipCwjuKXn52GtKg0J+0qg7hQphGQNJkFOgwMWnLno+560YH5V0oOJUUvBz3zIM453NKEdNLZUCaYmTIYM5geAfDg6mK/N5ZWFso/+aivh7/2fZHY3s9OADALpYAPjapR1iJTu/5JRpoAfm0XAsXK5cq0ZIvCp35amIZXkPo/g6cYWd1BjjsaoytMtyZiGZrFSrH+3J2F1JlzcLsWyselQ4wciAYORv2AWNKdnDI/XSNmausCRH6O4f0ok3g/NSscPp5quIox/g4QCkGW4dSYL/rzN9XiOJkqX4Sag+bFtM/b/ffQaJpC3x57nUYQLlY6kkABpR6/83UDq2/Nh9MuAz b/NXW404 Nz7fYCvYInGlv4Lgb5/hj9mUvlP8jPXXbHydXTNdf+gYfrp1yqnnNDy/sIUxzF9V+LI4UjAVOABNNZz/Ce/3v+3dVt2vbUUHW2kUngssbLB+MvfEwCxanUvx1pKLHLKlnnoew4OmOCABbjJKZZOaIB6uhOu4IextfZeVQztz8PjJ1J34cLtrQ2/y6Yyzw1sP6HpxOghihxnFi0VqHUUtWC9AQK23O3Fd9qmTPTMvuSa2DJO8JdJz26egetuKjm4xkJL2sjsaOfu2h2MqNYeLy94JW5OZGFT2pjtN4CYsmGKuQbPwO7roRt3qYf6XOxBF3K8iC4TOmEdCwR3dXiscG/vcjd9XjEhjtc+Y9vy0XrQHqc8Ra/c1Uk+thRotzq2mI/7V5yd9uOyWN580jHzMFNUV+0GE3qQyQR99agO8tUgWk6w0bkY9Doah7m0+ZMHwqraHK0zazUqK5upWYg217H6W18a8hSrOQ+fQiRsw1TQTKeRMJ4ZuPEaZlIwPVgnyO6gc1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.07.23 15:54, Ryan Roberts wrote: > va_high_addr_switch has a mechanism to determine if the tests should be > run or skipped (supported_arch()). This currently returns > unconditionally true for arm64. However, va_high_addr_switch also > requires a large virtual address space for the tests to run, otherwise > they spuriously fail. > > Since arm64 can only support VA > 48 bits when the page size is 64K, > let's decide whether we should skip the test suite based on the page > size. This reduces noise when running on 4K and 16K kernels. > > Signed-off-by: Ryan Roberts > --- > tools/testing/selftests/mm/va_high_addr_switch.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/va_high_addr_switch.c b/tools/testing/selftests/mm/va_high_addr_switch.c > index 7cfaf4a74c57..4b6f62c69a9d 100644 > --- a/tools/testing/selftests/mm/va_high_addr_switch.c > +++ b/tools/testing/selftests/mm/va_high_addr_switch.c > @@ -292,7 +292,8 @@ static int supported_arch(void) > #elif defined(__x86_64__) > return 1; > #elif defined(__aarch64__) > - return 1; > + size_t page_size = getpagesize(); > + return page_size == PAGE_SIZE; return getpagesize() == PAGE_SIZE; ? Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb