From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CE69CD11C2 for ; Fri, 5 Apr 2024 07:36:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 221446B011A; Fri, 5 Apr 2024 03:36:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D16A6B011B; Fri, 5 Apr 2024 03:36:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04A546B011C; Fri, 5 Apr 2024 03:36:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DAAAA6B011A for ; Fri, 5 Apr 2024 03:36:41 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 958731410ED for ; Fri, 5 Apr 2024 07:36:40 +0000 (UTC) X-FDA: 81974670960.05.089BB9D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 540971C000D for ; Fri, 5 Apr 2024 07:36:38 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Bhkccrcb; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712302598; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2y8u7mwlp5ekwXbwQkfIoccQIC1fIHBDNEWQHYbjVLA=; b=UnhtdSw3Uj6TzYrm+jjNWK1HPCZg2L8k1qkGe3AgKh02P3c0GQYScJSiJ3+eA1v+oEu6fF 2raIswQ4d+Fc5+YF9XNo2bGTWa1/qzapXmwg46X01cTl5gWzxNIlSjajUw4WAL0ii8tm+/ ZHCpVRYk32si1Ef0jpasfweyaGUN39Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712302598; a=rsa-sha256; cv=none; b=aP8AgobfVsm3cjXyL6UeXd7pAKQNyiKuvAHH8yzdkwrqDxssEI0Fqfct38ib+uAwb+2abG 4JIQQfO6zLQjnff1vBsUX3FZH4PpezcsnqoLSy5a639ojNwFPvXJ5dFdaGKSS5+cX9NUJB KssxFGJgZZBY2d7VdjcFQzxG5suidDQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Bhkccrcb; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712302597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2y8u7mwlp5ekwXbwQkfIoccQIC1fIHBDNEWQHYbjVLA=; b=Bhkccrcb+1fVDXNHXT9HtTUnBH08YYNKFPZD2ovZs0lv4PcCeLJdyowuNnY3EphKBUJj4R YinqAS7ESs+v/NWyN9LwyECrMsNATFjWWG9sr853sqV3cMNUl8eSRLSiCcUU4q4NUEJxVs jgJbOZ97W5BSi4yxCkaeNPCZ8Yk6HeM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-319-Za4Jw5_oPGOHfIQQ4ARIsg-1; Fri, 05 Apr 2024 03:36:36 -0400 X-MC-Unique: Za4Jw5_oPGOHfIQQ4ARIsg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4162ebc5a88so2410935e9.1 for ; Fri, 05 Apr 2024 00:36:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712302595; x=1712907395; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=2y8u7mwlp5ekwXbwQkfIoccQIC1fIHBDNEWQHYbjVLA=; b=cF/VIHyFcySZsghLynlCFDnZUott/uzQ9bVJ2VTUCyYPPSTjKdoCzhD15u8ubvCcpH Dwt/zHL9ovpn3Tf/3BkZZYP6acO41JDnAeWWdJk3sMu+lrXDaCf3nGmjko92GcZ/v7w8 OINR4e62z9so+xaaWQ39HvDyHDkHIkZhjADlfsqFHMDKnjmhA6P4j0kTqlrVo/dN1Xko o/TF7udDpMMMp5LD2qf0ReAeDvXM7vfgeVmq633S/7+tr57b305kl5NvOXWkG9XTf6rE vGtgDv6o1OgXJtyW1WLPaouNxZckCYGz0fhn7IjXh2iNw/2EYpxayOro9m2xh58Eg3+e N77A== X-Forwarded-Encrypted: i=1; AJvYcCXXgr/SVme9drbIKMVagY7MciASxwbXpaouRqWoVPrerqnNgTYXlTmHfdqV9G2yNE+C9bc1Cqq26P6HSPIKx1I/lcQ= X-Gm-Message-State: AOJu0Yyl2INomLXSX1x+pBB/eqHncMhgONzfQ5v8oY8AssIFE45a4dUU jYOwfRzw2PE9xMB0Km/kWyMfJx+3XQcGfuxyoFtVftHjgehOLhyNDytW+NZsFjhVh9iRHIt3Ipz r+dCCJVNqgxc8sbWIKYbeUfbXrbDOBtfkZZ3PqLsp4tggRsMa X-Received: by 2002:adf:b1da:0:b0:342:61ee:bee1 with SMTP id r26-20020adfb1da000000b0034261eebee1mr479559wra.23.1712302595109; Fri, 05 Apr 2024 00:36:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IENYFqCOCwGuyH+nRGbGsEh1ADtlTFcTr7s+N1MqEpwS2Ttls8PELtj6JN6/5MjUtUw0p3K9w== X-Received: by 2002:adf:b1da:0:b0:342:61ee:bee1 with SMTP id r26-20020adfb1da000000b0034261eebee1mr479546wra.23.1712302594695; Fri, 05 Apr 2024 00:36:34 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:5500:e1f8:a310:8fa3:4ec1? (p200300cbc74b5500e1f8a3108fa34ec1.dip0.t-ipconnect.de. [2003:cb:c74b:5500:e1f8:a310:8fa3:4ec1]) by smtp.gmail.com with ESMTPSA id t20-20020a0560001a5400b003434c6d9916sm1313388wry.110.2024.04.05.00.36.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 00:36:34 -0700 (PDT) Message-ID: Date: Fri, 5 Apr 2024 09:36:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 08/14] mm/ksm: Convert chain series funcs to use folio To: alexs@kernel.org, Matthew Wilcox , Andrea Arcangeli , Izik Eidus , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ryncsn@gmail.com Cc: Hugh Dickins , Chris Wright References: <20240325124904.398913-1-alexs@kernel.org> <20240325124904.398913-9-alexs@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240325124904.398913-9-alexs@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 540971C000D X-Rspam-User: X-Stat-Signature: fxsp7xazyw98k646w8nozraza8kkwpn9 X-Rspamd-Server: rspam03 X-HE-Tag: 1712302598-950414 X-HE-Meta: U2FsdGVkX1/64CVbA8uXDFFWmdRfCAMoDqkXVZUmB16fWQz8gOl9ybvBoAr7/pWQUynd7MnrYVhH9KNbOgDwKxVkD+hn2XfwfcVZwt0fFgpK1ZZlI8Gyn59FyYmdkuQM6xFFt71p1avoEkPw/jxszR1j2baeYsu3ohqrHPJhN28NzP6Yv077V/tGU/TzJNLOHSfObyhyQsWE+HDAFso3ncVH4CxSylk/95+esun/A6bLaoyvfq1VhALSCoPioDY3iYcJTAuSrt82PdJg4+sGRPL6yCv8HuEOjAmIaCXRrGBg/Qd/UiFlfL5OGo0MVoXcvSrF5EcX3hGwOu6bUx+f9p/wmju4CVHmqESPl1o7285BI9antvMf5sr7XZpiUNkt1vA0k7sNkHkn4iFx4C3wR/IhmvWat7xZdnyii7FiGR1AfUkTnFqnYeCYP+cTb0BJzLJ6b0ZbYHVW/CoDJwV3cuk5tZmUWRqoPHM1KVCElX/RwUwa9LygI5MAvQxYiKl+B/hkzjbffZ3WTOR8hcNdtFggY6Qz76gQrDfHqwbOYHzCVEyv1FPL2yCFLs4gJHpAGPjwiwPxBc0kG3bWjy57CN5v5vqXZdf+B+ITVjK0SrzEjEI1rYTsI60l2ZbQnxOGNMZ5xOCdP8nwZX0oIpPvAIywGHPjEh2BNW5rc6b4Q0iKDdA0cJlm9we6TZmnnK8hepz0q29GPZXRBhe0Jq4C1R1R/DCZa1Vu1K6TMU05SpAXsLAy4AdbdeMg7R+3HGXxRJJVGKrPmTCVDpsIUeHLpXe7v/ArR3x4g8qHlr8G1QEKCcevL9rb8E9EVR3F9W7RzJaSQun1NWXe0+wsILKCn+kFgKrth7nYidZxgJuEET5aC4Ko/qnUFDXGJG8VAyp5HjNGxp305j0V3FpHvNdvX8ZLgT9OZM7fFOMcutiWIimtLuPJFYVnhX8DhrvakjKdWACFzUy7r0rX647XLej 7plkGPSj y41ZqYqTUXHTz/Zz7bRTMsEC5nYicaoyffPAapszlnPvIeA0JrdeHc2yoV9TH/jRM5RjpXxigHzhhyqa6NLuG8tZbkhL27eiTItp5DgluhTcwo9RDqaD75s9XIHslRPlaG1uZTZx6HjEnUEBIk6Ro1fpn0sJwrxenuYUJ+zFDZAORGvAwTnXOx6rvy2tbmIlXeoVLyvLGtG0GRM9/ygLF4D9m9rfi9kc3LsD8SH7us+IhpT5Bw29MtdXMa+Nf/K6KUTk2XLIQi546Yufw20pbKkR8LajEseWv0F/IDLgNjVdYafERwhjEPKbJHLW+sl9tlK2P4uvv4NCxUCO210FnN9Alpzyjik5MnJGlm6MInuAFRxqhoAVAxZnj94ad+u9N3dwE6kmtLw7eEAYpl5qbNamuk6fOYmHI4NQNwmzT2HjyBu8PLlEdlhLzbkfVG2sBEOc91y6kld/gpj0QdyVXaB+YHVrX1EH8aONrITvd1t4A4CIWzF8hAgzS/jwLgHIoQ24tX8l/gRh5K3ju83Du3u1hZq3LDDU3TVVojAN3PKeXC0c5QApa21VfKYabb3QX/SNZuCTRQsKmdGuvQXyA3oHEnce0feg2KgxoLd831wYET9JFMnHufhZ6qd9OJlknKgsRL9nVHsbauphttxbdynM68oU8F84Pu2NJbcENDmQLjkZVqXFuaWFX2xR3t8W2VZc6OMTbg1MOksC/7azfw3LKg/scBq9irYUvlQSNSvraJ7g6mg/WCaw1Ivyj7sma2Q0BP8pTLi/ewfCpFeBgqLkymar+g+xtzYHR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.03.24 13:48, alexs@kernel.org wrote: > From: "Alex Shi (tencent)" > > In ksm stable tree all page are single, let's convert them to use folios. > Change return type to void is ugly, but for a series funcs, it's still a > bit simpler than adding new funcs. And they will be changed to 'struct > folio' soon. > > Signed-off-by: Alex Shi (tencent) > Cc: Izik Eidus > Cc: Matthew Wilcox > Cc: Andrea Arcangeli > Cc: Hugh Dickins > Cc: Chris Wright > --- Why not simply squash 8,9,10 and avoid this completely? There are not that many relevant calls that need conversion. -- Cheers, David / dhildenb