From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F7F1C3DA4B for ; Tue, 16 Jul 2024 01:10:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 854F56B007B; Mon, 15 Jul 2024 21:10:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 803AC6B0083; Mon, 15 Jul 2024 21:10:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F2986B0085; Mon, 15 Jul 2024 21:10:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5122E6B007B for ; Mon, 15 Jul 2024 21:10:28 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E3E84140249 for ; Tue, 16 Jul 2024 01:10:27 +0000 (UTC) X-FDA: 82343835294.29.9BD3D04 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by imf04.hostedemail.com (Postfix) with ESMTP id 90FDC40006 for ; Tue, 16 Jul 2024 01:10:24 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=nqEHI2vk; spf=pass (imf04.hostedemail.com: domain of joseph.qi@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=joseph.qi@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721092208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=podFBawq3qUWxC6GJyKeZzxgJkUfZhMQQKmWCfiivqg=; b=yMAh8f2ZqGBm1V3/J1lPqc2DIAF/OO9znEbmtXsYfmNlMnHwAUEB3pYgvuWDkPTFQ6VJ3D ZuCB/zXTXOrvc3eReqchEItEBX4rNrywuaDw0AIumhpBrOrwWBaUHlRIbJCbFg1XJeipGm CcKcwxuM385f+ej/OnsaPGJ0+4PGIa4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=nqEHI2vk; spf=pass (imf04.hostedemail.com: domain of joseph.qi@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=joseph.qi@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721092208; a=rsa-sha256; cv=none; b=TBobNxIlew5PaBqb5T0+h9ZvdDOPq57yUYKyI93UBicVQ3gwYNTBB1eg7X2Q2sBB8dfGHD 8piSxmpitF+8IY2g+1hn1NEULEGCrhndjVebgnozBc/Yw69Oeam52msa6y/xZmKH+4u6Pr BVd7qIu7b2wgyid2Y3rr8Rzzo9OiHZg= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1721092220; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=podFBawq3qUWxC6GJyKeZzxgJkUfZhMQQKmWCfiivqg=; b=nqEHI2vkVBuYAvbxa3AzffFCgL7kfHvH8JiuCfz3wSwkTMaJyPsN+GByvpEa7792I47WF7hKgwQLiParuIwAAxwPv7cbt+nb7HKY+G9COnZhiSmwrFRUKVl09BsPH33qmrThHXUMlagDtKBkY2IMvyqkvUPbXEb3dWOqF6kA/RI= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R301e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033032014031;MF=joseph.qi@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0WAfKy4l_1721092218; Received: from 30.221.128.129(mailfrom:joseph.qi@linux.alibaba.com fp:SMTPD_---0WAfKy4l_1721092218) by smtp.aliyun-inc.com; Tue, 16 Jul 2024 09:10:19 +0800 Message-ID: Date: Tue, 16 Jul 2024 09:10:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] quota: avoid missing put_quota_format when DQUOT_SUSPENDED is passed To: Kemeng Shi , jack@suse.com Cc: mark@fasheh.com, jlbec@evilplan.org, hughd@google.com, akpm@linux-foundation.org, ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240715130534.2112678-1-shikemeng@huaweicloud.com> <20240715130534.2112678-2-shikemeng@huaweicloud.com> Content-Language: en-US From: Joseph Qi In-Reply-To: <20240715130534.2112678-2-shikemeng@huaweicloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 90FDC40006 X-Stat-Signature: rwnejw8d3ndywkg16rd5fcmu4ymz6sjt X-HE-Tag: 1721092224-30296 X-HE-Meta: U2FsdGVkX18ERZNgLgdeL47tvr3oGIt6B/FTsIu7LuUF5pIGGkMWjdV3GsroMl3VyO74T9IzIXE13FrCB2rcXDKJFEQILk3gHtc1GoBDo8imFkTQYrKoHQrj8AMl/QBsVqUdYFK1sNMUEt5d04iHW0x3AaNQlbTd06taoluiOy1voL3ZQjqZZjOYUCd/tJYXWIzgmDBYvrp56RCw5cesqxGCQWd4t9tWsWxXBqX3sjMinPGq42wjgEdq1c4Nx+pwxH1Rz8gdsI3HCKAbn367lKhEpKf/V171WjfrQyhN8It4PS7O1t2Exw6SJJiT5bPfFkqi7fnepLIu9IaNtOsynVcyAp90zRxvUeRU0DWm7Kgz/NKArvTpUsU6MFm42LmpnXzk3wE9ITYTOfJAZqkZwaEqcRBRvMRfMblbHJ5C7kD8Yt1UN8Rp3wWbLy7laCm1RYtJcGAGDxD/UOP1mfeAyiymfTpO6LkZJCQoZfpZtDET5vqCM9AaeTwf38UM5fmlntcAD3NTQIO+0h+DMiszMehcqX8bSH3rdsnQdPgcnC12E+ic0Hs9C0xSLJNWSgN/6+1Gt7CXDSbKaqq9D1SupkKwQsWZSGUPw31dFK+QV0igIYwbpa02ll29VNys2PlH0YMUn0SKkgCLe83+udBmHkIDwV52ZPhofSvvuA+xnEzeV8T5d+rmjo3GXrXN9Om9kgtHxPaFeUnwhodyh2DsmNFvXLTctqQraORrmmt6+JJdop1sIZRSStxXsHeU73PP5TbRi4GFWIALD409kGYE5CmP68hM267ZooBEBBh/OVZmwCKBJcjm7Gozk4qp9Y6/GD0jIpX7Vk7TrE4hRtBPORWcAvzO2khHXGrzoDIjmUQlo4J0gvvbuolw74v4DYbV8wPWhaq2D+9bivR+DA+VkRt8g2AzgTCNkaQFg/xPmG+Y7LdRT93rNRVZGaY3RsUS9TcnXCadw6LG2Ed7I/7 YWzVF+7w tGEnFosyHXUTUk4tEfyUp6dYqMlyKey8h7V28K5rssWWa0RrsRYI+G4YfQmu4GviTEAxxYXWO7HgV1lOTuA2PYmzkNyNBWH+LwAXWZ28KGyhlmKTMOaM3AK+PSOTHpQMo56UaONRlaIZdEWFIfRL2D8jiaxKHASL3YIbgUxF4/WK3PLVuYSo1UMiDj/6M2DaSOA312a3vCkWezxIQmBcAssYqTCJ0iIef7q9bbkn80668V1vt2U1/ouYEWdNvakzwbWADHN6bWBM9pZcXLEwu/YftBBiSzSiVWQjaakr4G61vCsfW4zuOC4XF+l7ksXR98OOozIUuUr3qacuq0T6oa6D8anqSfJyig/fG5GzXv/daBBRpwYDGsdYUHcSuEYfERmNtBhvGEjq2an4Cs+lKUec+wj7ukXaqnAAJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/15/24 9:05 PM, Kemeng Shi wrote: > Avoid missing put_quota_format when DQUOT_SUSPENDED is passed to > dquot_load_quota_sb. > It seems worth a 'Fixes' tag: Fixes: d44c57663723 ("quota: Remove BUG_ON in dquot_load_quota_sb()") Other looks good to me. So with the above addressed, feel free to add: Reviewed-by: Joseph Qi > Signed-off-by: Kemeng Shi > --- > fs/quota/dquot.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c > index 627eb2f72ef3..23fcf9e9d6c5 100644 > --- a/fs/quota/dquot.c > +++ b/fs/quota/dquot.c > @@ -2408,7 +2408,7 @@ static int vfs_setup_quota_inode(struct inode *inode, int type) > int dquot_load_quota_sb(struct super_block *sb, int type, int format_id, > unsigned int flags) > { > - struct quota_format_type *fmt = find_quota_format(format_id); > + struct quota_format_type *fmt; > struct quota_info *dqopt = sb_dqopt(sb); > int error; > > @@ -2418,6 +2418,7 @@ int dquot_load_quota_sb(struct super_block *sb, int type, int format_id, > if (WARN_ON_ONCE(flags & DQUOT_SUSPENDED)) > return -EINVAL; > > + fmt = find_quota_format(format_id); > if (!fmt) > return -ESRCH; > if (!sb->dq_op || !sb->s_qcop ||