From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9015BC636CC for ; Thu, 16 Feb 2023 11:03:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAD8E6B0073; Thu, 16 Feb 2023 06:03:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D5CE86B0074; Thu, 16 Feb 2023 06:03:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4BEF6B0078; Thu, 16 Feb 2023 06:03:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B4EEF6B0073 for ; Thu, 16 Feb 2023 06:03:43 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8ADC61C6226 for ; Thu, 16 Feb 2023 11:03:43 +0000 (UTC) X-FDA: 80472869526.13.38881C7 Received: from out199-14.us.a.mail.aliyun.com (out199-14.us.a.mail.aliyun.com [47.90.199.14]) by imf29.hostedemail.com (Postfix) with ESMTP id D0FC6120005 for ; Thu, 16 Feb 2023 11:03:39 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf29.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 47.90.199.14 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676545421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Rn+cXPhag3PRX4oPS8x4m1CBXQXknx8PPOabQLAuxbU=; b=YNBU1c39f1gwTkYJYXGwXgWMD7T029q0RRuLxiAZSBRy3slcyTWhzrLRoA5pAsuU2FXuZB 4w1rN5EK9ziYmdL9ta7oVqnK/Ya9i1V2f9yeiEJze2rOA6x15q2AFaFOx/mQTZv3avV+5T ZTuqg0U612C1ijFA4MsZMEvujudL8aE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf29.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 47.90.199.14 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676545421; a=rsa-sha256; cv=none; b=FrSt0JsMehwwRf5Y1UInm9X0xOBnmFZYrerefve4res8YV/dTzkKzny82NTAAgtZDTmLO8 JmgIZ0gsZf7qTOZJEZLreYp2aRgnna8tUyMuAbkF6YtaUNGR+c8O7CXUKQuj8EsBFNIvnB t/DJDItTSykZ1RkEw9VjebRf6ETfn5M= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VboRNRC_1676544813; Received: from 30.97.48.85(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VboRNRC_1676544813) by smtp.aliyun-inc.com; Thu, 16 Feb 2023 18:53:34 +0800 Message-ID: Date: Thu, 16 Feb 2023 18:53:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2 1/2] mm/memory_hotplug: return nothing from do_migrate_range() To: SeongJae Park , Andrew Morton Cc: David Hildenbrand , Oscar Salvador , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230215230300.61125-1-sj@kernel.org> <20230215230300.61125-2-sj@kernel.org> From: Baolin Wang In-Reply-To: <20230215230300.61125-2-sj@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D0FC6120005 X-Stat-Signature: h1wuamix59bxbas5y93tdt3kifixmar8 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1676545419-673375 X-HE-Meta: U2FsdGVkX1/1YBPDtbhyZGq3pJnljqsz8Z3kgLYAwFN5lgFiuWTBZLNCt65dx19Dah5boEUXoZyqzLs+dSoHrvopcJsfrwU6ymblgN6hBj2h0FyVCQUH9ICpkHNDAmbg+vPYUB5v+eWPQVWdZAO4Ic84ObN9SQL3LJHJzCCE7gQCgCs+BHqgw17ANRdjlsctN2pjLINGULv0djqTPyVJZvFJ1fuI0ekuJpDwv8KzxOISy5SlSOIkwiQAy9hIcj9+AxI1YqA2Wo/IEn5IW74IqygTPEViUSB/QVWw73JDGMqNw8X5pagJWIRFRfxLfc8uOEl38vQMZwo3WjmYDRDISJ6L5+0W+LQYhIKBzhLIX5uOKxzYP19DnAPMPvZnhhE289LBtwBPJULLpxzpxzVR0Z8GIBCpHt/b8pw7k0QuLGBgxsI6kiSlM6fivZk3o/tmKHph5MgaB0D2co/yp4+UEIN9cxxKn1D3WOB7hYVXqgLTtfFDhly55jbM8+unXjEkhzFUJZiHivoNI5i497djGd2C3Cw+oW9MIMoTWq8AlDlS9y4ZcfOc/Y9aQmIvgkv84ZwqT9qxpcegparr0efHTwiOSZ9jXZcmzX4iTNujeb0WVGG7oK0UMssdNGHSQ+2HiOnFWsu78vgmscUO2zUznAHMMZLWH6NCbJMYBf+wTxyJpO1DuEFgj6pq0+aerzCTNrRzBih8CZ4Xvm/S91w1cXnyT4lCiwW3GttIglvm3Dk+SwqpW/JP9J5pqVl7HaQ+AESgSRCfei1/wrGHrsp7EwZ0xQAk1w/Fq7b0YTONqYXK4xz1UbCE7fSWlsjf6WfNNmGpbz7TI49TEght7wQWnLzjTJO6uA8aZ4s6pNEITxbIyynmLFN3EFufZrd05XWMlsyoWLgxH1kb0seRAYqu/QXRRcFbef1WcFRxpwnu+RqNEEivm+dJbT+/jv1wHZf/1iw7kTSU6G6WQwHquk3 uH23lLn2 GSJReegH3UsxzLqq552vnJ49xWYvmgOKCoKi7M/8Hfh9PO10qB2OirB7hVS8uOFw3MHiYlMOnWv3U58mEVAFLEHSt91Mkh5s5VhCzvefGrc8UlzLgAHHYt00xxcmjNyRBFSRVQ43DHF9DSxGvjc09nU++Fp0QhHLH2A6qIxmKuapAPKU2W0lWzUFDB/uek4zhBvwrtIpWv+Af+3IKXOGe1UyvgLaOI1jC/Mv+JpBZZfIMBOb8QRayMegXj5yTgJr/YaOb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/16/2023 7:02 AM, SeongJae Park wrote: > Return value mechanism of do_migrate_range() is not very simple, while > no caller of the function checks the return value. Make the function > return nothing to be more simple. > > Suggested-by: David Hildenbrand > Signed-off-by: SeongJae Park > --- > mm/memory_hotplug.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index bcb0dc41c2f2..6c615ba1a5c7 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1620,8 +1620,7 @@ static int scan_movable_pages(unsigned long start, unsigned long end, > return 0; > } > > -static int > -do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > +static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > { > unsigned long pfn; > struct page *page, *head; > @@ -1721,8 +1720,6 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > putback_movable_pages(&source); > } > } > - > - return ret; Nit: while we are at it, can we also remove the "TODO" comment in offline_pages()? ret = scan_movable_pages(pfn, end_pfn, &pfn); if (!ret) { /* * TODO: fatal migration failures should bail * out */ do_migrate_range(pfn, end_pfn); } With David's comments: Reviewed-by: Baolin Wang