From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87CB9CD4F30 for ; Fri, 22 Sep 2023 07:42:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11BF56B0293; Fri, 22 Sep 2023 03:42:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F1C86B0295; Fri, 22 Sep 2023 03:42:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F224A6B0296; Fri, 22 Sep 2023 03:42:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E41CF6B0293 for ; Fri, 22 Sep 2023 03:42:09 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B281912072B for ; Fri, 22 Sep 2023 07:42:09 +0000 (UTC) X-FDA: 81263439978.18.5BF8DE5 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf02.hostedemail.com (Postfix) with ESMTP id 8A2D280018 for ; Fri, 22 Sep 2023 07:42:07 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf02.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695368528; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XA8kEYgJ2K4jD1JlckG561uQu9dYmTMo66sXrHxN2io=; b=0bLJPYOAG0qSglyPZM2UzhDZ7F1QDxcthoarHdJZQXKcU8t2lRnAfGPZavv0LGIm8J8Na7 1v4VwjSDgKnrIaeCkR0FVr53DWE6zfFnsSMFexOMe1rVUh3zGTPQD2HW55FfoKmYQJBi5K 3U4BLl1Ynh/xntZWnnbRRTZFHAPCK2E= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf02.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695368528; a=rsa-sha256; cv=none; b=2dK0JtGoXi+C8qXSKmd30iZDpak0dlHFnGesvMIQFbyMekfaERk6uE0gmYGWXQltQuIWoN CwZHjiE86zGcqvCsQJDj88qEKNbzeEvUM8r9reRPsPDKT5KvuSkplPK6SZkjJRlU7wwmxT gHRin6ECq10Q5k877/Qy16R08Lq2NKI= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1CC2DDA7; Fri, 22 Sep 2023 00:42:43 -0700 (PDT) Received: from [10.57.65.11] (unknown [10.57.65.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F3AA23F5A1; Fri, 22 Sep 2023 00:41:54 -0700 (PDT) Message-ID: Date: Fri, 22 Sep 2023 08:41:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/8] Fix set_huge_pte_at() panic on arm64 Content-Language: en-GB To: Catalin Marinas Cc: Andrew Morton , Will Deacon , "James E.J. Bottomley" , Helge Deller , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , "David S. Miller" , Arnd Bergmann , Mike Kravetz , Muchun Song , SeongJae Park , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Anshuman Khandual , Peter Xu , Axel Rasmussen , Qi Zheng , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, Greg Kroah-Hartman References: <20230921162007.1630149-1-ryan.roberts@arm.com> <20230921093026.230b2991be551093e397f462@linux-foundation.org> <7c5c2c00-d657-44fd-b478-743b43c57e8a@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8A2D280018 X-Stat-Signature: w4wx4smtyqasu6wyzdinmmb4ob6m3myu X-HE-Tag: 1695368527-312178 X-HE-Meta: U2FsdGVkX1862hu/XxDZyEeclnPADG2+rXlKXaXSyijv/IllN6kEyc/Z71PlkamHSZtlEat9QI44ZFpZLoYSMRg6E9yOBWu61aFDxiVAD13UJAEEe81UEEdM8Zm7eWEW3totMKEVp62og5WRInuv3maSkFeQT2oqI5VC2FezX/N6DnjCnJIlwffKArWBM81iiWuac41yvCm9jG8SprO0ig/tc70l5pD6O/2qESPlT9Uk2bNw11Myukk2Bo0CVFCAn1oKO163ShQB7RnEFx6MUCLqkt/YEJzSftEQgC/JlJsxCHuPq469BgymEGPx6RHUglQA8MAxylLvCGX7M2WrYQArPK3pt6yiL7hsidrv9iEXWHRkNoC752PH63rS/ad1TlBQI58oi7kK8rkCBRQRnLfWxUBPXKfEUTYHRv5JR22+gRiHXOG3g1/Jc8g5r3p8qwtzIrS/tLE2ug/SNup9uwDe+apPJKZmo8fEVbtWTmFd1U8+KXx/dbFWlU14l1hkWlfPfv5gHmyUAbttSXbzaxdbQIp6nAmTa6AMW694djEky/WPDb3bpef1fuVRwHfMBY1SI4FgGsE1X4tVpRkYLncYoK+TmAvYbSTVv3Cz07icwqL1MJVW1VOXU6kDKo/0ASnSqLrncrA92uAopsYU6eoa7IeqgDhAxe0T1s0G7393DOxuaIjo3fq7z8yR39qQgrW1VkUP+oMA/66iXXUUga7y7EV1vjzaRSWKYkLoQsa0rVY7cgs4Y81VT9J9FjaYq+ZGvq0ky1WtziMIeeN0vHTDuNz8M85JXrMXLe5epn7Jrk4J/T8hnaxAqp485b05l5yJtUgMHxySvpQlWNOiwesIY4UZv5nFeGIFPPgNZnTzT+a+0AMtelB8/3RFcIYPCgLLmzIAr/oxL0xch7PFh7Wy5jY15oNm2m4EIcO74jeyKCKLFizedyySw4vbZz/dEDxIsf4J5kcvHQFQ9nh /hiH2ywZ SBI6hdwMJbPuvDaB7sh/wYG0/g0T10BQdqSPp2KyQSMOKU1r5CU3RVx9qx662TYXVctwcMZtipF5xlNKYrt9pJPYBxGpolsonPSgqE22jdvcMY6Tb4sMJN2LYli3BhmNwBriciaa2RhbW/AwXOIrfpuuyl/4pa0CdgfyyqcjB39uC9gg8uDBjC1XQEbOs5PGqeoBu+O80+YNEOGbYVycZyOgvRh54fhTFQjXytRySekIBnzsvqLPfApxOpZT1NyasZ7BD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21/09/2023 18:38, Catalin Marinas wrote: > On Thu, Sep 21, 2023 at 05:35:54PM +0100, Ryan Roberts wrote: >> On 21/09/2023 17:30, Andrew Morton wrote: >>> On Thu, 21 Sep 2023 17:19:59 +0100 Ryan Roberts wrote: >>>> Ryan Roberts (8): >>>> parisc: hugetlb: Convert set_huge_pte_at() to take vma >>>> powerpc: hugetlb: Convert set_huge_pte_at() to take vma >>>> riscv: hugetlb: Convert set_huge_pte_at() to take vma >>>> s390: hugetlb: Convert set_huge_pte_at() to take vma >>>> sparc: hugetlb: Convert set_huge_pte_at() to take vma >>>> mm: hugetlb: Convert set_huge_pte_at() to take vma >>>> arm64: hugetlb: Convert set_huge_pte_at() to take vma >>>> arm64: hugetlb: Fix set_huge_pte_at() to work with all swap entries >>>> >>>> arch/arm64/include/asm/hugetlb.h | 2 +- >>>> arch/arm64/mm/hugetlbpage.c | 22 ++++---------- >>>> arch/parisc/include/asm/hugetlb.h | 2 +- >>>> arch/parisc/mm/hugetlbpage.c | 4 +-- >>>> .../include/asm/nohash/32/hugetlb-8xx.h | 3 +- >>>> arch/powerpc/mm/book3s64/hugetlbpage.c | 2 +- >>>> arch/powerpc/mm/book3s64/radix_hugetlbpage.c | 2 +- >>>> arch/powerpc/mm/nohash/8xx.c | 2 +- >>>> arch/powerpc/mm/pgtable.c | 7 ++++- >>>> arch/riscv/include/asm/hugetlb.h | 2 +- >>>> arch/riscv/mm/hugetlbpage.c | 3 +- >>>> arch/s390/include/asm/hugetlb.h | 8 +++-- >>>> arch/s390/mm/hugetlbpage.c | 8 ++++- >>>> arch/sparc/include/asm/hugetlb.h | 8 +++-- >>>> arch/sparc/mm/hugetlbpage.c | 8 ++++- >>>> include/asm-generic/hugetlb.h | 6 ++-- >>>> include/linux/hugetlb.h | 6 ++-- >>>> mm/damon/vaddr.c | 2 +- >>>> mm/hugetlb.c | 30 +++++++++---------- >>>> mm/migrate.c | 2 +- >>>> mm/rmap.c | 10 +++---- >>>> mm/vmalloc.c | 5 +++- >>>> 22 files changed, 80 insertions(+), 64 deletions(-) >>> >>> Looks scary but it's actually a fairly modest patchset. It could >>> easily be all rolled into a single patch for ease of backporting. >>> Maybe Greg has an opinion? >> >> Yes, I thought about doing that; or perhaps 2 patches - one for the interface >> change across all arches and core code, and one for the actual bug fix? > > I think this would make more sense, especially if we want to backport > it. The first patch would have no functional change, only an interface > change, followed by the arm64 fix. OK I'll do it like this for v2. >