From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C03DCC636CC for ; Mon, 13 Feb 2023 22:43:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A1E46B0072; Mon, 13 Feb 2023 17:43:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 25223280002; Mon, 13 Feb 2023 17:43:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11A12280001; Mon, 13 Feb 2023 17:43:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 034196B0072 for ; Mon, 13 Feb 2023 17:43:19 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CEDCE16097F for ; Mon, 13 Feb 2023 22:43:18 +0000 (UTC) X-FDA: 80463746076.27.330C6F3 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf29.hostedemail.com (Postfix) with ESMTP id 947C0120011 for ; Mon, 13 Feb 2023 22:43:16 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JfkW5m6k; spf=pass (imf29.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676328196; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+JOmWBAFP8eftiZBeq9pTOo47oeh7BKjQX9CxzTFJ7s=; b=pQ9+riwfoHu4PivKxP9PTQ4rloC8Eg9CmFQ5F+pg5Xs3BaQ6bCCfyGpYwlCOFwBsnmTipQ JH9QZicsUBnhUWQM+yAd8CSR5ZcF8r4po84VS0wqVvQx1zsSIO8CGqLnhn1s/EscQkYZDX 8eL1vNWbeTwxvH5tNBkUSdbI9VGt1yg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JfkW5m6k; spf=pass (imf29.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676328196; a=rsa-sha256; cv=none; b=xnRlxv55GKbgEohMya2yK0Gj8Y1uly5gSkIt1GszjiIX0a3ZkVly09VwygBofNWh9DNHB4 /yO4g2XdmKH/37m8woU20qaY+8nK38Dxxl75Mh/JOc7Q8NKxfnDuOkIBYRV1HW6NdfVO9Q PrH0tI1mK/E3M03PkSGSvlRVrQI/a4o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676328196; x=1707864196; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=+1Sbf2PVMPRSLBzz7cIUPSlDGOlIYXOpOZ7P5hGNOWg=; b=JfkW5m6kzaHT16uGK9U0HWSnLxbrNJsvjf7RCtB6lE6nzpRdcm0VXMyC 1dz0rQIxmOt6FjCvbD2f4W0WO7cyaNAizBVfrrl0maDBqF0/g5Yd6Zzld 4zj+ZpdbaLIIZH6JnEb9a1c3GoXhWPLvYjIv05iFljbmiqdUtQ5iVT0w5 UTlLmvgK2C+MyzIHUZwt2aQ/IYoV2IN9fPDHrB6Wt0nPh5oZHv6HcrZPD ir5M8iVkBxV1jnEBH4o9ZNB6UEs65ukAWVosyNz5EQip4fvdwuAGDmh4M eYVeIx0NCnM6eKWoj9Q8ebjGi5/5oFGaoMgivzTuFdQm++hXq/GbG8uuK Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10620"; a="395633985" X-IronPort-AV: E=Sophos;i="5.97,294,1669104000"; d="scan'208";a="395633985" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2023 14:43:14 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10620"; a="671002184" X-IronPort-AV: E=Sophos;i="5.97,294,1669104000"; d="scan'208";a="671002184" Received: from mlswanso-mobl.amr.corp.intel.com (HELO [10.251.26.232]) ([10.251.26.232]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2023 14:43:12 -0800 Message-ID: Date: Mon, 13 Feb 2023 14:43:12 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v9 07/18] x86/virt/tdx: Do TDX module per-cpu initialization Content-Language: en-US To: "Huang, Kai" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" Cc: "linux-mm@kvack.org" , "peterz@infradead.org" , "tglx@linutronix.de" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "Williams, Dan J" , "Wysocki, Rafael J" , "kirill.shutemov@linux.intel.com" , "Huang, Ying" , "Chatre, Reinette" , "Brown, Len" , "Luck, Tony" , "ak@linux.intel.com" , "Yamahata, Isaku" , "Gao, Chao" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "david@redhat.com" , "bagasdotme@gmail.com" , "Shahar, Sagi" , "imammedo@redhat.com" References: <557c526a1190903d11d67c4e2c76e01f67f6eb15.1676286526.git.kai.huang@intel.com> <86a8fe2f-566a-d0b9-7a22-9b41c91796f8@intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 947C0120011 X-Rspam-User: X-Stat-Signature: 5ajqczm1185i4yn465m6mhefg39gfzhc X-HE-Tag: 1676328196-784197 X-HE-Meta: U2FsdGVkX1/W7L+znbD+e1gQNC5GcBT/zEMW64r7ytOKo19vDTrKPPzYGxQTrduoEw5HsR5Eh7d99mJCOhWkHIM+3AkJWjd+4XLrg0PqbERqXJ/tfRDQGr3Q5+FJmwAfnsplO/acEhLC18e+8IQ3lG1mH3jjlkPXMcpO29jrXDDOBg412jpUWfjVCgLQmO3ZfRkIlQWRQhTDxQ5nmM++uX2j6OjMIfPhteCpTizaoqtTOGf1y+/3hfL4CquMA+tjo1vQtgCsrRVivcLPWp8uOVKlhxKEZsvbsIk7cUW3Y6KuxSeOo8rKJGgbPmsoq6zgI2vf4fWupsTQAyKRT2VOtQFhT5KahBFYrnfp5QKuEnwFmxVXUK27zcpHUYVmKHh94EOaKX++p7HjexXPjZIpe53yLSNBASnQqoZ0MKxb38/oiVnRuPMHtRz2jDkHH/a77hVyBHenBTtChtir2GOmtiEfOStKFmb9Gy0vIYl3GS5dzu5pJWWWrLCrDgUEvUHP+d4nkmKhFqDyN1HD1QUXxwyiJ4ErUkO+hBW3uvPj7KS6odG/Gvj+8bA/QmhxA0t48BXXvBUVsKj9nJ/h2YS8vtLZczV2QWG+zRRMmjOkO4uYr6thR+YQSlZKs8NWlkE+0m9TNUVpxMyONZSE+YUPajZ4b6ZJizy4IN6ce4Jl9mY2c7Bp/7ETrce4osbP4LnPtHC7Dp0YYEl7kOlNBkCLq9OqsGKMBZBCRkjwJP0waer6EHcTU1ddqIRqu498EhS/Rt5t9qTMlYpfIXcMnJ1PyTUfHyod03CASLJd+fwLtLR8Qe7JAXtJe8hguAz6H/ts2RH2IIsprFx50lOkIg/bZ/Zs7tjC6dMZDCs+PKM4axXnTcISycwDRob7cnF23SNrpz4PgxWl74mbpuSjIedbrz2prmowkpwGH9KSzHhQIHVSFZNVoAWwJiVJ9fW7nllixBk7gYbtPeaIizWpJyy GSsw67yJ VhDNKBwmy5WSMnaceW2TPCJIqm8Zy1YY1PLLtCl5Ef5KM522/7e7p/yjAOVsqDzImmT1iQtuQBXaET+YIJ8lqGX9Q9wBWD5fG6XY2L8sfPpLhy8YFKVEkaevYzB2N/puG7H8tp8xASHlrZf+KJkxWovzP5jYUCjMIeP1Usro2+1alcOU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/13/23 13:19, Huang, Kai wrote: >> On 2/13/23 03:59, Kai Huang wrote: >>> To avoid duplicated code, add a >>> helper to call SEAMCALL on all online cpus one by one but with a skip >>> function to check whether to skip certain cpus, and use that helper to >>> do the per-cpu initialization. >> ... >>> +/* >>> + * Call @func on all online cpus one by one but skip those cpus >>> + * when @skip_func is valid and returns true for them. >>> + */ >>> +static int tdx_on_each_cpu_cond(int (*func)(void *), void *func_data, >>> + bool (*skip_func)(int cpu, void *), >>> + void *skip_data) >> I only see one caller of this. Where is the duplicated code? > The other caller is in patch 15 (x86/virt/tdx: Configure global KeyID on all packages). > > I kinda mentioned this in the changelog: > > " Similar to the per-cpu module initialization, a later step to config the key for the global KeyID..." > > If we don't have this helper, then we can end up with having below loop in two functions: > > for_each_online(cpu) { > if (should_skip(cpu)) > continue; > > // call @func on @cpu. > } I don't think saving two lines of actual code is worth the opacity that results from this abstraction.