From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CFA5C2BD09 for ; Thu, 27 Jun 2024 18:14:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED0556B0083; Thu, 27 Jun 2024 14:14:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7FB46B009D; Thu, 27 Jun 2024 14:14:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D206B6B009E; Thu, 27 Jun 2024 14:14:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B425C6B0083 for ; Thu, 27 Jun 2024 14:14:50 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 397701C20E2 for ; Thu, 27 Jun 2024 18:14:50 +0000 (UTC) X-FDA: 82277469540.16.774143A Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by imf22.hostedemail.com (Postfix) with ESMTP id B0FA9C0011 for ; Thu, 27 Jun 2024 18:14:46 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=Z+ekrNB8; spf=pass (imf22.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.42 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719512078; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oMHKqtsViAFQ8XOx3exriIx8afAjHEvNWX9sCBFwKMs=; b=QLUa3brD/0UsOVUoT4znJFMrJdvw/LvKg/0AhU4vdggMaes4hT58d+7qGNcb+IwU6s0ONF 0MkCq3eZVETMjnGP9T14wGZQjjtI4hFOxykEsgu111egzEhlNhRZWsfprprP2bkse72cgr 1EvnAS4aqsVi08XqYEcap3+JsaB/Weg= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=Z+ekrNB8; spf=pass (imf22.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.42 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719512078; a=rsa-sha256; cv=none; b=ezNSt9xa/jAE6RRUE+qOjD7ZRU7FZlJfu+0Jg0YN3Y1kz2/MncWhF+r/Ye5LwQ6YHjViDt PpUamv/o+7DON8abrztO1sw1Nzgv6Gt/h5QhvPSbZTqZlTpIij9DMXOi5oJMOFqJbphlDu 1xHReaRByclLcCdp+r6wgsphjCO7mag= Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-7f3d2f12d26so7010139f.1 for ; Thu, 27 Jun 2024 11:14:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1719512086; x=1720116886; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oMHKqtsViAFQ8XOx3exriIx8afAjHEvNWX9sCBFwKMs=; b=Z+ekrNB83NuQzqxzTJq+xM6L3ingoJscnJ+bNiVN3vnbae5M9rG32etTbkxcis8HHB DUXWEzB/DM/Y31zXOOrwjlog+PPP25EFsMP9SNyr19clDUEO1I40DH9dLJJ/4k3rwWFL aPn+XyKGg4vcMB/ofe8zCMvfP5jm3KOWTXXks= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719512086; x=1720116886; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oMHKqtsViAFQ8XOx3exriIx8afAjHEvNWX9sCBFwKMs=; b=HoTg4lrLiwvqQE5vo8SBDr85QnGtl8SrgnAn2xXWWw5qvgqmuJiZptf6mqfhL8tjKJ 3dX8mpm3/kgZCEhipNMQ7Va1Rba8tM2OkZlIgehCWkPzUFHPqdLKoUDyibQ0zSGJ4GZM F3HUZUMO1As8THn67QXebNMcX0qpfgGAQ5YPK9YG+Ld8fPIRjj9iEcgKZDNPer2tr+wT TZhzomo/r+x/ugtOA+waaZFDGGBsm8Nk7yXLLJ5mjqJB4OBUZygSol+gPRLpPWL7/4Z3 65Mqz7+YRHBEw5vfvd+lzwslFvJ/4klE6ueniZydUJ49f3OSHjzrJR4KUieZGySp+7eZ chqQ== X-Forwarded-Encrypted: i=1; AJvYcCVqZBTwzxb3SJpV1beyk+ECzSVlKhTgpmgbZRgbux1Vn2gAooWaGDGSm24T+fjHuu855gT2eyl1RR516fWRWMipzEg= X-Gm-Message-State: AOJu0Yz5aq9b6l4UP/Sez2+euTlBruurA4iiudd8CXrimYf55RmLtnPJ b8lUDcUk/X4FhViUEnDTF0bb2OSskv/FX+1tXuWSmp3oDD3/SVP8AQBv+PM40xA= X-Google-Smtp-Source: AGHT+IFUG5O1SrOnPJRNTLD5kODnctBl78frxmuDBYLRyoOk4cGdplKcVn3bQ6BYVahLxGENnJxatg== X-Received: by 2002:a5d:984e:0:b0:7f3:9dd3:15bf with SMTP id ca18e2360f4ac-7f39dd317famr1350449739f.0.1719512085576; Thu, 27 Jun 2024 11:14:45 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-7f61ce9d654sm2994739f.13.2024.06.27.11.14.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jun 2024 11:14:45 -0700 (PDT) Message-ID: Date: Thu, 27 Jun 2024 12:14:43 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/1] selftests: Centralize -D_GNU_SOURCE= to CFLAGS in lib.mk To: Edward Liaw , linux-kselftest@vger.kernel.org, Eric Biederman , Kees Cook , Shuah Khan , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Jason Gunthorpe , Kevin Tian , Paolo Bonzini , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Fenghua Yu , Reinette Chatre , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jarkko Sakkinen , Dave Hansen Cc: linux-kernel@vger.kernel.org, usama.anjum@collabora.com, seanjc@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sgx@vger.kernel.org, John Hubbard , Shuah Khan References: <20240625223454.1586259-1-edliaw@google.com> <20240625223454.1586259-2-edliaw@google.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240625223454.1586259-2-edliaw@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: B0FA9C0011 X-Stat-Signature: o89hbcimut7u1r5buyumu5huthnw7388 X-HE-Tag: 1719512086-911262 X-HE-Meta: U2FsdGVkX1/r0eM288IYglLKSuLihFTX9gwNwFeZTG8cT3WnArEEihtuciNjD8RHpa05LbkT/Xb77w4wiFHkTPK5wKiQtqq2hs+bYMYiRyqecWnz2Jym9J8S4ZCe9FwwFPL+2jLB538waOvHSwtfhpQ3+jSBJYViqL03mNxiIiVciZLsRqWjvbTwNjyJdmQ6pLL+wWTp+Mr523/Nu7GPzBAljU44zCXpmTe6jIakSIZcHLrabRQP348n8CbLQ0UW77/fDu7QL1MooMo6cOdDCFOoRiCdLLM5lt6/g9RYRqWgUGzhvCFVZPOVKdMnidNRdlA/Qt7QBbKsPo0tZb9WYEZ948gEi7dVqqEE49QrrDpVx3WC59gee+J18aOiywumvkt3HNUYRCgkjepBvGxBnelEjVevdBdBT5ySIoEaRCWwvJvfP7TZm1PJIZp3YBSa3Rm4g0J5+hNahMlHfxZGLasGdpCQDhvDTmR8L1tyIMMRXx/K3RPHIfhFrOVsjzf6+pAAaDspcLixCs3x3l6CPBfWcqYVdlWxE61qu4t5Z1P/HSv+NmpSzkkkD0TcJEoQYD55UbJGcdhW6C0SOAP5fJizNJGhatLBlVayHmtEg7WZ1tAYoX1RBVJ+izh8E3J8k8wLE31KLAzGzY+zip7EUfNy5C3mQmCCz1+BkXawFbVBXm82wyOD5PoN6/ZW4vLPSO6IrhClBvjcHFk0Vm9tm6N2aHKX7sU4AhhDRcdBZ3byebw58WM+eZVoI6vMzhLBDZX5YamNHy6018o/mD/YrlCPRUpUkQlOWlfxuJrwIU7DZcKw5AVhmHEhAS3UFRIyWs6+Yy4XkW5090EsG4w4QiJ1AFHC91DimJa23FZ3f9sWv7BTlVV/KFtto1BtnwHI4HE3KEkpiNvXaVf2FwgMcb3WTwF1s37b9mz7BjoEk6PvYskmPniKo9tLDV1ErciaWWbFo3OgVYSG0NB6jeG cY1a//fb zHd3IrIKuEwIFKyNeA0TZkyQWSuxO0Pd5/m/jkSglN53FrTTcGNTmdNu6MACfCHW4ydTKKDb6ry7l8VICyqpcr2YqpE540cG6Df/uKZVZBccqMAnVOeyAzsBiKzRO5kFexvpkGPgBPq6Yvy0lkoE4oXchvChdBCQreObmJBRwNYj/Ffab3vjzuQn3wwdMkhJtz48QrTXDryYnA/CnNJgRWkQHy61FrjmUyRzOQPh+CRKtRETZz/2buW5yEH+u/4SW9GI3lMOwviOodOJxIQPe95g61FVJnMpIhTqorcXUwsk4BYasQMH425RvOvIEXBkJPj6aZPqJaz6OIL62FV8za+QA3xKtDxVWBf0JBVkEcjV6SynWX3uZ2w4CM210ZrzjKZ/xbe6I0vGoKryRqRBSVWNSLjT66FJls1HFBaIuZAclIWrteBMyFa3cfUPJcmhAS9jh/TWLjDXPKTKckgque5T17I1RUBvzcq9Y3lm0kJWhOkQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/25/24 16:34, Edward Liaw wrote: > Centralize the _GNU_SOURCE definition to CFLAGS in lib.mk. Remove > redundant defines from Makefiles that import lib.mk. Convert any usage > of "#define _GNU_SOURCE 1" to "#define _GNU_SOURCE". > > This uses the form "-D_GNU_SOURCE=", which is equivalent to > "#define _GNU_SOURCE". > > Otherwise using "-D_GNU_SOURCE" is equivalent to "-D_GNU_SOURCE=1" and > "#define _GNU_SOURCE 1", which is less commonly seen in source code and > would require many changes in selftests to avoid redefinition warnings. > > Suggested-by: John Hubbard > Signed-off-by: Edward Liaw > --- > tools/testing/selftests/exec/Makefile | 1 - > tools/testing/selftests/futex/functional/Makefile | 2 +- > tools/testing/selftests/intel_pstate/Makefile | 2 +- > tools/testing/selftests/iommu/Makefile | 2 -- > tools/testing/selftests/kvm/Makefile | 2 +- > tools/testing/selftests/lib.mk | 3 +++ > tools/testing/selftests/mm/thuge-gen.c | 2 +- > tools/testing/selftests/net/Makefile | 2 +- > tools/testing/selftests/net/tcp_ao/Makefile | 2 +- > tools/testing/selftests/proc/Makefile | 1 - > tools/testing/selftests/resctrl/Makefile | 2 +- > tools/testing/selftests/ring-buffer/Makefile | 1 - > tools/testing/selftests/riscv/mm/Makefile | 2 +- > tools/testing/selftests/sgx/Makefile | 2 +- > tools/testing/selftests/tmpfs/Makefile | 1 - > 15 files changed, 12 insertions(+), 15 deletions(-) > Andrew, I am seeing merge conflicts with mm and exec tests. Might be better to have you take this through your tree? Acked-by: Shuah Khan thanks, -- Shuah