From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80A9BC433FE for ; Wed, 12 Jan 2022 09:17:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C63E96B012E; Wed, 12 Jan 2022 04:17:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C13AD6B012F; Wed, 12 Jan 2022 04:17:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADB726B0130; Wed, 12 Jan 2022 04:17:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id 9FD336B012E for ; Wed, 12 Jan 2022 04:17:55 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 64F8894FA0 for ; Wed, 12 Jan 2022 09:17:55 +0000 (UTC) X-FDA: 79021082910.23.394108C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id C1DD14000D for ; Wed, 12 Jan 2022 09:17:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641979074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e0KOzwrUqCbQH/o01fWrMq8CbrmFNeed7/005+0tTSM=; b=iSI8y37Jq+2sjubhREox/DUbG9Tyvfd6B0wEjSvYwFS2O6hWTMdzDricgdvIaiKTUXq5+M qxn5gbWI7OHr53fDhsL4wAGC7+IY2VFA+nTTmkt6D1SUyasI6FCQXmACueshmU1vnwCl+o ncsqx0y8OPyrKFKDsGv80LUdpnniZ+A= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-639-5mmqaRBMP6Sh0s6BPNvhyQ-1; Wed, 12 Jan 2022 04:17:51 -0500 X-MC-Unique: 5mmqaRBMP6Sh0s6BPNvhyQ-1 Received: by mail-ed1-f69.google.com with SMTP id eg24-20020a056402289800b003fe7f91df01so1725722edb.6 for ; Wed, 12 Jan 2022 01:17:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=e0KOzwrUqCbQH/o01fWrMq8CbrmFNeed7/005+0tTSM=; b=W0poStUl9hc+MTKwKGaicusSnd7zB1Ilg9vmee0Ni09SC7mj6J3N++BNQoOnPPKaI7 UK/zexTHhIaSVJtVM4R9HN9Y8g9jn62BjiTsEJGDTd/+Ck485HNIki/lwhrxC9gkhovF iOEwrWTFO07OpzKhL1tu2FfTJIPyrwbWHsaOQ3nBorjyLrl18Tp7dr3BArp5+HEpAQSg ln+iR91wp+0tdVGxkBkHbfqwkpMAIpDj7Ul6XI9UDn9QEN71yOPr/VJAkSENi0sC7Ns1 ES/7UijsduClX+yqFwVxdHC96DtF7qkExayKr3LgyziNMPbp6G1sxV35WMZ8f0QNT1ZI 4zOA== X-Gm-Message-State: AOAM5333SMctCvuHSRq7BW6BP+fgJyMLUNc4bcH8raEkBFZLykKQfwU0 pi1knYdDgFHnFnJ99m00RU3QumlBySbRHOdGhnlCCq7MDGp0KVxpcTCnke9N+r1P78LKHozdk8+ i92ueXa+YqMc= X-Received: by 2002:a17:907:3f0c:: with SMTP id hq12mr6821393ejc.358.1641979069892; Wed, 12 Jan 2022 01:17:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJzOD9iPR7HXlJWokCcL1fccdXMM8E7I6wuS9gOcKt0Yc+oOkHcqTjYDlSTOto/CciTFEAMyvw== X-Received: by 2002:a17:907:3f0c:: with SMTP id hq12mr6821377ejc.358.1641979069698; Wed, 12 Jan 2022 01:17:49 -0800 (PST) Received: from ?IPV6:2003:cb:c702:4700:e25f:39eb:3cb8:1dec? (p200300cbc7024700e25f39eb3cb81dec.dip0.t-ipconnect.de. [2003:cb:c702:4700:e25f:39eb:3cb8:1dec]) by smtp.gmail.com with ESMTPSA id i22sm4360577ejw.75.2022.01.12.01.17.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jan 2022 01:17:49 -0800 (PST) Message-ID: Date: Wed, 12 Jan 2022 10:17:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] mm/thp: Drop unused trace events hugepage_[invalidate|splitting] To: Anshuman Khandual , linux-mm@kvack.org Cc: Steven Rostedt , Ingo Molnar , Andrew Morton , "Aneesh Kumar K.V" , "Kirill A . Shutemov" , linux-kernel@vger.kernel.org References: <1641546351-15109-1-git-send-email-anshuman.khandual@arm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <1641546351-15109-1-git-send-email-anshuman.khandual@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C1DD14000D X-Stat-Signature: ycipjjwhjds7hfe89n6m3jsh654rm5ru Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iSI8y37J; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf07.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam03 X-HE-Tag: 1641979074-283444 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.01.22 10:05, Anshuman Khandual wrote: > The trace events hugepage_[invalidate|splitting], were added via the commit > 9e813308a5c1 ("powerpc/thp: Add tracepoints to track hugepage invalidate"). > Afterwards their call sites i.e trace_hugepage_[invalidate|splitting] were > just dropped off, leaving these trace points unused. > > Cc: Steven Rostedt > Cc: Ingo Molnar > Cc: Andrew Morton > Cc: "Aneesh Kumar K.V" > Cc: Kirill A. Shutemov > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > This applies on v5.16-rc8 > > trace_hugepage_splitting() dropped via the commit 7aa9a23c69ea > trace_hugepage_invalidate() dropped via the commit 7900757ce1b4 > > include/trace/events/thp.h | 36 ------------------------------------ > 1 file changed, 36 deletions(-) > > diff --git a/include/trace/events/thp.h b/include/trace/events/thp.h > index d7fbbe551841..ffa4b37d02a9 100644 > --- a/include/trace/events/thp.h > +++ b/include/trace/events/thp.h > @@ -8,24 +8,6 @@ > #include > #include > > -TRACE_EVENT(hugepage_invalidate, > - > - TP_PROTO(unsigned long addr, unsigned long pte), > - TP_ARGS(addr, pte), > - TP_STRUCT__entry( > - __field(unsigned long, addr) > - __field(unsigned long, pte) > - ), > - > - TP_fast_assign( > - __entry->addr = addr; > - __entry->pte = pte; > - ), > - > - TP_printk("hugepage invalidate at addr 0x%lx and pte = 0x%lx", > - __entry->addr, __entry->pte) > -); > - > TRACE_EVENT(hugepage_set_pmd, > > TP_PROTO(unsigned long addr, unsigned long pmd), > @@ -65,24 +47,6 @@ TRACE_EVENT(hugepage_update, > > TP_printk("hugepage update at addr 0x%lx and pte = 0x%lx clr = 0x%lx, set = 0x%lx", __entry->addr, __entry->pte, __entry->clr, __entry->set) > ); > -TRACE_EVENT(hugepage_splitting, > - > - TP_PROTO(unsigned long addr, unsigned long pte), > - TP_ARGS(addr, pte), > - TP_STRUCT__entry( > - __field(unsigned long, addr) > - __field(unsigned long, pte) > - ), > - > - TP_fast_assign( > - __entry->addr = addr; > - __entry->pte = pte; > - ), > - > - TP_printk("hugepage splitting at addr 0x%lx and pte = 0x%lx", > - __entry->addr, __entry->pte) > -); > - > #endif /* _TRACE_THP_H */ > > /* This part must be outside protection */ Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb