From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C483C67861 for ; Fri, 5 Apr 2024 09:25:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35FC46B0137; Fri, 5 Apr 2024 05:25:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E9236B0139; Fri, 5 Apr 2024 05:25:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13D176B013A; Fri, 5 Apr 2024 05:25:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E79AF6B0137 for ; Fri, 5 Apr 2024 05:25:51 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 74AD414111E for ; Fri, 5 Apr 2024 09:25:51 +0000 (UTC) X-FDA: 81974946102.03.B52B112 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 5E21FC0004 for ; Fri, 5 Apr 2024 09:25:49 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PiQYRA47; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712309149; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LgdcM5lMbBMLvsnXVIs0MYgiAmuaqteAte5G5/RondM=; b=v2wvzpVrw/y0wNrHAkS+KlIfzOW3Dn4CaxYxxTDM5MCsvRoUcK2FOrRJ9vIYfQDBo8wTar zQdboCR6nSdFX7wgdzqDLmHJYGr6rlXNpZG4faqGfuNktlVT7w267ZgSIhsCqq+0O6TiVO VpjxV6LWHSTSEN5cpvBSj+Gt4PNKL7o= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PiQYRA47; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712309149; a=rsa-sha256; cv=none; b=3b2B+/7mC15JszHs/1a5jQasqF8l63KU8ClAR4aRN2TopFuas9UvkU694/bPPLojojviHc Hgx7YRzkf4Op9FQf3o9YrGUN6zTds31MAPR1b7BObu01Kadsdq0s+xT4WEkpFOMVbmcpHc fDe3QnBXvmQcdRjverCPKt2Fw6XxuvE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712309148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LgdcM5lMbBMLvsnXVIs0MYgiAmuaqteAte5G5/RondM=; b=PiQYRA47CLnYj34w1jUgJSlA1EBq7PLSuYR0F6ADlqV43EzkUv5DOlW1ix9VOIFIdIXcGd 3OeuSqW5z6mMHLcy/Z/03cDASrYidzNj7EjIzD/sfdIvcm2nFI3MpfEqCSNQbgTWGiLQbB aulddS8rUoHcBaPRMBvnxtKMvay30S8= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-106-CwiCblYqO4O1RG1sFLRUOQ-1; Fri, 05 Apr 2024 05:25:47 -0400 X-MC-Unique: CwiCblYqO4O1RG1sFLRUOQ-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d818a149bbso16272651fa.3 for ; Fri, 05 Apr 2024 02:25:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712309145; x=1712913945; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=LgdcM5lMbBMLvsnXVIs0MYgiAmuaqteAte5G5/RondM=; b=PbsWUhwcoL75YhGsOy1vvWqCXpugwNQ27ODvgvZw+hqEPiDyibjSW9I0wqxXmsB2wT dZUcwZRkk+Ey6XOIKWAAHTIJ7BUnKpxHubGy/lv0cdUlCJ5Bx/HSb/hIYBICZyZiurzi N5IDxZwdqMMPEVbA7HrGM8tYK9zf9o1t4RDn15WCr6A17qflmhf4n/8aDQ71XsWWAKnn Pt4XkgAQNPG1ZIrTh2nZF5xq/8ENnzVqMxzkPPsj4wzFBZVTTgH6YrLOMAn4Oj2KrQHU /sGXgWPT0oXxeJPtTwTEQVb9vJ4lowefs0x616dMsiE8oqtR7m+kbtzVM4pm+3xiE6fT 3gRg== X-Gm-Message-State: AOJu0YwAPcrm7Ib0yQclJ/qwxrw4pr8Kte/OIDKgBGTGbLsS1BckgWVg PrjMPgH2VI8SM86IF1ERZxZOCIqN+rO+FTKcU7sqXRYZ3kpAl21fJhFle221Xgza4aPo0+eKzA8 P7R/jbwPTg4sGNsfkTzJu+v1UIGXwxV8yyeC+ifkB7t0vSFDF X-Received: by 2002:a2e:b811:0:b0:2d8:620b:9838 with SMTP id u17-20020a2eb811000000b002d8620b9838mr607203ljo.46.1712309145620; Fri, 05 Apr 2024 02:25:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELU4ic+i6IbRyUTpfd6zlGD7647m42n4mPwdZh+D0TEUULnycqLipdzXidFvbO17HsPkAvFw== X-Received: by 2002:a2e:b811:0:b0:2d8:620b:9838 with SMTP id u17-20020a2eb811000000b002d8620b9838mr607195ljo.46.1712309145225; Fri, 05 Apr 2024 02:25:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:5500:e1f8:a310:8fa3:4ec1? (p200300cbc74b5500e1f8a3108fa34ec1.dip0.t-ipconnect.de. [2003:cb:c74b:5500:e1f8:a310:8fa3:4ec1]) by smtp.gmail.com with ESMTPSA id h22-20020a05600c351600b0041562a58b75sm2228408wmq.13.2024.04.05.02.25.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 02:25:44 -0700 (PDT) Message-ID: Date: Fri, 5 Apr 2024 11:25:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/6] mm: swap: Remove CLUSTER_FLAG_HUGE from swap_cluster_info:flags To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Huang Ying , Gao Xiang , Yu Zhao , Yang Shi , Michal Hocko , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Chris Li , Lance Yang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240403114032.1162100-1-ryan.roberts@arm.com> <20240403114032.1162100-2-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240403114032.1162100-2-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5E21FC0004 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: itwqgscuye6s91u83u5krtbhpx9cdbzf X-HE-Tag: 1712309149-345730 X-HE-Meta: U2FsdGVkX19+r1GR9jUE3GwhjZHqPIb9LHZmeaCgUsqvPpaDrYXZaxZrG0j3dq+P4/bPhOkGqD0Tt4l1+ERQIUGL1HrXk6brUhE8l/KezTVFGi9GztMJ8fag0DmLys/6shhZY0NFQdb542eyCNn+OfYySLHqI4ofZK8WrpIXAy+UG38I40PIAIx/r/V41gidiOo93fZ4+Te74mND0FFxyxiBrM5rPanlnE/bUsxPiN7Qc0Ok2R9HsGfeGVNtewAZCVeCxgmgEul47k3GfAyUzRSOsx/g2TrYKDQws48R7+j0F4AiPMG+ZHFknrBI94Wlp4FKNmAgQd3cgp+CNdAYwXXSJksI4soWjmvQWzJBKJX9Z9tVeguF1LY3Pk6ownEJNHpVLi8y/wt2i/F35E5khTAl4DkAN4KrzEyODXXyr29XjIPS3/ebjWyGHbqa0iIMTqZvJLNO/hOVB1DwOQiF+dC1tVdfRY4HSv0rLEbHcE6Ni2xrfZLN/nINKtxdfwWcAddQ56mEgSUFTBNJUshRkk9sV5iUcLl5M0JwACnc6IK1AElghSx+qYScLGVOnZhiP7igogvCh0E/BvC0u1AiRdLpdWWuIRENEyFTso3Kc6KfSk3u4jbjJomsl/6xg8iMzOGQwO0mUi/LxCr22E53TwKZj1Mo9xOC7R0eOzdiT4gJLQvjEfS8YgEQR0rRJgJKyVIZOpVvRI7k0Ob0xIC2IxVESytNKL0gvCN0nHK5gvmD4wFts7zBTZv0F/D3w5rCLy1VknsOuIvqckhUkZv7a6ePbSWImuvktxUsGfA3QrQZD+OH1KV6hx0azpmd+pU+5pw3So/ER9EVGmMIN4kieZx7BgJfSlWschiO9qnzOY5e5ju4SdQpOsdZukJUN7+3M278O59vgpPwBq419BCWmVshLgLQKjFf+vA8Rw8uHYwnXrmePg9eA6P08e7Gh/hs4ayvfMPCcfwrFZjKGs9 fUTmLgHG GOQ7XSElw7BP+T3y6zT9E6+Jvex5I6yIjzV5Ir9U7etiQLE3XTdomZ58QySP/FjSTZsc81lW523s9vJa7GKEcsH0lSVp5bgDuj4qB4Edav1DB7PehlPV8FO621NdCrqqBSbhlUF4JqeUpE8gahK4oz6b0RAjY0gIlcR4eiRvRj+xhlaqn73QcCs8E8U+e28AdSO/iuqkF2SrePIU8Q5dGnsUggw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.04.24 13:40, Ryan Roberts wrote: > As preparation for supporting small-sized THP in the swap-out path, > without first needing to split to order-0, Remove the CLUSTER_FLAG_HUGE, > which, when present, always implies PMD-sized THP, which is the same as > the cluster size. > > The only use of the flag was to determine whether a swap entry refers to > a single page or a PMD-sized THP in swap_page_trans_huge_swapped(). > Instead of relying on the flag, we now pass in nr_pages, which > originates from the folio's number of pages. This allows the logic to > work for folios of any order. > > The one snag is that one of the swap_page_trans_huge_swapped() call > sites does not have the folio. But it was only being called there to > shortcut a call __try_to_reclaim_swap() in some cases. > __try_to_reclaim_swap() gets the folio and (via some other functions) > calls swap_page_trans_huge_swapped(). So I've removed the problematic > call site and believe the new logic should be functionally equivalent. > > That said, removing the fast path means that we will take a reference > and trylock a large folio much more often, which we would like to avoid. > The next patch will solve this. > > Removing CLUSTER_FLAG_HUGE also means we can remove split_swap_cluster() > which used to be called during folio splitting, since > split_swap_cluster()'s only job was to remove the flag. > > Reviewed-by: "Huang, Ying" > Signed-off-by: Ryan Roberts > --- [started to review v5, then saw v6] Acked-by: David Hildenbrand -- Cheers, David / dhildenb