From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7508DF47CA0 for ; Thu, 5 Mar 2026 17:35:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCDD06B0005; Thu, 5 Mar 2026 12:35:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DA6676B0088; Thu, 5 Mar 2026 12:35:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C54AF6B0089; Thu, 5 Mar 2026 12:35:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AECC96B0005 for ; Thu, 5 Mar 2026 12:35:04 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 747C2160228 for ; Thu, 5 Mar 2026 17:35:04 +0000 (UTC) X-FDA: 84512710128.09.0DFAE12 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf25.hostedemail.com (Postfix) with ESMTP id 7F032A0013 for ; Thu, 5 Mar 2026 17:35:02 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SNJUfyAa; spf=pass (imf25.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1772732102; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dcaXRjPP8q/PZCJllt/HjrAZv9ZpuWanFuUS+93tEbw=; b=MrOosE8r1YNOyXA9IqnDBhjvmKMrUcrjf2CPIkeJZrk4+5JEs++ELcd98R5uN1gCNT4Avl 1X5/XY03eKlL7AS+mCSq7XOQGEUYupeEZAAtvvPyV9Z7RQguVLq46ODjnK811/ywzrlWgk DukeSyk93zrg0Xu1/mQpyva2g9LxE7w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1772732102; a=rsa-sha256; cv=none; b=Sjh62dNdvy5UAXFzvwcF/oLcJtcbESNsPiLOscyvuYDU2UCdCNUvrsSRElET4Hj/ZMRD+V +dXIkp/HvIJlaA/SF68BbbFCx6aAFSHVFGVYzheSCy1D+ERy2HAtI/rqtyggACPHwai4DS 9PQycITSTXC0H4B8Wze8vjmxsRP2suo= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SNJUfyAa; spf=pass (imf25.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 73192409BD; Thu, 5 Mar 2026 17:35:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFEACC19425; Thu, 5 Mar 2026 17:34:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772732101; bh=56aRoAVzPeQ+dwVrdE3T5LIBh/tHK5LhrXeg2GPGARY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SNJUfyAa+pOGSpSVWJhLtY5AZnRO7etbHovFucUT8TXtqWY9985XSqGU8RMWCDSMd 1ZFYbjOd3UTSfkRHwfCNAbUOR8czgn3AP5sdfd3NDuMTwlejtHcBQywUKbAkce4nTe dEwNcN9AYGiADUff+P0WNpX+woEHoHermioN+npeoYqsCJHEP5pDpw9nhdmbj8i1n9 S8ZG8tpuRHozTfhieeF2eQimOT3Mr+dJeCNLypIAETyKi3durz59wMY2erlZRNGn7t n1IaS6Ru9j6oE8qY8qN5jctLVXgDfFP9P0eHUpDtsiPtIGlce9evGXASnm9NnTQCF0 DnFXPOqZ3moTA== Message-ID: Date: Thu, 5 Mar 2026 18:34:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 02/15] set_memory: add folio_{zap,restore}_direct_map helpers To: "Kalyazin, Nikita" , "kvm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "bpf@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "kernel@xen0n.name" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "loongarch@lists.linux.dev" Cc: "pbonzini@redhat.com" , "corbet@lwn.net" , "maz@kernel.org" , "oupton@kernel.org" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "seanjc@google.com" , "tglx@kernel.org" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "luto@kernel.org" , "peterz@infradead.org" , "willy@infradead.org" , "akpm@linux-foundation.org" , "lorenzo.stoakes@oracle.com" , "vbabka@suse.cz" , "rppt@kernel.org" , "surenb@google.com" , "mhocko@suse.com" , "ast@kernel.org" , "daniel@iogearbox.net" , "andrii@kernel.org" , "martin.lau@linux.dev" , "eddyz87@gmail.com" , "song@kernel.org" , "yonghong.song@linux.dev" , "john.fastabend@gmail.com" , "kpsingh@kernel.org" , "sdf@fomichev.me" , "haoluo@google.com" , "jolsa@kernel.org" , "jgg@ziepe.ca" , "jhubbard@nvidia.com" , "peterx@redhat.com" , "jannh@google.com" , "pfalcato@suse.de" , "shuah@kernel.org" , "riel@surriel.com" , "ryan.roberts@arm.com" , "jgross@suse.com" , "yu-cheng.yu@intel.com" , "kas@kernel.org" , "coxu@redhat.com" , "kevin.brodsky@arm.com" , "ackerleytng@google.com" , "maobibo@loongson.cn" , "prsampat@amd.com" , "mlevitsk@redhat.com" , "jmattson@google.com" , "jthoughton@google.com" , "agordeev@linux.ibm.com" , "alex@ghiti.fr" , "aou@eecs.berkeley.edu" , "borntraeger@linux.ibm.com" , "chenhuacai@kernel.org" , "dev.jain@arm.com" , "gor@linux.ibm.com" , "hca@linux.ibm.com" , "palmer@dabbelt.com" , "pjw@kernel.org" , "shijie@os.amperecomputing.com" , "svens@linux.ibm.com" , "thuth@redhat.com" , "wyihan@google.com" , "yang@os.amperecomputing.com" , "Jonathan.Cameron@huawei.com" , "Liam.Howlett@oracle.com" , "urezki@gmail.com" , "zhengqi.arch@bytedance.com" , "gerald.schaefer@linux.ibm.com" , "jiayuan.chen@shopee.com" , "lenb@kernel.org" , "osalvador@suse.de" , "pavel@kernel.org" , "rafael@kernel.org" , "vannapurve@google.com" , "jackmanb@google.com" , "aneesh.kumar@kernel.org" , "patrick.roy@linux.dev" , "Thomson, Jack" , "Itazuri, Takahiro" , "Manwaring, Derek" , "Cali, Marco" References: <20260126164445.11867-1-kalyazin@amazon.com> <20260126164445.11867-3-kalyazin@amazon.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20260126164445.11867-3-kalyazin@amazon.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 7F032A0013 X-Stat-Signature: 9sdpswdnejwe3kasdjmr31hxuzekc4e8 X-HE-Tag: 1772732102-260287 X-HE-Meta: U2FsdGVkX1/r00ignS+YOooa1/GTltg75BEZuo0MER6XwuHacNxT8Argwr11pknq3Zi6ijcx59pjRsubkqFXUqzIObTc5hU58Q4TmjcAouBSfWKKygLK52+UmHzL+oXsPb7yCtYKoanzaKBu75hifsDs/QJ6IpMi+DHWEB9LPu3PmvlPA8XrMKU4+hE54Q7lPtPVpeP4KkHZ54EmV9lYdNGfEpH9w6bz3XU5CR155UTyvU3hee0Bgjm6XZVD7P7WnLxOtxsrgb5Dtj964o1CbxlR31UCxnYsJZDnDIQH6XEr264vah6KtujxWyBzUi5G50TpqtbKKofxE+VSHaFVUksddzNXUJIZmZ6VsRnE6Oqe+fKVeGpmW7+XKiUFo1n4tIBbj4trj9jgd1jhSYPsvHIfun6xVMzz4QtWgnbv+74yy8Dyk92G1CyHsBdkpQcL+6WITI5OyFxekF44l0cWlZu720LveSpfarlnIx2jrP0L8dOE6jrUJvhjKefBfOQ4N6tewg5oP98Lptl0KH+7lVPS+UTMMfoBFM/UxxQE5ZaG1PwDNUM2+5no0tLUU6vR1HqeKZhi6Bms13oR7btOJAR9ronOdo1Oq1V7gZhfhFfLeuaXIUKJfNsWaSriiHWQwZteA+rav+A4pVtfpPZnW3RwwQ36fUdw1m/cUyGWVAeqPQnz1a/uQTwx0wQpfL5jMgK1VYSpF/oIXa3Lyg5M/T7lzdZxaiJDD3TBoFApgTeHM5ECsBbzXYOsR5HMUyMl2iHqwyVCRRiX6M6p10Ai+899upv1L7k8trJjbYf6ZholTME3UNy9L/ubhsyt83N8qdzIJCnmmKecSv5PIQHkUGJsOGUPkLjPAgbM7sQlmXyU/0pUaXqMkvVoqTm2JS81I5fNv+05zC8UJkvqpdwALD/So5gH9x+FcMte/SLjgueDZ4aKORxp2SFBnPbMh5/px+uSE091blIqJ+D3Mw8 ReaB7sfq 731r+68ZoXPkoW0d6plctuB8ULOc1CuW/d7FAgGvbiBhv2FOOwarg7rfb2jWL/zCCCDUSa6TwBi/YYp26/QX376ulY7h73dW/7C866p0yjEHeJ5A0MZRmowMeMfWk4wARX2ZkIMofiRWTAf1ZxaSlOsjdHMHWbKslOmG1OwblIfiIaKNLJz7BOqv4GrWDn2RFHRmM1jwwUfYId7arK8w/C2rwe2aaJUf8YmwSbMDUFKmoyR73r+br4zbUSnAZpRAOlA5p+sybjSN9YVvZpEt46kfqNtjmkG9UKgFFnB/UuE3QY/AFJa4YW9pyw7hPPvMYH+2F5iI7pT5PRjUNgCjMG1+V3xIyaFU77IijSIc7qiXDFVBDg3Tn2Vorb0h+HRs6zN93SPZ1jJSzzGukridNbMs/rI7RCOZ44FIt95XohK9qImiS/sdXVZpElDUjT54prUQEWHm+iFeRZY/ZNse2gYz/yA== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/26/26 17:47, Kalyazin, Nikita wrote: > From: Nikita Kalyazin > > These allow guest_memfd to remove its memory from the direct map. > Only implement them for architectures that have direct map. > In folio_zap_direct_map(), flush TLB on architectures where > set_direct_map_valid_noflush() does not flush it internally. "Let's provide folio_{zap,restore}_direct_map helpers as preparation for supporting removal of the direct map for guest_memfd folios. ... > > The new helpers need to be accessible to KVM on architectures that > support guest_memfd (x86 and arm64). Since arm64 does not support > building KVM as a module, only export them on x86. > > Direct map removal gives guest_memfd the same protection that > memfd_secret does, such as hardening against Spectre-like attacks > through in-kernel gadgets. Would it be possible to convert mm/secretmem.c as well? There, we use set_direct_map_invalid_noflush(folio_page(folio, 0)); and set_direct_map_default_noflush(folio_page(folio, 0)); Which is a bit different to below code. At least looking at the x86 variants, I wonder why we don't simply use set_direct_map_valid_noflush(). If so, can you add a patch to do the conversion, pleeeeassse ? :) > > Reviewed-by: Ackerley Tng > Signed-off-by: Nikita Kalyazin > --- > arch/arm64/include/asm/set_memory.h | 2 ++ > arch/arm64/mm/pageattr.c | 12 ++++++++++++ > arch/loongarch/include/asm/set_memory.h | 2 ++ > arch/loongarch/mm/pageattr.c | 12 ++++++++++++ > arch/riscv/include/asm/set_memory.h | 2 ++ > arch/riscv/mm/pageattr.c | 12 ++++++++++++ > arch/s390/include/asm/set_memory.h | 2 ++ > arch/s390/mm/pageattr.c | 12 ++++++++++++ > arch/x86/include/asm/set_memory.h | 2 ++ > arch/x86/mm/pat/set_memory.c | 20 ++++++++++++++++++++ > include/linux/set_memory.h | 10 ++++++++++ > 11 files changed, 88 insertions(+) > > diff --git a/arch/arm64/include/asm/set_memory.h b/arch/arm64/include/asm/set_memory.h > index c71a2a6812c4..49fd54f3c265 100644 > --- a/arch/arm64/include/asm/set_memory.h > +++ b/arch/arm64/include/asm/set_memory.h > @@ -15,6 +15,8 @@ int set_direct_map_invalid_noflush(const void *addr); > int set_direct_map_default_noflush(const void *addr); > int set_direct_map_valid_noflush(const void *addr, unsigned long numpages, > bool valid); > +int folio_zap_direct_map(struct folio *folio); > +int folio_restore_direct_map(struct folio *folio); > bool kernel_page_present(struct page *page); > > int set_memory_encrypted(unsigned long addr, int numpages); > diff --git a/arch/arm64/mm/pageattr.c b/arch/arm64/mm/pageattr.c > index e2bdc3c1f992..0b88b0344499 100644 > --- a/arch/arm64/mm/pageattr.c > +++ b/arch/arm64/mm/pageattr.c > @@ -356,6 +356,18 @@ int set_direct_map_valid_noflush(const void *addr, unsigned long numpages, > return set_memory_valid((unsigned long)addr, numpages, valid); > } > > +int folio_zap_direct_map(struct folio *folio) > +{ > + return set_direct_map_valid_noflush(folio_address(folio), > + folio_nr_pages(folio), false); > +} > + > +int folio_restore_direct_map(struct folio *folio) > +{ > + return set_direct_map_valid_noflush(folio_address(folio), > + folio_nr_pages(folio), true); > +} Is there a good reason why we cannot have two generic inline functions that simply call set_direct_map_valid_noflush() ? Is it because of some flushing behavior? (which we could figure out) In particular, a single set of functions could have a beautiful centralized kerneldoc, right?! :) -- Cheers, David