From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C627C433EF for ; Tue, 8 Feb 2022 10:57:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 990196B0074; Tue, 8 Feb 2022 05:57:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9409F6B0075; Tue, 8 Feb 2022 05:57:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82F7D6B0078; Tue, 8 Feb 2022 05:57:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0101.hostedemail.com [216.40.44.101]) by kanga.kvack.org (Postfix) with ESMTP id 755EE6B0074 for ; Tue, 8 Feb 2022 05:57:00 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2ABE1181D207A for ; Tue, 8 Feb 2022 10:57:00 +0000 (UTC) X-FDA: 79119310200.19.8BA2292 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf31.hostedemail.com (Postfix) with ESMTP id EFCC420006 for ; Tue, 8 Feb 2022 10:56:57 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4JtKgF5wMTzccnm; Tue, 8 Feb 2022 18:55:53 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 8 Feb 2022 18:56:53 +0800 Subject: Re: [PATCH 1/4] mm/memory_hotplug: remove obsolete comment of __add_pages To: Oscar Salvador CC: , , References: <20220207133643.23427-1-linmiaohe@huawei.com> <20220207133643.23427-2-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: Date: Tue, 8 Feb 2022 18:56:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: EFCC420006 X-Stat-Signature: wnutiyi9fkjixkhkemo6eohuiem4qqik Authentication-Results: imf31.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf31.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1644317817-435507 X-Bogosity: Ham, tests=bogofilter, spamicity=0.010779, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/2/8 18:15, Oscar Salvador wrote: > On Mon, Feb 07, 2022 at 09:36:40PM +0800, Miaohe Lin wrote: >> Since commit f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded >> memory to zones until online"), there is no need to pass in the zone. >> >> Signed-off-by: Miaohe Lin > > Yeah, I am with David here, "Reasonably generic function for adding > memory" does not really tell me much about that function. > Agree with you. And Andrew have kindly made that change. Many thanks for your review. :)