From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 660D9C64E75 for ; Fri, 27 Nov 2020 10:37:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E3862208CA for ; Fri, 27 Nov 2020 10:37:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3862208CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 56FB86B006E; Fri, 27 Nov 2020 05:37:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F7ED6B0070; Fri, 27 Nov 2020 05:37:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BE8B6B0071; Fri, 27 Nov 2020 05:37:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0107.hostedemail.com [216.40.44.107]) by kanga.kvack.org (Postfix) with ESMTP id 208CE6B006E for ; Fri, 27 Nov 2020 05:37:17 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DB04D1EE6 for ; Fri, 27 Nov 2020 10:37:16 +0000 (UTC) X-FDA: 77529846072.02.crack64_0c0776027387 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id C16F610097AA0 for ; Fri, 27 Nov 2020 10:37:16 +0000 (UTC) X-HE-Tag: crack64_0c0776027387 X-Filterd-Recvd-Size: 2803 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Fri, 27 Nov 2020 10:37:16 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7E166AF38; Fri, 27 Nov 2020 10:37:14 +0000 (UTC) Subject: Re: [PATCH 11/44] block: remove a superflous check in blkpg_do_ioctl To: Christoph Hellwig , Jens Axboe Cc: Tejun Heo , Josef Bacik , Coly Li , Mike Snitzer , Greg Kroah-Hartman , Jan Kara , Johannes Thumshirn , dm-devel@redhat.com, Jan Kara , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20201126130422.92945-1-hch@lst.de> <20201126130422.92945-12-hch@lst.de> From: Hannes Reinecke Message-ID: Date: Fri, 27 Nov 2020 11:37:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201126130422.92945-12-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/26/20 2:03 PM, Christoph Hellwig wrote: > sector_t is now always a u64, so this check is not needed. >=20 > Signed-off-by: Christoph Hellwig > Acked-by: Tejun Heo > Reviewed-by: Jan Kara > --- > block/ioctl.c | 9 --------- > 1 file changed, 9 deletions(-) >=20 > diff --git a/block/ioctl.c b/block/ioctl.c > index 6b785181344fe1..0c09bb7a6ff35f 100644 > --- a/block/ioctl.c > +++ b/block/ioctl.c > @@ -35,15 +35,6 @@ static int blkpg_do_ioctl(struct block_device *bdev, > start =3D p.start >> SECTOR_SHIFT; > length =3D p.length >> SECTOR_SHIFT; > =20 > - /* check for fit in a hd_struct */ > - if (sizeof(sector_t) < sizeof(long long)) { > - long pstart =3D start, plength =3D length; > - > - if (pstart !=3D start || plength !=3D length || pstart < 0 || > - plength < 0 || p.pno > 65535) > - return -EINVAL; > - } > - > switch (op) { > case BLKPG_ADD_PARTITION: > /* check if partition is aligned to blocksize */ >=20 Reviewed-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg HRB 36809 (AG N=C3=BCrnberg), Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6= rffer