From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EF1BC282C6 for ; Fri, 28 Feb 2025 16:02:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79A056B007B; Fri, 28 Feb 2025 11:02:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 749696B0082; Fri, 28 Feb 2025 11:02:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5767D280001; Fri, 28 Feb 2025 11:02:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B9C426B007B for ; Fri, 28 Feb 2025 11:02:15 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6FB75C0E98 for ; Fri, 28 Feb 2025 16:02:12 +0000 (UTC) X-FDA: 83169820104.05.9332B38 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf23.hostedemail.com (Postfix) with ESMTP id CDD31140056 for ; Fri, 28 Feb 2025 16:02:03 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="dA/gARUn"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LnA4pw9v; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="dA/gARUn"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LnA4pw9v; dmarc=none; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740758524; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3iEWbleUCzV5wbSoLcpwcIdt6gqO7bzo1MnC0KnoHW8=; b=ap21elANuNFvO2E2W6nJ/D6LQ1nUbyxQekoTjCsvbX4EYUrrVjPOmdH0tc57Gwzjy+OrEv lel2vDOmkCOPz/AatZok+TRtOeLTGkN1bCy9H3Y4P3NeDbWHtzLXn63ejGPZSK9GSKEZje L/XhyG0D1wZfEwDR4A/vc4i1+NO3PWM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740758524; a=rsa-sha256; cv=none; b=H90q55//mWccH3gR8vJsTLnu6F8vHESnWfUL2gQRlkHNFlnzAFHxkaOPHu7+bXheufKi6D oXr4PQcu6B/2Hdn+tfZ6lKwS2nQY6ymt3yP+1n7KUT5HxHpIIAyBd6RGzEY2zgZ9G6+ncb tY/6HtW0q7yzM/5YMTf74xnhlAtltdM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="dA/gARUn"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LnA4pw9v; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="dA/gARUn"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LnA4pw9v; dmarc=none; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1E02621185; Fri, 28 Feb 2025 16:02:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740758521; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3iEWbleUCzV5wbSoLcpwcIdt6gqO7bzo1MnC0KnoHW8=; b=dA/gARUnQCoDd7PcFWNByEqWrflxbUIC332/POEJVnRf0Qzh5hSxAeIs1rP9aH3FLlmsWM U/TfoTuXNxbt33BDzBQmW0HUgNjq+K636xLPCrMhbd6LSo4b4HorRa3af9La5O+aaJ/PhE c5M7CnTdNJDaIhoKIAuNW0Nf3jr/j8s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740758521; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3iEWbleUCzV5wbSoLcpwcIdt6gqO7bzo1MnC0KnoHW8=; b=LnA4pw9vpTSznM7kv4Gl/OHBc6YSSmy8i/TfzvP8f+9FCSWBdCwKLwNvwi7ozHWLFBz6Vk k+SAwdqszOzIAbAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740758521; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3iEWbleUCzV5wbSoLcpwcIdt6gqO7bzo1MnC0KnoHW8=; b=dA/gARUnQCoDd7PcFWNByEqWrflxbUIC332/POEJVnRf0Qzh5hSxAeIs1rP9aH3FLlmsWM U/TfoTuXNxbt33BDzBQmW0HUgNjq+K636xLPCrMhbd6LSo4b4HorRa3af9La5O+aaJ/PhE c5M7CnTdNJDaIhoKIAuNW0Nf3jr/j8s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740758521; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3iEWbleUCzV5wbSoLcpwcIdt6gqO7bzo1MnC0KnoHW8=; b=LnA4pw9vpTSznM7kv4Gl/OHBc6YSSmy8i/TfzvP8f+9FCSWBdCwKLwNvwi7ozHWLFBz6Vk k+SAwdqszOzIAbAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EEA2A1344A; Fri, 28 Feb 2025 16:02:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id JR/oOfjdwWe3VgAAD6G6ig (envelope-from ); Fri, 28 Feb 2025 16:02:00 +0000 Message-ID: Date: Fri, 28 Feb 2025 17:02:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/2] mm: slub: Enhanced debugging in slub error Content-Language: en-US To: Harry Yoo Cc: Hyesoo Yu , janghyuck.kim@samsung.com, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250226081206.680495-1-hyesoo.yu@samsung.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CDD31140056 X-Stat-Signature: s9zuq4yjioqijwfbg9acm49wb8h1j738 X-HE-Tag: 1740758523-503623 X-HE-Meta: U2FsdGVkX19qPIjJAU4sQXVO5j8z+24to8OTWwNp4JT8R9AUCdomQXbCEiYstvNrNCwfFUxiVJzpvIJXSmAKd0A9UJ7ktZMZg5ud+7RZVK9WC9/5zcui684wNcCAEYclLtWcmiVB1hQSqraGbtwZdbAy7GL8op3FBAF5BRhp2RLh90mKWZLVrvZYQaw5QEinI820TPU3OVDtuAVpQ5atdlzMOrIT6o0yXHYWT63Hn+g2hRMYkfkvMCfhyXGh6AtLO8VmOYNeS+bKOCVfmaJ4fVnBJRBJQdGr1c1mv6taczPeRgFT+ep4VUGvjGQQGqrVFSsrMpsrX0cICdOMj+h1zKYR79TUXNVcQqG1pLCxbcNbf0Al/mpzO2z6Qs3y5jhdYi64xO4FkeE0nbs3dByXa89keKh/rXAU72t20vanuOmahcAF2xpLYQohDEZDlzkRxEgSXzLKSL2Yu6rbmar7AL6WgMEeiVK6APY+nVaXOi/SnQ2XGrVgewJOrJWPSNAsIE2aSmoc8FqUC2DHrdeOGEhhW2+Bb+SNPe4lzkvIGz0kttZIGJ8XjjEp4XmNu/krEWP/2dHMFvTDaUb7RA+/tt7Y5YFCbhPXROBFSAdRnXZjzwPWaCxfY6GpzxZ9Z31PuZzDGWVhJBN623XwSqeUDtPNI/Hlm8QDQeER2954MrrCPWYZq4sUd685Nj2cw24kxD0sw3B0V9xQpX6CMupM3atx4NndAvSYmlsL/NiRBvvkMIbSU7IDdoVrRv3iYBNA5Cqeb95Dw0sc4eEc55JHM3i4bNKsqonZJ50vCDans0+MLxaBHN5CfHu0Tlc4kWEgd4y9D7iz2YBNLkprH4xnH4iJjcbfAIqQPqoqCYD+vZ2cvUbQamaK/EXeeovGA4Qj1a+FMAM5caB/8rXNaOGmUL1khzDJlmQCMfWcU8J4zySW+hJ53PMlawPiboxcgVQglJ5dmUwoNPV6y2cHCUc kg0D/3dm xVlCGeFgz2LeWbe5LugGIQTAYwUO+L+ZfKFTN5C1OCnZbPaTMwkfAIrqQ0YqDb8YbUxmWcB2H5mns5x/JZeocwCdRPPfz9Pxm70Ekq9W0Y2n7VUWYXldNneMhItejRomtIE3MJ9IezC6OqvRQqnFAPzA9L47QgMwLiNopse5kOQU/ykXwUrQGOaKfoQCC+zf5Z6fb3XrCxSVQ+WhQ+dOwkg8K9xLQI6YT4jp2mGxnv3UYiDLbTJU3Tx1+WMVsVDn4tkrVUq4LAnZOr7cWOke0jXVO+a4THEVroHDdX2cemrQnI3Dnk43vNkRLMTP1NihcFcwd8NnfduBQE1MFf82VPDeO/pnzkKsrcMbHFOG/M2D+NFWN1Wx3S6y+PhkmezfJHgdl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/28/25 13:47, Harry Yoo wrote: > On Thu, Feb 27, 2025 at 05:26:26PM +0100, Vlastimil Babka wrote: >> ---8<--- >> From c38dadde6293cacdb91f95afc3615c22dec5830a Mon Sep 17 00:00:00 2001 >> From: Vlastimil Babka >> Date: Thu, 27 Feb 2025 16:05:46 +0100 >> Subject: [PATCH] mm, slab: cleanup slab_bug() parameters >> >> slab_err() has variadic printf arguments but instead of passing them to >> slab_bug() it does vsnprintf() to a buffer and passes %s, buf. >> >> To allow passing them directly, turn slab_bug() to __slab_bug() with a >> va_list parameter, and slab_bug() a wrapper with fmt, ... parameters. >> Then slab_err() can call __slab_bug() without the intermediate buffer. >> >> Also constify fmt everywhere, which also simplifies object_err()'s >> call to slab_bug(). >> >> Signed-off-by: Vlastimil Babka >> --- > > Looks good to me. > > FWIW, > Reviewed-by: Harry Yoo Thanks, adding to slab/for-next