From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14DBBC54E94 for ; Thu, 26 Jan 2023 09:25:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EF668E0001; Thu, 26 Jan 2023 04:25:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 99F7C6B0075; Thu, 26 Jan 2023 04:25:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83FDE8E0001; Thu, 26 Jan 2023 04:25:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 75FF16B0073 for ; Thu, 26 Jan 2023 04:25:36 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 392DE16098B for ; Thu, 26 Jan 2023 09:25:36 +0000 (UTC) X-FDA: 80396417472.10.9E228BE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id F35C91C000C for ; Thu, 26 Jan 2023 09:25:33 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jQhXjKPY; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674725134; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HJxMbaMUqhqeVp88riEJqy2L3rUVZ+LeaPKhJKipiFU=; b=PLsAvFQoeXZfYrbGzuU/AtALcuXUhpDvPr9BGGpgUz3WgXJzPtbBOBLalAAMS+xNSLhKGX ffYOVJQZ4ayd+l6sglCAwQS/5gnOgoZ/qBiCUqjytQvOufcD1ChBmu3jKvG1fw1QeS7QWm bJ5JudFc0PliLil7vKLLnk7QZY0Q1+w= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jQhXjKPY; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674725134; a=rsa-sha256; cv=none; b=nHpoBjUO58yn8OA9bHbNYGb3zRn3CuUn1Ao8tx4pfBnO1xC9DdlWY6tartBXhbHvzr1ReJ OxHLEPzsfa6QgLLche2fWQrtAXUD/vNJ94lHrsqeLn5v6o9+aDoBHeQGB7lftdD9JeDCtq XYH7hMQywIN4SwKpikBG/aMuh8pG1+A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674725133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HJxMbaMUqhqeVp88riEJqy2L3rUVZ+LeaPKhJKipiFU=; b=jQhXjKPYRzRRelPTqx2p4d1tX+3JiMHJE7q3gwtwrPZml76im3TfbV2LDzE+GFVqSeB7j5 hRuZgMINhmoT+maX5Uzgvho16mSH6fhndNU5TAIb+U8/mR0fq/2l85vSAz5FfS2VGnfE5J wtIqmwS2el8myPTSjEnw23FxaARFUb8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-496-KC2slFb8O5qPy6ZNypDxUA-1; Thu, 26 Jan 2023 04:25:31 -0500 X-MC-Unique: KC2slFb8O5qPy6ZNypDxUA-1 Received: by mail-wm1-f70.google.com with SMTP id p1-20020a05600c1d8100b003daff82f5edso742550wms.8 for ; Thu, 26 Jan 2023 01:25:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HJxMbaMUqhqeVp88riEJqy2L3rUVZ+LeaPKhJKipiFU=; b=idUlivZslUNopS5670jO3RJzw92wrkMQ4s1NN4cPGcUh5lF+U7tLbwp1qSedd2qCcO aLdiSUrNKI9J4GWZoIHmR7ARWUg49jazp8l67f91cTaMvCLP6c2MgF3VNp6uYrZr8z2o NkdKpdnw7KQxuypPbPQXYjNUWTJVtPkIdqfp5Jzne1m87REd6U/NxKCKoiR5xouW00lr BZVrb0DHZ3m2je/XYK1bFr4niOpxgIhkA6+qhmWZ97rRWsxLC98r+kF2y9ztbrBACLlz dySUrhJsgNmQn/TZF69apGjxdE67DmJMX7q7oiWAFVSxBKa0jRC2MYEhhQFUQrDgvcnL gQBQ== X-Gm-Message-State: AFqh2kqaj7gYeeZGMSKxFuugdEl6twIAiuKwhZgrHYUE9Oo7YOeSuheh zXnkHAqjcqN+r7iX7O4hlErYAtxM/kdeBlRbn1++TZCH3ty9qBf8B+PTylXDvcfjZYhsYbU37Q1 lmRBK9QT8pNI= X-Received: by 2002:a05:600c:202:b0:3da:f80d:7230 with SMTP id 2-20020a05600c020200b003daf80d7230mr34631792wmi.8.1674725130561; Thu, 26 Jan 2023 01:25:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXsF+CPq/pYLt+G2uzsh9Vpxfez30amaf1R+Ru5j+9YNhRLrWVC7in0V4m/WVq1SfZ43j3OaoQ== X-Received: by 2002:a05:600c:202:b0:3da:f80d:7230 with SMTP id 2-20020a05600c020200b003daf80d7230mr34631766wmi.8.1674725130238; Thu, 26 Jan 2023 01:25:30 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id x12-20020a05600c2d0c00b003db15b1fb3csm902990wmf.13.2023.01.26.01.25.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 01:25:29 -0800 (PST) Message-ID: Date: Thu, 26 Jan 2023 10:25:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v10 1/8] iov_iter: Define flags to qualify page extraction. To: David Howells , Al Viro , Christoph Hellwig Cc: Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard References: <20230125210657.2335748-1-dhowells@redhat.com> <20230125210657.2335748-2-dhowells@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230125210657.2335748-2-dhowells@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: F35C91C000C X-Stat-Signature: swy6gff9rniswn57gshiypyhjnst66e4 X-HE-Tag: 1674725133-653076 X-HE-Meta: U2FsdGVkX1/wRowvBoBzhVdUqOybgxaH7tZhuVujmeXKiiXAQIwP9g30dgZnE9A5Fj3RQ+Q9eBGA6dMynRdFEjoU17bx56IWr6FhPU2hp35k3PsIWiZxasxWvLSHUacEPLIE6yh0smilZ2efPnpgQZ+vogn08TPTVP5RlioSTW77au+QgEfJOHbivzYNq3hmnKGyAOtyfsw13mJn7BFQK3p4J2J1NyElqdx+SjSF36rfRsGcrURnZrEaKm/4o6XRNrtaZzuZABZE4i1nq4j0v1WDRnXPkhfwcNwrgLA0boHggbYWqH3DdeZmAvIg2H9gbSCFxttO6aEq1Vcm+/kc7E5POA2/hiyFRIYeMiQOburDqhbnR/ECXZW6JpECtHiyUdUindPkUIM/sUVyOVlqlFUMxhp50hjZfCyb+yPPUQJtVt43z8YwJyfXfTarHFO4Mo+i3U4tju2feD6ceelYeHAWSiV8jxdOdAvPUm3qcnf+UVsBNzuYB4T2D5bz7vTQWE7rpj8Qw7HliblJ8lY1SCI/rLj7iSCoDUhBvMJvLwljz9TUqop8V3OezYrc61NsPyneiqKgnKBiIPXl6GBBeHIdGPXFyU8A+kANHBiWYSd3Vqzlh68rbGd10RasK9uAiz9qwLzlnIvNPVkXxlgut71rFmtbbSh6pzGAj+oMzus62Ezx7FfgdbrFKDAtvrGU22Sm/MztuXiIhGbRcaAYnZC/klzGndcxwFvbiIiCB9kzICFi9GTQQ/BY3fzngKOdrhN0vfVQJT+ZUaaCBi86P0IdiVlgScgMdRR10KPGtj9vaP7sBExAwFPUvsK3scsJ/+/R61q+0WRkb8oBTqcrPdBIkzqT7cGurCn8d1Meubj27IN0cKFzY0qYz9CRnzQ3/VhZtzKlFVA141lPgeqAeqsg+t/KcrVcN4ccGBKHADDKfGewQJSJVkRxL3iIbDnvluZ2/JaSVX0TmgZ++RJ Y2O9wlpi WYCYRWfubK4WZnnaPwbvqN43CIw8O1yz9IdrYnghic71nRFdy3Z8ZjTTq89nvyr8L7+JscHHyy4Q+UrReAT3oOVHkgGOOZlsZw4GJ9dGolR6f/fy7E1dBQcs6Nm0IL0QWK4zSYYuzFK55LugxLKPP2rfJPG5fwfjJIXV+Jok8OsQGeTYuvmBq2ma4karU5ZV0XzO8stXCFYUClRmbIuUm90f6dQI3iFOe4yOzc7YAmBe9y6I3XTTF9S+s3+dn5gfD+iCX8zvIhdwKUgqU0ebPHLF2Z6IW2TiQ4sNlKsHTpyZNDZI8QvKkHd5KD2kDpGLA0WTd5Haw9VbbSqcT9G/lhuEWtw1H3TunTfJVw0r3IHHjcCGXMhftawASqfpF4CByE3w2Katu3fB74LPeK83h2ppbp3ppiQrLLRbiSHK0S5y2iCj6B5lwMYmx/ny9lVx1rLI2msP/IzbRmNzWLXFVRv50pG2naoByKDVRnxJDIc+snvgdhfV2vIDwNxcryRVIOt3FWmU3ZnBKWPJ6VKRZrb8CR8W4XEX1wNbThbpncnzwvB+CS/ZisPcFZe1QQGP1JoRu90Yhyl8CansoKnJrUziRMzCHaSmRnwyl9Vn/74Kh0On0t6SEkU6uODm9NfRDjbuEAg11Hm1/R090MNANCyNwvZkBKE7jQ8rcNKKhLD0P1Eo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25.01.23 22:06, David Howells wrote: > Define flags to qualify page extraction to pass into iov_iter_*_pages*() > rather than passing in FOLL_* flags. > > For now only a flag to allow peer-to-peer DMA is supported. > > Signed-off-by: David Howells > Reviewed-by: Christoph Hellwig > Reviewed-by: John Hubbard > cc: Al Viro > cc: Jens Axboe > cc: Logan Gunthorpe > cc: linux-fsdevel@vger.kernel.org > cc: linux-block@vger.kernel.org > --- > [...] > +++ b/include/linux/uio.h > @@ -252,12 +252,12 @@ void iov_iter_xarray(struct iov_iter *i, unsigned int direction, struct xarray * > loff_t start, size_t count); > ssize_t iov_iter_get_pages(struct iov_iter *i, struct page **pages, > size_t maxsize, unsigned maxpages, size_t *start, > - unsigned gup_flags); > + unsigned extraction_flags); > ssize_t iov_iter_get_pages2(struct iov_iter *i, struct page **pages, > size_t maxsize, unsigned maxpages, size_t *start); > ssize_t iov_iter_get_pages_alloc(struct iov_iter *i, > struct page ***pages, size_t maxsize, size_t *start, > - unsigned gup_flags); > + unsigned extraction_flags); > ssize_t iov_iter_get_pages_alloc2(struct iov_iter *i, struct page ***pages, > size_t maxsize, size_t *start); > int iov_iter_npages(const struct iov_iter *i, int maxpages); > @@ -360,4 +360,7 @@ static inline void iov_iter_ubuf(struct iov_iter *i, unsigned int direction, > }; > } > > +/* Flags for iov_iter_get/extract_pages*() */ > +#define ITER_ALLOW_P2PDMA 0x01 /* Allow P2PDMA on the extracted pages */ Just a note that the usage of new __bitwise types instead of "unsigned" is encouraged for flags. See rmap_t in include/linux/rmap.h as an example. Apart from that LGTM. -- Thanks, David / dhildenb