From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65E42C27C53 for ; Wed, 5 Jun 2024 14:07:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E57356B0083; Wed, 5 Jun 2024 10:07:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E084A6B0085; Wed, 5 Jun 2024 10:07:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA79D6B0089; Wed, 5 Jun 2024 10:07:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id ADA5B6B0083 for ; Wed, 5 Jun 2024 10:07:46 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5973C161492 for ; Wed, 5 Jun 2024 14:07:46 +0000 (UTC) X-FDA: 82197013332.26.8C8E6D7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 07447C0012 for ; Wed, 5 Jun 2024 14:07:43 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KqZksLxh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of bristot@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bristot@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717596464; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VEkSv/wkJy5gIacDcugoCBVPAdCY8hqPso/BOhBGtKA=; b=BTkvucXIAmgEghoIOHE2Tcgk4BUtLy4KzwJhCu0XQs7pyrXdPCODL5G/HQAwGkHgTYyeRI SXqeGGTU9t+7KUuYwrrgm16ZucFUlCOyPM+CW+6k9CwLUL4x2C9jP1+q664nL+D/hQhJEU wzdUynUpI/oseOtEsCyBzrRmIcWJHD0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KqZksLxh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of bristot@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bristot@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717596464; a=rsa-sha256; cv=none; b=duyoB/fAgoZSExpvvJ3g3sNoBVyXN5/vtPg2BRr5q9eqC9dNqhCP9+tEylS8Kpy1pD40jm gwCBcCL0jbCFYlbxPqoElSTPgRVqHadV8bEoUf01ccbkJEtIHSuI2erBBsGkOWTUdMrJEr e/9N9JCAODXei4idBRE5rRGfIjxTEt4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717596463; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VEkSv/wkJy5gIacDcugoCBVPAdCY8hqPso/BOhBGtKA=; b=KqZksLxhAvRcng5FV0rs/IV/NZGUb1ob+w97gyUov6jiUDiE0YEWn/05+JAp0c7Egw1CSW 3SPox5qVJ04Pyvt1lS6ovuOLmBOIqI/vHlpGgM/MxDQnAmk5A+Pcyo56HoT1wfJGydHHPd hPQMUKfzsKE8+51cohiRNUlvleu9eVA= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-124-LJm6ECO8OKWhYicfoHtp2w-1; Wed, 05 Jun 2024 10:07:41 -0400 X-MC-Unique: LJm6ECO8OKWhYicfoHtp2w-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-52b9267d9d6so3086269e87.2 for ; Wed, 05 Jun 2024 07:07:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717596460; x=1718201260; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VEkSv/wkJy5gIacDcugoCBVPAdCY8hqPso/BOhBGtKA=; b=ElT6NYqbr6cqbOz0Npn9hof8ofRccevdrul3eYbGW7IpTYPbn6xeT6p0hjOtZT1LHV 2w21/bEYRjZYfpYEvMyT2zCUSS6of72EraJHa3cXD2TD+cPRtvrml9V7Da/72AAN5I8d DaakjNOI+zTpx8oUuCiMMydK5NXsIPB1IoH6DRXvhb+Zj+FJCNGxohirE6ynk4DgopKC 5DZBVv2ITVE18fdrovo3qIw42cRzlZBHc29p9Ye5deE7nLyru8WsaYIxa42JpOSDYC59 +RbJ0FOJv5CjR+2B7BUaaYOkzO+6PUePKuMd5o5XJDp7GJQwp67K9GL6dWt0FoZTEQnC mTfA== X-Forwarded-Encrypted: i=1; AJvYcCVuuu3LIUfJzRS9QGJ+RWZHqzJ/KFteKADFeFv/fRfdEK1WFTjQ4Lyn5VewVF93jqokBWknOgD+SlTa9nY4p4c87jE= X-Gm-Message-State: AOJu0Yw2YZ7dww9z5VUewHfTC/ADzsjHN9/6tQY2O5n4etFCWbSK5iCz 9+4WFgDqZ8Ycxp8BMdXcxLJLGs66ahfsG4z/iPZNCJADp7CJ/Ouj2zSSw5uFuMtrbNqU+oICU3V QYrTwsYh7r/rVg9//j4bIfJ4te2CWZVzAlr10q/IJnDl/FZ8u X-Received: by 2002:a05:6512:3e1e:b0:521:cc8a:46dd with SMTP id 2adb3069b0e04-52bab4ca688mr2447047e87.11.1717596459948; Wed, 05 Jun 2024 07:07:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEWQkEGTiF2US910j6qATuYv6PWll++dJZVRQ+oWbzvMc1eD4nMBj6V7rtuZUfVx9VVE5M1nw== X-Received: by 2002:a05:6512:3e1e:b0:521:cc8a:46dd with SMTP id 2adb3069b0e04-52bab4ca688mr2447030e87.11.1717596459494; Wed, 05 Jun 2024 07:07:39 -0700 (PDT) Received: from [192.168.0.161] (host-79-23-6-148.retail.telecomitalia.it. [79.23.6.148]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a68e6b5cdf8sm559531466b.81.2024.06.05.07.07.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jun 2024 07:07:38 -0700 (PDT) Message-ID: Date: Wed, 5 Jun 2024 16:07:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/2] sched/rt: Clean up usage of rt_task() To: Qais Yousef , Sebastian Andrzej Siewior Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Steven Rostedt , Vincent Guittot , Thomas Gleixner , Alexander Viro , Christian Brauner , Andrew Morton , Jens Axboe , Metin Kaya , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, Phil Auld References: <20240604144228.1356121-1-qyousef@layalina.io> <20240604144228.1356121-2-qyousef@layalina.io> <20240605093246.4h0kCR67@linutronix.de> <20240605132454.cjo4sjtybaeyeuze@airbuntu> From: Daniel Bristot de Oliveira In-Reply-To: <20240605132454.cjo4sjtybaeyeuze@airbuntu> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US, pt-BR, it-IT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 07447C0012 X-Stat-Signature: fr3jdbin1qsnig6kxfj139tz1btwpb83 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1717596463-638300 X-HE-Meta: U2FsdGVkX18n8ftd30YIUIZ68Epzb+wnl+ydIhqXTB7GMTntT0b1Gb2gcY6Hi9p8nl9WMvuat4TInzViDsgt0IjfAlfIiwRi9OuIuVxsu6Kj+8KeWQBtNcbl+gkX+QRw96EPilM7RFkDQsMp7tooQA+ZLNQrbPaCi4PNu1XWPVJ0sBmubVfrfUlRefuy0kcicnMCUHD1ohZ3UZbVXpzAWR1jZsfLKRsNF1HvtIH21F/jfrlYtBW3IHjhwG1DavlxoYwxkqonTnynIsx47Fn3JufK534bJtUuecL4rA16pgK5nsMDVkc30Jz3Ev1zA5DFQEw2Z7maFHxYdZWlsBehsQQ8Xxz68OTzKsjiPL2LLREpCna0DWrFt0Nrc+gor2adcPXiSlb6fTCh+Ty3tWVoUM2WRbej7XpfOulLP7gLBv1f27dqKUVB3n8wxomSB0bAp/PU4LC/btcCzZByTXOhbAPDXyzMa7JV+FrGUH5S9uicIqwjS5hAamkO6YIrO92Jc+QmKID9MUHKTwUY2UF/U/A4KgxttrCm7oVTTCTbWDWRacAOiZVa8Hh6xOfkTXkw+kUFMIh9up91fm61uvK1CYgdyLr5Lwc9r3I/qp+mev0HhNSr1HtfRy1ifo3iB4meaHSa7TSfjEyourZvJYBHaCvW7LYli1T+RZCKm3irl9QflYbcxaWuLSDhZvbvJmuIFHn7R/3GSdgbbsz8pZrM8d9LbvBBtKOOXgTdmbLG+cAV2nFAKCX4I5yG67zxUtjvP1dsUcsjIVGlhRj45Anvtac0OTTPKIn3XcDmp3UTNfXL7P+5A2mJS+W0SO0zjtbWqJQsK1HYj2A7loIARdjVrMx1WBIFozZ4Sqpo22qCbR6oaRnrQsrXQAlwp9WUSkrv5nOu8o7INEGo1CQH0pFZYyt1zyg4qC6C2fnM1rvZG/SW6fGTIvDE//Jh8wFh0LSlA2OnNqM9bHmlfVrVzPf UGtEkmxH 546b+txDlWtVSl5jQUPTnV97fWAbnKFymvW5UMGd+wECmSGKni2lX0I5pCqhYyaBU2f5VW8xzuKbcmNT49C3DqQAIlMeXiM/nZrCCfBsIyJjVg99Un+jxQwbj1nhbMK+YQ16N4MgpvrN7R59Ykt+yIsJUxdzWZj5JAxuQUotPKHiuKLkb0LA1lUFjGzZQP5A5FvUVdRzsmW7vxnPMuAAvaiDTKkMd1Yz8/ZmRtjPNY+vHy+eJu0nVyzPQ7j/dcL6yZLjJcV/jGTheXj7i/ckl72S5lt74M73+SisowR/UOOIwuVUiE4Sl0kpYlLROjn8FusGLgey9qbUKmKbrTi76aH3cZf1SsfZkebOpYVNmNQ+jJwfM+wYDY9Jka8nLJDzC9E7iPE9ZbdlFPcVtvnGnerq+U+XRWBRZLPJu6IL4M5jH+mP57hJnA5Blj/T85HaEs1CapKO5/AhJ1By9CYu+WpzWHOwoMSeDnoRTgszeNh421F3y1mWLjjwsaw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000019, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/5/24 15:24, Qais Yousef wrote: >>> But rt is a shortened version of realtime, and so it is making *it less* >>> clear that we also have DL here. >> Can SCHED_DL be considered a real-time scheduling class as in opposite >> to SCHED_BATCH for instance? Due to its requirements it fits for a real >> time scheduling class, right? >> And RT (as in real time) already includes SCHED_RR and SCHED_FIFO. > Yeah I think the usage of realtime to cover both makes sense. I followed your > precedence with task_is_realtime(). > > Anyway. If people really find this confusing, what would make sense is to split > them and ask users to call rt_task() and dl_task() explicitly without this > wrapper. I personally like it better with the wrapper. But happy to follow the > crowd. For me, doing dl_ things it is better to keep them separate, so I can easily search for dl_ specific checks. rt_or_dl_task(p); would also make it clear that we have both. -- Daniel