From: Dennis Zhou <dennis@kernel.org>
To: Joonwon Kang <joonwonkang@google.com>
Cc: dennis@kernel.org, tj@kernel.org, cl@gentwo.org,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, dodam@google.com
Subject: Re: [PATCH v3 1/3] percpu: Fix wrong chunk hints update
Date: Tue, 21 Apr 2026 16:26:24 -0700 [thread overview]
Message-ID: <aegHoF2_GE3hL4cv@palisades.local> (raw)
In-Reply-To: <20260410174417.1450834-1-joonwonkang@google.com>
Hello,
On Fri, Apr 10, 2026 at 05:44:15PM +0000, Joonwon Kang wrote:
> Chunk end offset was set to a block end offset, which could prevent
> chunk hints from being updated correctly. It was observed that the chunk
> free size gets minus or shorter than the actual free size due to this.
> This commit fixes it.
>
> Signed-off-by: Joonwon Kang <joonwonkang@google.com>
> ---
> v3: Initial version.
>
> mm/percpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/percpu.c b/mm/percpu.c
> index 81462ce5866e..3ecd86096641 100644
> --- a/mm/percpu.c
> +++ b/mm/percpu.c
> @@ -1054,7 +1054,7 @@ static void pcpu_block_update_hint_free(struct pcpu_chunk *chunk, int bit_off,
> else
> pcpu_block_update(&chunk->chunk_md,
> pcpu_block_off_to_off(s_index, start),
> - end);
> + pcpu_block_off_to_off(e_index, end));
> }
This needs a fixes tag for:
Fixes: 92c14cab4326 ("percpu: convert chunk hints to be based on pcpu_block_md")
Reviewed-by: Dennis Zhou <dennis@kernel.org>
Thanks,
Dennis
>
> /**
> --
> 2.53.0.1213.gd9a14994de-goog
>
prev parent reply other threads:[~2026-04-21 23:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 17:44 Joonwon Kang
2026-04-10 17:44 ` [PATCH v3 2/3] percpu: Do not trust hint starts when they are not set Joonwon Kang
2026-04-21 23:28 ` Dennis Zhou
2026-04-10 17:44 ` [PATCH v3 3/3] percpu: Fix hint invariant breakage Joonwon Kang
2026-04-22 0:04 ` Dennis Zhou
2026-04-21 23:26 ` Dennis Zhou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aegHoF2_GE3hL4cv@palisades.local \
--to=dennis@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=dodam@google.com \
--cc=joonwonkang@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox