From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22517C5320E for ; Sun, 25 Aug 2024 23:14:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 493528D0035; Sun, 25 Aug 2024 19:14:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 440508D0029; Sun, 25 Aug 2024 19:14:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E06C8D0035; Sun, 25 Aug 2024 19:14:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0F1038D0029 for ; Sun, 25 Aug 2024 19:14:26 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 56536809C6 for ; Sun, 25 Aug 2024 23:14:25 +0000 (UTC) X-FDA: 82492323690.10.D48ED4D Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf13.hostedemail.com (Postfix) with ESMTP id 7925120014 for ; Sun, 25 Aug 2024 23:14:21 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=HWgrKtO+; spf=pass (imf13.hostedemail.com: domain of hughd@google.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724627594; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mC6ZNidx5P90YPf8uENc5nx+UFKunBsUReK2aoP9rHQ=; b=iMaydbiYtrWDXhL1BTHNCiSh21aczRy+ZYcM3glgJsVfWjoBADXFj4KpJ+9lnkUwDDZMZi fvd525LLXYIQR6SZz62YPUi86FlECpyF79KtxXAJG2ifhHuODJnf6Mod19WW6nFHjT6AGs nJVWm+7x5ZVRiycsjJaRfh5Epr0oRJs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=HWgrKtO+; spf=pass (imf13.hostedemail.com: domain of hughd@google.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724627594; a=rsa-sha256; cv=none; b=BcqprKDTMuf4VpT9LgupI6vizvoT1kMiUxu4gejqYP/9PbGB89Tvm8qGSZlPEgaZg3MVQc SZuU7jzZOwLOmgBdbkiItPv/bP/m4UN4WA79tOrHddKqioDokJTlIZjE2i8K8wMdemhjPd 6aFpVm89r6Lrl7+ovkaQaHIhuJ1dTxo= Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-7142e002aceso2956400b3a.2 for ; Sun, 25 Aug 2024 16:14:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1724627660; x=1725232460; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=mC6ZNidx5P90YPf8uENc5nx+UFKunBsUReK2aoP9rHQ=; b=HWgrKtO+6OmPYRJ7S32+8WzigOoPtUuCbWjg2QQBXkmLPOtIZp/sc87i/idIWxZqk1 R5V9zeuiMlTkbOYqJjWyUV0CJBsi1A6iJIWpMYQkJGwr2efBCd80nsTZ1vhe1hMkPt8g LHjTk+riJJbJVDSDrZFPwQ6PeWzdOrELlkppweCg91rrGFCxDOPbaGtjN2Ic2eq/cS1V 59YsmQIhK0swc5vpwgFJH7KFHAiB6e5yCb3Y8RJyNXwBiDhMjnMKQSjcrKtIqZ6XetGH 55YJnGxpm54KmzRNzeJNyP2ZHP9L8+eZ0S+ovWhqul+R+uvFHXY3mGok8gUnf57sAa8y NlSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724627660; x=1725232460; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mC6ZNidx5P90YPf8uENc5nx+UFKunBsUReK2aoP9rHQ=; b=cauGiZdGNV0S/aNo6N9v3ISA8gdlqiN/HDYd7EXvyEjgA56dUcECOQPgXD7bZiEk8D 6SoDP9vR7FkL739E+bGKSUUv+pKOFwKMYqHrMWUI0YKM10OrHRjzq9E82COq5fi8hhpJ n87+VeeKJ1Wp+lY9h5qGhj7aVw6tXadMfrZg+45cM9XzDzbpu1K7yfUjRlZi3TIX/3aL cztEYx4+hw/ptjBi9DgINMlTpUOkAQHRLHSPUJnZkmkKU0H4nPxeB70rDrQs6+k6tye9 PzIGtKX1svHS4Kge/qHFFZcSzurap/2hGaKnnH4buaGLkBakchd1GiIFXjhwS4I91egV GoCw== X-Forwarded-Encrypted: i=1; AJvYcCVkNm5g+ZoIybDYtgQ63oeFOo9DdJEDLTDghidU6VTMS3cDKJklePw7M3dvSWZ1O/cQFWJtqSXDSg==@kvack.org X-Gm-Message-State: AOJu0YyqtGjsb6k7Ec4bpMSnWsPVSY/kHaGsgiUpaj1i+aiRH2TkYLFV K0szj9RvWak+oGY1ZOHkEmOFinp5nAFC0EMGLgrr753tWsg+LxBaF4qMaA/qyg== X-Google-Smtp-Source: AGHT+IGE9+OJfYdLhUWe3+YNVm5Vr+YvsjwDj/HUN/vjjDjaiK8QWqY92RdQvJI/j2XrPJlIyd5xhQ== X-Received: by 2002:a05:6a00:1ace:b0:70e:a42e:3417 with SMTP id d2e1a72fcca58-7144578e8d4mr7657363b3a.10.1724627659635; Sun, 25 Aug 2024 16:14:19 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7143430cc6fsm6259418b3a.177.2024.08.25.16.14.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Aug 2024 16:14:18 -0700 (PDT) Date: Sun, 25 Aug 2024 16:14:17 -0700 (PDT) From: Hugh Dickins To: Andrew Morton , Baolin Wang cc: hughd@google.com, willy@infradead.org, david@redhat.com, wangkefeng.wang@huawei.com, chrisl@kernel.org, ying.huang@intel.com, 21cnbao@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com, ioworker0@gmail.com, da.gomez@samsung.com, p.raghav@samsung.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 9/9] mm: shmem: support large folio swap out In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Stat-Signature: dpz77fcp89ox61c7mpbgaguxcmkqg14y X-Rspam-User: X-Rspamd-Queue-Id: 7925120014 X-Rspamd-Server: rspam02 X-HE-Tag: 1724627661-958842 X-HE-Meta: U2FsdGVkX19LKaarhjRZv6zlEnKpZcsYyIKrByk23HqWoZIGGDY6BF8kqhBcJSIdfPrIKUxL+SvMwRXp2ENee+o/8Pp3n7CjN+yLRwzFKHcJfAiz5PYkWB6hB4YcjpFs6OQEPbGzuw80iQmNj6Sh1IlEWwcBTNnd952B7+G9LHowr7YZ/8IhSM/KtvIIc0oMqc2MA43pOq309Na5zbVnNl23wLBlD/19b9IZxlnJPyx2b3SlwZZ71m5UYNyNzSOvT1QDQRzQ3NfACUPkJ2euLCDVNCAiujD73wAuAkZk4QsBk4QQFVYdNUBiJN++8q5hRdXZaGG2I8x3g9kI5C7SNBrKjDrLs/FNbnvDqaHk0yiMQMWkNopARkTRPU6YjskpIWubhROFHqFTVBh+d4Htye/zVbz+4q1V2CY0qNLbuYHurdBlJJ+QDKM2mzdYZZEwhY70lYCvEdqvR8ikMLSgMt2+kc7ofpL97EzLByqijiq8220mN3jNJmGISMPY072Zt4yWOchh3k1iZvCL/jqUw+0FE6PwCIdX6rHy0Iy7oG4BFFYOEGipndlKPxDRdp7qNwKgtgBjwixkZl3HgC1MG/w2SRiEoy2mpYmNQAxmsArYY0Ya31PtTfWnMDIyAkdqE/THx9D+J1+un3mcTM6tKNF/6IicWpZzlTZWSumOBF8vyuQ4u6a36FsyoLk1rDNwfeoMX9hjQrSFW533Gg7DGNbT3SheTEyo91MGJal0aWS9AT8GaVbXtwA3vEjgWFZ3utzDDZw2xpZgvqant2q/kyQnAcfg3l1TAO/d5Cel8WJnpMjpyMOkSCb+XzXQWCXtxy/YiqyfNV/CbPFpp3hl0emnH9sKk1Q3Yj7MLIP8HTjALnOouE08uwnXnVP1VJtM9QEOG9ztXZJoEsJ0CX6aUaU6tYe2ts18y/njBGzytCj8OzlDM7p/lLtKbqLHQ4VLEL5Mqxk380qNcV98tlw KbjeJPxh BK5SOr90zQVUTDzj/GFeKggmEvuhWeUB5PYGESqkN7NL98vBVZX2sqsD3TcmE3vUOQcZO6mzu+AWeYt71UYFT6GzrbPWA2GLOayQCLjx0RJcFNm8wvzMUaJWzYbgyptokX965vmxBmBOPqGNpU2yloIiEAEQX522Znr3SZ3WggmkLekpvO8uG/4F68kPcXibqIecVA6NN7bBX2HPlBaUvKOW7VocjnunL37Dv5w85s9kHWs9hYenNKCjlnhKL9FcxeL+m3zyIvcfOFl8HcpirEICXubBzaWmvpj05zyU8lXygTAfsTUFv3TPIKZIENNBIYgIz9x4T5ra/qmNcSpdu+XBGNAQDZ5AwK5rWvXq+uMWbioApJ2nRuFMmJgLL/nTSLs6t6jgX+Qr1KReYyzaBG+dKxjqU3C/TH8hnOw2zR6OpTmDUg7YJzCS/Yw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 12 Aug 2024, Baolin Wang wrote: > Shmem will support large folio allocation [1] [2] to get a better performance, > however, the memory reclaim still splits the precious large folios when trying > to swap out shmem, which may lead to the memory fragmentation issue and can not > take advantage of the large folio for shmeme. > > Moreover, the swap code already supports for swapping out large folio without > split, hence this patch set supports the large folio swap out for shmem. > > Note the i915_gem_shmem driver still need to be split when swapping, thus > add a new flag 'split_large_folio' for writeback_control to indicate spliting > the large folio. Is that last paragraph a misunderstanding? The i915 THP splitting in shmem_writepage() was to avoid mm VM_BUG_ONs and crashes when shmem.c did not support huge page swapout: but now you are enabling that support, and such VM_BUG_ONs and crashes are gone (so far as I can see: and this is written on a laptop using the i915 driver). I cannot think of why i915 itself would care how mm implements swapout (beyond enjoying faster): I think all the wbc->split_large_folio you introduce here should be reverted. But you may know better! I do need a further change to shmem_writepage() here: see fixup patch below: that's written to apply on top of this 9/9, but I'd be glad to see a replacement with wbc->split_large_folio gone, and just one !IS_ENABLED(CONFIG_THP_SWAP) instead. > > [1] https://lore.kernel.org/all/cover.1717495894.git.baolin.wang@linux.alibaba.com/ > [2] https://lore.kernel.org/all/20240515055719.32577-1-da.gomez@samsung.com/ I get "Not found" for that [2] link. > Signed-off-by: Baolin Wang > --- > drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 1 + > include/linux/writeback.h | 4 +++ > mm/shmem.c | 12 ++++++--- > mm/vmscan.c | 32 ++++++++++++++++++----- > 4 files changed, 38 insertions(+), 11 deletions(-) [PATCH] mm: shmem: shmem_writepage() split folio at EOF before swapout Working in a constrained (size= or nr_blocks=) huge=always tmpfs relies on swapout to split a large folio at EOF, to trim off its excess before hitting premature ENOSPC: shmem_unused_huge_shrink() contains no code to handle splitting huge swap blocks, and nobody would want that to be added. Signed-off-by: Hugh Dickins --- mm/shmem.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/mm/shmem.c b/mm/shmem.c index 37c300f69baf..4dd0570962fa 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -1459,6 +1459,7 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc) swp_entry_t swap; pgoff_t index; int nr_pages; + bool split = false; /* * Our capabilities prevent regular writeback or sync from ever calling @@ -1480,8 +1481,20 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc) * If /sys/kernel/mm/transparent_hugepage/shmem_enabled is "always" or * "force", drivers/gpu/drm/i915/gem/i915_gem_shmem.c gets huge pages, * and its shmem_writeback() needs them to be split when swapping. + * + * And shrinkage of pages beyond i_size does not split swap, so + * swapout of a large folio crossing i_size needs to split too + * (unless fallocate has been used to preallocate beyond EOF). */ - if (wbc->split_large_folio && folio_test_large(folio)) { + if (folio_test_large(folio)) { + split = wbc->split_large_folio; + index = shmem_fallocend(inode, + DIV_ROUND_UP(i_size_read(inode), PAGE_SIZE)); + if (index > folio->index && index < folio_next_index(folio)) + split = true; + } + + if (split) { try_split: /* Ensure the subpages are still dirty */ folio_test_set_dirty(folio); -- 2.35.3