From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A054C5AD49 for ; Fri, 30 May 2025 19:39:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B89B26B016F; Fri, 30 May 2025 15:39:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3A066B019F; Fri, 30 May 2025 15:39:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A015C6B0181; Fri, 30 May 2025 15:39:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 852B66B019F for ; Fri, 30 May 2025 15:39:29 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 236A68133C for ; Fri, 30 May 2025 19:39:29 +0000 (UTC) X-FDA: 83500588458.05.822CCB1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id AF2A9C0014 for ; Fri, 30 May 2025 19:39:26 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=G2T2LCfQ; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748633966; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lIabL3vEkgIL5Dyr5QMabwv+NPEZiHAnsVINWI95GsE=; b=pORX+xDqiIhIXv2MOtZGdFqPfO1K1KAEb4osyM8JmTVn26PCsC0jlgBPdSgrS1X5crRx40 42t07z42vocF2TjYYHforp6NBbwsfjrIr9YkXdkQ++S5l4cVTzxSj9bL88fZ4CdxZTZROO wW/zRIe6+NZbfGZ7Zwc7ior6O/FGZ/w= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=G2T2LCfQ; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748633966; a=rsa-sha256; cv=none; b=bqQXWAlhC5Mrh8DrUGIhieReUqpcx7A1Cr90a4wWZlgMIH+gzJWl1dLJD95cVVsVctpqC0 Bazac4cA1rPJinexEHN9lZOEjEFSHT6CCunPH6vHa3vt2lep4Evr0i9VQBrOjLc4JGe1LG eXpv1HRbfw5VtqEsE96Pa/nEhcjbAMk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748633966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lIabL3vEkgIL5Dyr5QMabwv+NPEZiHAnsVINWI95GsE=; b=G2T2LCfQp40ptsN9Jy63FNpcdAbcEKw9U2NJI3lVqxJhm42SrtQP6DxgQTv0Ce8mH7jrOw s48E+7sN0L9cD4fZnocvFw8OVy1OLk5hvz1v8jbH3eriOZL/IbK4bVyGvAyuZ95F96pv75 9MPMjos6ocv6fRxLlMB0PfJAffdPiBQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-513-9FySshEoMUiJijRl2OegGg-1; Fri, 30 May 2025 15:39:22 -0400 X-MC-Unique: 9FySshEoMUiJijRl2OegGg-1 X-Mimecast-MFC-AGG-ID: 9FySshEoMUiJijRl2OegGg_1748633962 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-445135eb689so12001695e9.2 for ; Fri, 30 May 2025 12:39:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748633961; x=1749238761; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=lIabL3vEkgIL5Dyr5QMabwv+NPEZiHAnsVINWI95GsE=; b=L76MzIRBewq5Y5oau2FKTu41Bwrg9iF+XzNxNSlX17PbPruyR7JUdy3i0Gqp5T6Qc8 NQwVJn0L64BRUmYKswDLX0KSkyVj2vPT+mYzJywb4J+AGxoRsCZsBWBqmrvuQmWetS39 /J9CI+ctwpGfIhzKf4LX9MVulEKXJ6Ajlu/xDHdCtG6Wfd6OlNA6PfSf3Lc5FDEiDiRM oJVz7yh0ukl4/2PEqZ8ID0VoRfu5SMLRvMlFfaILCYxR0ZwjLP/YVnsnbgHen3pRj7L5 Wf+pe4pb+KegxuFOOB/FQBUZK9KBytpuAt2epZgr6924TigDx3giraQ4jVvzib4OuWwn 0/Kw== X-Forwarded-Encrypted: i=1; AJvYcCW4xKz1s4EXvtw2ml+OqBNGtrTHLvYTxLMtyH4ZRjomRgMJjguQVhqJRq4ggp55EKzGEETw1hzcgw==@kvack.org X-Gm-Message-State: AOJu0YxaLURCyz5UWMEjXUbN79FiF57VG/4sL6y4Yz+X72YGCTTH9QqL aiDOGAWO6+CkxqKvSrh6JDokBqveOk3wOmi1fDC0LJX1hX5eeAp9yYsyDQSro+eb59aUqKSJZoo 8uJhvsyx/XgVUG66kQd0yb7HEUJ0J3r5UciMGR4stmkg9mzT9698s X-Gm-Gg: ASbGncu3vSwlkUcFIsUt8Z/mu34kQoiUkRQqk1xTqwIz4KTwbk5l2wnPfC/ai8bqmnP GClKCPadm9NX0OHvFO5PYrR1pP86srC54dG3MCOlw95dR0HmliWUhFndtvu15L17gnSMDmrRZD3 JQLcXMdzRwgCSy4oZtRa06LOLsLkdvPaYQgOxrGUaCGOgHYgkOy0XVqvnpQYye24elGLH8vpleV BZZIs6oHLhhwstk0PpwWB3FJYSR4uSNLW7FccC03Jez/9GKoc/EfQSqpk4aMxCDnO1JUSW2imKa 5lvS45+NVarJRofbflIQmv/N8h8RxSmcT4f0QOh++oQ+tWBFHtfPa93dQNIMlKbCHZZsyg4roFR NwyVAqyp3OSeNlWuUVlr4Mkdn7IGwMAMt9kKw6/o= X-Received: by 2002:a05:600c:3542:b0:43c:e478:889 with SMTP id 5b1f17b1804b1-450d64366a0mr53556745e9.0.1748633961540; Fri, 30 May 2025 12:39:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEgq89WeQiPiCMhAPglEQ7uNw/fd0bua3PxzcgOvnqtxRbd/XfW8IAkkolRjIpVxxdn5rqb3A== X-Received: by 2002:a05:600c:3542:b0:43c:e478:889 with SMTP id 5b1f17b1804b1-450d64366a0mr53556605e9.0.1748633961204; Fri, 30 May 2025 12:39:21 -0700 (PDT) Received: from ?IPV6:2003:d8:2f03:5b00:f549:a879:b2d3:73ee? (p200300d82f035b00f549a879b2d373ee.dip0.t-ipconnect.de. [2003:d8:2f03:5b00:f549:a879:b2d3:73ee]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7fb0654sm26183855e9.21.2025.05.30.12.39.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 May 2025 12:39:20 -0700 (PDT) Message-ID: Date: Fri, 30 May 2025 21:39:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/6] mm/page_alloc: pageblock flags functions clean up. To: Zi Yan , Johannes Weiner , Vlastimil Babka , linux-mm@kvack.org Cc: Andrew Morton , Oscar Salvador , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , linux-kernel@vger.kernel.org References: <20250530162227.715551-1-ziy@nvidia.com> <20250530162227.715551-2-ziy@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250530162227.715551-2-ziy@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: GuNGvVeHvcmacD2erFcmlXleKg6vyUkVMOfyZSCUggw_1748633962 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AF2A9C0014 X-Stat-Signature: so76d7tiz8j7ydiiibjs13bjd4z3d46a X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1748633966-663716 X-HE-Meta: U2FsdGVkX1/aMfOYJUtVN5IDJVqFgGmabuz2OgA9w5BhFdJqbTP/LSUonwo2Xdsl0czOLDf2yBz+aezFE7J5t0E9BsHVobNXpZEXneuwbvOvg7vmZDoZ8RqeTzTGPgbQyq3BtcAyPBa+72XynytYIKFUFoAcIyeu43AMA1s5GgSyOvCiR2ZpdxR5WmbACQ0iVo51SO2F5NX82DxNkpGHa1R/iVp6ThIKX28sULyhskNam8tMy+wy79VXkdca5T4PZeTmISsoETEhdf94YHrCuA8Ffs+7ZdUPdX4InCswvo/1jhPaK/fQd6NMSw4yUSsKE3UejwglFfIq+n7gv0sLlKQOgEQR42TxjYVWki9OR6vGA0yoAdthqIPFvIGLoNKia7MVuWNgaDI3dxTHz7lwcoOiBsWQabS4jcFJ+hStzI3uOiu71tvdz+ZXzUFeq4SvRSZi6wiB3sh3eDTHnsUl4JLroWmqwMiLn6vQkzZCax6AfYLyhS4Dj6W3jD6jXD8SKMh/N9zPxCILx2N0c0WpoQ6VCsRI9gAGNsZJuyP+JdbRylaheM76hpbxfwzfq2U/js36CN2ZNPHFc9XsQOOlbPQB0SlYk/UQE6D8Odc4/hLOmHD1zs+jS0P+E38bUPevW9jtXAP6RojHipeGd92ezZYA9nlTM3FWQdQ3ultOW6RmcBw8c/v2vQ7pOEj+us6u8uqG8GvHZGapjAI+KU5YTt1wdfWCwCuW3VUj8Is1Ynh7zW15ISvep4dOgpom/2Hyi76oxKVR0GNfIS4GhrkREN3ePLTYcnuu1F4r+QvcA/TvjXnviaO4GYBMPsb8BVolpEdisWbJifJWVRUnH45g/exg1asOxcwk9VfQSASVSa90RauHYcJdgz0b26/sAFo57j36kk04WtkXlnpUYPiQu788wEWUDvDtzP2m86zxPIy0nLVub/02yg71Gwv89sCGPIZxAglbXJKPfrh2x9B 1vJMB1gE hkJy4j+FP159bN41g9wJqWeD23hdOmDyW/wmrl/zywPCuzjH6Jce9LNwEFcsJgW1i8pn3iZOUml0IR233zsnjYPUpXs+u1aXrAYStoHksXBcGASwo+HBEIUq9bjYMcwyixaNQzxwPRUI1Hdu4MXUWkiNMpTm445LsXq70fs872aMgc09Cz4lOHrNxETNb7Xs3Z1Yclikrlv8U7HPd2otKdE+2QqjW8NjqrnhKuvqVBSS//c58V7cFBm+dmzZam4HiziqhubqHZVeOr6BgA7SPRUfBNTs0v+LfM5Z5E83JZElapD3TCc2l7bvg6SHBshslp+p1OLGrG5B2I5qrmIy3/p/oPmJSUqSiev+2wrlCZQh2cGTGrwGD8g3e3H6zYrBQI4ypcoRQTGOyJpXiZgUJe7J7hbeKVLkr91lW8hnlyVhfp2/J6xjoFmsMRrCANuMJeNz7HlVlb7jfTRt+aRJJ07Mxhu3LRG9yijR2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.05.25 18:22, Zi Yan wrote: > No functional change is intended. > > 1. Add __NR_PAGEBLOCK_BITS for the number of pageblock flag bits and use > roundup_pow_of_two(__NR_PAGEBLOCK_BITS) as NR_PAGEBLOCK_BITS to take > right amount of bits for pageblock flags. > 2. Rename PB_migrate_skip to PB_compact_skip. > 3. Add {get,set,clear}_pfnblock_bit() to operate one a standalone bit, > like PB_compact_skip. > 3. Make {get,set}_pfnblock_flags_mask() internal functions and use > {get,set}_pfnblock_migratetype() for pageblock migratetype operations. > 4. Move pageblock flags common code to get_pfnblock_bitmap_bitidx(). > 3. Use MIGRATETYPE_MASK to get the migratetype of a pageblock from its > flags. > 4. Use PB_migrate_end in the definition of MIGRATETYPE_MASK instead of > PB_migrate_bits. > 5. Add a comment on is_migrate_cma_folio() to prevent one from changing it > to use get_pageblock_migratetype() and causing issues. > I would have further split this up. If your patch description is a list, it's usually a good indication that each item should be a separate patch. In any case, nothing jumped at me Acked-by: David Hildenbrand -- Cheers, David / dhildenb