From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F3AAC352A4 for ; Mon, 10 Feb 2020 06:38:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 26ED220661 for ; Mon, 10 Feb 2020 06:38:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="hyJXfLyz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26ED220661 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 76C0D6B00C4; Mon, 10 Feb 2020 01:38:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7261C6B00C5; Mon, 10 Feb 2020 01:38:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BC746B00C6; Mon, 10 Feb 2020 01:38:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0148.hostedemail.com [216.40.44.148]) by kanga.kvack.org (Postfix) with ESMTP id 3D14A6B00C4 for ; Mon, 10 Feb 2020 01:38:42 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D18CE2DFD for ; Mon, 10 Feb 2020 06:38:41 +0000 (UTC) X-FDA: 76473264042.30.tax72_68f3fc9f34b02 X-HE-Tag: tax72_68f3fc9f34b02 X-Filterd-Recvd-Size: 9209 Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Mon, 10 Feb 2020 06:38:41 +0000 (UTC) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 48GGSp6xPcz9v6Qj; Mon, 10 Feb 2020 07:38:34 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=hyJXfLyz; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id lP5nFoCOeJ0O; Mon, 10 Feb 2020 07:38:34 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 48GGSp5WVrz9v6Qf; Mon, 10 Feb 2020 07:38:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1581316714; bh=QRzas1fZigqnkrSjTqya1YCcaGfNLb8m3VuKn06OMpA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=hyJXfLyzy/TLklCLENXq89zv9wVhRAXkVSJxmVsiKt5cwL4ZNIKCwTX+m5MjEo+rY cRq+45YU5HPeRMZhr+for1qqR3wXo1E9N+caVapZq1mXb7xqR+2wS9n6PtM17fE2zm OW5sy45B0slszzQ4iyozvaskDtstDWZXwqUj1cuI= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 3A3F58B7A0; Mon, 10 Feb 2020 07:38:39 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id v_o7f6SBT7LH; Mon, 10 Feb 2020 07:38:39 +0100 (CET) Received: from [172.25.230.102] (unknown [172.25.230.102]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 964F68B798; Mon, 10 Feb 2020 07:38:38 +0100 (CET) Subject: Re: [PATCH V13] mm/debug: Add tests validating architecture page table helpers To: Anshuman Khandual , Andrew Morton Cc: kbuild test robot , kbuild-all@lists.01.org, linux-mm@kvack.org, Vlastimil Babka , Greg Kroah-Hartman , Thomas Gleixner , Mike Rapoport , Jason Gunthorpe , Dan Williams , Peter Zijlstra , Michal Hocko , Mark Rutland , Mark Brown , Steven Price , Ard Biesheuvel , Masahiro Yamada , Kees Cook , Tetsuo Handa , Matthew Wilcox , Dave Hansen , Russell King - ARM Linux , Michael Ellerman , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , "David S. Miller" , Vineet Gupta , James Hogan , Paul Burton , Ralf Baechle , "Kirill A . Shutemov" , Gerald Schaefer , Ingo Molnar , Richard Henderson , Ivan Kokshaysky , Matt Turner , Mark Salter , Aurelien Jacquiot , Yoshinori Sato , Brian Cain , Geert Uytterhoeven , Michal Simek , Paul Walmsley , Palmer Dabbelt , Guan Xuetao , Chris Zankel , Max Filippov , Qian Cai , linux-alpha@vger.kernel.org, linux-c6x-dev@linux-c6x.org, uclinux-h8-devel@lists.sourceforge.jp, linux-hexagon@vger.kernel.org, linux-m68k@vger.kernel.org, linux-riscv@lists.infradead.org, linux-xtensa@linux-xtensa.org, linux-snps-arc@lists.infradead.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org References: <1580897674-16456-1-git-send-email-anshuman.khandual@arm.com> <202002060619.wEOdAZU1%lkp@intel.com> <78d3ce6b-e100-2561-6b09-124c29731d1a@arm.com> <20200209205231.44d098f8749e88190b8ba10c@linux-foundation.org> <955229f7-f161-f720-0e75-a3163f63817d@arm.com> From: Christophe Leroy Message-ID: Date: Mon, 10 Feb 2020 07:38:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <955229f7-f161-f720-0e75-a3163f63817d@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le 10/02/2020 =C3=A0 06:35, Anshuman Khandual a =C3=A9crit=C2=A0: >=20 >=20 > On 02/10/2020 10:22 AM, Andrew Morton wrote: >> On Thu, 6 Feb 2020 13:49:35 +0530 Anshuman Khandual wrote: >> >>> >>> On 02/06/2020 04:40 AM, kbuild test robot wrote: >>>> Hi Anshuman, >>>> >>>> Thank you for the patch! Yet something to improve: >>>> >>>> [auto build test ERROR on powerpc/next] >>>> [also build test ERROR on s390/features linus/master arc/for-next v5= .5] >>>> [cannot apply to mmotm/master tip/x86/core arm64/for-next/core next-= 20200205] >>>> [if your patch is applied to the wrong git tree, please drop us a no= te to help >>>> improve the system. BTW, we also suggest to use '--base' option to s= pecify the >>>> base tree in git format-patch, please see https://stackoverflow.com/= a/37406982] >>>> >>>> url: https://github.com/0day-ci/linux/commits/Anshuman-Khandual/m= m-debug-Add-tests-validating-architecture-page-table-helpers/20200205-215= 507 >>>> base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linu= x.git next >>>> config: ia64-allmodconfig (attached as .config) >>>> compiler: ia64-linux-gcc (GCC) 7.5.0 >>>> reproduce: >>>> wget https://raw.githubusercontent.com/intel/lkp-tests/mast= er/sbin/make.cross -O ~/bin/make.cross >>>> chmod +x ~/bin/make.cross >>>> # save the attached .config to linux build tree >>>> GCC_VERSION=3D7.5.0 make.cross ARCH=3Dia64 >>>> >>>> If you fix the issue, kindly add following tag >>>> Reported-by: kbuild test robot >>>> >>>> All error/warnings (new ones prefixed by >>): >>>> >>>> In file included from include/asm-generic/pgtable-nopud.h:8:0, >>>> from arch/ia64/include/asm/pgtable.h:586, >>>> from include/linux/mm.h:99, >>>> from include/linux/highmem.h:8, >>>> from mm/debug_vm_pgtable.c:14: >>>> mm/debug_vm_pgtable.c: In function 'pud_clear_tests': >>>>>> include/asm-generic/pgtable-nop4d-hack.h:47:32: error: implicit de= claration of function '__pgd'; did you mean '__p4d'? [-Werror=3Dimplicit-= function-declaration] >>>> #define __pud(x) ((pud_t) { __pgd(x) }) >>>> ^ >>>>>> mm/debug_vm_pgtable.c:141:8: note: in expansion of macro '__pud' >>>> pud =3D __pud(pud_val(pud) | RANDOM_ORVALUE); >>>> ^~~~~ >>>>>> include/asm-generic/pgtable-nop4d-hack.h:47:22: warning: missing b= races around initializer [-Wmissing-braces] >>>> #define __pud(x) ((pud_t) { __pgd(x) }) >>>> ^ >>>>>> mm/debug_vm_pgtable.c:141:8: note: in expansion of macro '__pud' >>>> pud =3D __pud(pud_val(pud) | RANDOM_ORVALUE); >>>> ^~~~~ >>>> cc1: some warnings being treated as errors >>> >>> This build failure is expected now given that we have allowed DEBUG_V= M_PGTABLE >>> with EXPERT without platform requiring ARCH_HAS_DEBUG_VM_PGTABLE. Thi= s problem >>> i.e build failure caused without a platform __pgd(), is known to exis= t both on >>> ia64 and arm (32bit) platforms. Please refer https://lkml.org/lkml/20= 19/9/24/314 >>> for details where this was discussed earlier. >>> >> >> I'd prefer not to merge a patch which is known to cause build >> regressions. Is there some temporary thing we can do to prevent these >> errors until arch maintainers(?) get around to implementing the >> long-term fixes? >=20 > We could explicitly disable CONFIG_DEBUG_VM_PGTABLE on ia64 and arm pla= tforms > which will ensure that others can still use the EXPERT path. >=20 > config DEBUG_VM_PGTABLE > bool "Debug arch page table for semantics compliance" > depends on MMU > depends on !(IA64 || ARM) > depends on ARCH_HAS_DEBUG_VM_PGTABLE || EXPERT > default n if !ARCH_HAS_DEBUG_VM_PGTABLE > default y if DEBUG_VM >=20 On both ia32 and arm, the fix is trivial. Can we include the fix within this patch, just the same way as the=20 mm_p4d_folded() fix for x86 ? Christophe