From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FCC0E7718F for ; Fri, 3 Jan 2025 10:18:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA40F6B007B; Fri, 3 Jan 2025 05:18:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E53DA6B0082; Fri, 3 Jan 2025 05:18:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF43E6B0083; Fri, 3 Jan 2025 05:18:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B1D916B007B for ; Fri, 3 Jan 2025 05:18:38 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5D37C1C721E for ; Fri, 3 Jan 2025 10:18:38 +0000 (UTC) X-FDA: 82965740508.16.BA60F0D Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf04.hostedemail.com (Postfix) with ESMTP id A197040013 for ; Fri, 3 Jan 2025 10:17:42 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=VXjz4fCO; spf=pass (imf04.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735899481; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FyocDEmvZwzuqzNuBW4a5jcUhIkekSwRpQZ2fu4rhWU=; b=Z5ZLjcA5+bFssQEBONgNpmuGT7Qnu8+YpVv/Mf9VdmfEzRyqax2fjHTA/MJ4N1nNpzRluS 6EZr2AOV320L+Ctgt1vHKT1jnntlopufU4ENd155kNmHlyL/IiovLDD/74fGbwm0K0ybhQ ak3Wx/vfEQkgztrmydBag4r6C/AeVUg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735899481; a=rsa-sha256; cv=none; b=J3vfwYPBtyEGqiO0avdbx4gh8YgcMcoXz6JleVOhrEC0ABVMaLWA6dBPJPEYcFnNAb0j14 4FOWW3SI8Xm2B+y7TZS+q6uQP1skKMxwYBGb341EHZJaLcpeex0j1OZXySdLtbtFWK0SRd UPdimFHyX7J16QVX1fXQfwH5N1lWInE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=VXjz4fCO; spf=pass (imf04.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5033rtjq006892; Fri, 3 Jan 2025 10:18:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=FyocDE mvZwzuqzNuBW4a5jcUhIkekSwRpQZ2fu4rhWU=; b=VXjz4fCOSyNsvZ1MV6enbZ 7V8CcfcjS7qYbVXW/ZNQo8tPxMlSI+A4FMg6Y6jY/25lSqK2p8zJZXUydka8PU7T 2h0SlqZLu2rJzYcJlP+rfqAQuXoH2/LN416XSPmPvsHpkPwVgq6dhz85SOLOQKiF TxWV8/2IJmyF1fjJAJayH5MeVQXElY8OqqtgrORPOMhbV4lqOddPEw9F4p4mLC6n myj8cU5PgIebUYxDoM1O2N1GLWV6ZkY1Hf69yr6kPccN8Rc7Cvr3JqZMXkeNrDek fYNqaZWid5uMqnrN/hgERgKPd7NsXmusVyK1Maqx8g4haOPi6FGDSlzVtAduAfxw == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43x8cbh86a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 03 Jan 2025 10:18:32 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 503AIWEr015331; Fri, 3 Jan 2025 10:18:32 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43x8cbh864-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 03 Jan 2025 10:18:32 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5036oeb8016653; Fri, 3 Jan 2025 10:18:30 GMT Received: from smtprelay04.dal12v.mail.ibm.com ([172.16.1.6]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 43tw5knsm3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 03 Jan 2025 10:18:30 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay04.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 503AIUER53936476 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 3 Jan 2025 10:18:30 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0CDF65805A; Fri, 3 Jan 2025 10:18:30 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 239BF58062; Fri, 3 Jan 2025 10:18:26 +0000 (GMT) Received: from [9.171.55.237] (unknown [9.171.55.237]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Fri, 3 Jan 2025 10:18:25 +0000 (GMT) Message-ID: Date: Fri, 3 Jan 2025 15:48:24 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 PATCH 4/5] vmstat: add page-cache numa hints To: Gregory Price , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, nehagholkar@meta.com, abhishekd@meta.com, kernel-team@meta.com, david@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, kbusch@meta.com, ying.huang@linux.alibaba.com References: <20241210213744.2968-1-gourry@gourry.net> <20241210213744.2968-5-gourry@gourry.net> Content-Language: en-US From: Donet Tom In-Reply-To: <20241210213744.2968-5-gourry@gourry.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: nHJ3MpupZky-hKrd-a47L60ph58CWhgB X-Proofpoint-ORIG-GUID: TsO2TVQmxSaWww4zQjkJezGyHbCcvcMF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 spamscore=0 suspectscore=0 clxscore=1015 adultscore=0 impostorscore=0 phishscore=0 priorityscore=1501 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501030087 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A197040013 X-Stat-Signature: ysxjz8kf8h7xwgq5ofesbgnqsgo8cpq3 X-Rspam-User: X-HE-Tag: 1735899462-435262 X-HE-Meta: U2FsdGVkX1/4VAli5rIr6nhHyTOp6PzN8mM7tUlLyIjNmmDkzpOTCAKwzw/eZLPsnb16dDZQFaxcAuLNcVIg9+UJQTMwh+2GhsC7yQfAiUKWVXQs42ZP8wFFza2Ttia5o18WIWn8omS9zbQN7gJTvvJTqq+0UwXD5yOFAx5v0dtC8I4vRwj8XUWlvQ3IyWEfPMqzWuoRgndx1rOOygFMgzqoV/yk+qpvJk3smdw3Zk/a6RN5H9PyuKCxDDegdgOuXHkbJHadGo8lrt507ndiATQN8XjLket59L0pFzTINC13nafB96qZfEC1VIuRfWJFJKmbPgvEUQOYVonKOBEtSlV+e7cZVIlRuiuxpEQ2/yyb9Hp9UKrJq59ETRa5pMsYRxP9hTaHFS9N1IU5cSfeEjCE0dARJLlShmA1NgUaaCvK+EmyMOUhKd8nY6eDVbxhcbfxk8+T7+Ue33NDFUofaYGWoVdTu3jK8ioRtEDN0EnootIuW53i2ub7sMg/7MhlpiJEA1FcF/41WvTsZTbI4uVOa2OLOCoed4P0qoTCaiS6L/UVr3ZzTVMEVa0hdel489yHWktHAetKo/WY6X+GeAAOlrjCFiwBm/WfJcmkfr1Dlc1on4+9tH1LPq+PaWwWT3vhdyw/LtXq2NshyS1NVg61Y5QOcPEfspnVomZ/vyZqX/90xfbfSXU9ZRI1IQ6fHYzqcWzibI7KVMzHhiYVj/bJyn70VF7qzOgyzbUAMUSq/D/QMaNfAtKliLOOO5JNAE5SCQPpOKsEsbXWZMiuZoWYVQwwRvEbfess2CsLlsxoLt3Q4zaU9VrUJnuLcHKZ1b703HLjfPsAtiKcaElgXOKHSSSgrN+5RvzDFJ+IVEjmshieye/MB9gFHHUGPwx6o6kGyBrstKA3egaPYKp5Ln51+umAktrNIwV1xIEEZVxm7Dn5HwQaRgfXTI5zwg6mTO/u7TvioS/QtY29D91 nqccsOmF yeOoEcYpiZmnFAS6AROpzZwZEIXYV1cYTP3Q8uM3mnOY1dMrNa+df7Yx4XRwxUcdCG1aFYqgH+1mlTNdkuxnM5BllDOcqUYpQFW1CiKuW71SdfyzJEQOvS1pGoRi3wiuyuf5z07sUyIk0bKVnB7s8/fn9TnFw+pI2lEwNy3s0gEgue44mxw9Vb/g2AfMXLJO3fUtSH1AC0CSgLotSg7/2s4aBzclxBNJ8O0Xa2fMLOoaKpGSDEUVSi8Yn3kyYlQlyPFGJtx6CG9gxMX/li1YaCAlZUpu5Y+bDVfjO8XaoDcSsyssieq9g46XalOu9cbl73LJx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/11/24 03:07, Gregory Price wrote: > Count non-page-fault events as page-cache numa hints instead of > fault hints in vmstat. Add a define to select the hint type to > keep the code clean. > > Signed-off-by: Gregory Price > --- > include/linux/vm_event_item.h | 8 ++++++++ > mm/memory.c | 6 +++--- > mm/vmstat.c | 2 ++ > 3 files changed, 13 insertions(+), 3 deletions(-) > > diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h > index f70d0958095c..c5abb0f7cca7 100644 > --- a/include/linux/vm_event_item.h > +++ b/include/linux/vm_event_item.h > @@ -63,6 +63,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > NUMA_HUGE_PTE_UPDATES, > NUMA_HINT_FAULTS, > NUMA_HINT_FAULTS_LOCAL, > + NUMA_HINT_PAGE_CACHE, Hi Gregory, While running tests on the patch, I encountered the following warning message on the console. [  187.943052] ------------[ cut here ]------------ [  187.943234] __count_memcg_events: missing stat item 49 [  187.943287] WARNING: CPU: 0 PID: 3121 at mm/memcontrol.c:852 __count_memcg_events+0x3fc/0x42c The warning occurred because NUMA_HINT_PAGE_CACHE was not added in memcg_vm_event_stat. I did below change, Now the warnings are not coming. diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 7b3503d12aaf..fbb360cfea30 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -460,6 +460,7 @@ static const unsigned int memcg_vm_event_stat[] = {         NUMA_PAGE_MIGRATE,         NUMA_PTE_UPDATES,         NUMA_HINT_FAULTS, +       NUMA_HINT_PAGE_CACHE,  #endif  }; Without the change stat output ========================  #  cat /proc/vmstat  |grep -i numa_hint_page_cache  numa_hint_page_cache 274  numa_hint_page_cache_local 0  #cat /sys/fs/cgroup/memory.stat  |grep -i numa_hint_page_cache  # With the change stat output ========================  # cat /proc/vmstat  |grep -i numa_hint_page_cache  numa_hint_page_cache 274  numa_hint_page_cache_local 0  #  # cat /sys/fs/cgroup/memory.stat  |grep -i numa_hint_page_cache  numa_hint_page_cache 274  # -Donet > + NUMA_HINT_PAGE_CACHE_LOCAL, > NUMA_PAGE_MIGRATE, > #endif > #ifdef CONFIG_MIGRATION > @@ -185,6 +187,12 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > NR_VM_EVENT_ITEMS > }; > > +#ifdef CONFIG_NUMA_BALANCING > +#define NUMA_HINT_TYPE(vmf) (vmf ? NUMA_HINT_FAULTS : NUMA_HINT_PAGE_CACHE) > +#define NUMA_HINT_TYPE_LOCAL(vmf) (vmf ? NUMA_HINT_FAULTS_LOCAL : \ > + NUMA_HINT_PAGE_CACHE_LOCAL) > +#endif > + > #ifndef CONFIG_TRANSPARENT_HUGEPAGE > #define THP_FILE_ALLOC ({ BUILD_BUG(); 0; }) > #define THP_FILE_FALLBACK ({ BUILD_BUG(); 0; }) > diff --git a/mm/memory.c b/mm/memory.c > index af7ba56a4e1e..620e2045af7b 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -5578,10 +5578,10 @@ int numa_migrate_check(struct folio *folio, struct vm_fault *vmf, > *last_cpupid = folio_last_cpupid(folio); > > #ifdef CONFIG_NUMA_BALANCING > - count_vm_numa_event(NUMA_HINT_FAULTS); > - count_memcg_folio_events(folio, NUMA_HINT_FAULTS, 1); > + count_vm_numa_event(NUMA_HINT_TYPE(vmf)); > + count_memcg_folio_events(folio, NUMA_HINT_TYPE(vmf), 1); > if (folio_nid(folio) == numa_node_id()) { > - count_vm_numa_event(NUMA_HINT_FAULTS_LOCAL); > + count_vm_numa_event(NUMA_HINT_TYPE_LOCAL(vmf)); > *flags |= TNF_FAULT_LOCAL; > } > #endif > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 4d016314a56c..bcd9be11e957 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1338,6 +1338,8 @@ const char * const vmstat_text[] = { > "numa_huge_pte_updates", > "numa_hint_faults", > "numa_hint_faults_local", > + "numa_hint_page_cache", > + "numa_hint_page_cache_local", > "numa_pages_migrated", > #endif > #ifdef CONFIG_MIGRATION