From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB592C19F4F for ; Wed, 8 May 2024 09:40:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AA4C6B00CE; Wed, 8 May 2024 05:40:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65A686B00CF; Wed, 8 May 2024 05:40:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5220E6B00D0; Wed, 8 May 2024 05:40:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3289B6B00CE for ; Wed, 8 May 2024 05:40:28 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D933C121076 for ; Wed, 8 May 2024 09:40:27 +0000 (UTC) X-FDA: 82094733294.02.1EC441B Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf05.hostedemail.com (Postfix) with ESMTP id 3C170100004 for ; Wed, 8 May 2024 09:40:24 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b="XJ1/7aSq"; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf05.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715161226; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7PolV6oZOy6l4rky9sVZcKOydBFtU8Dw4oGyzGtNEmk=; b=3hf9WLEGyLonM6z8j/0BI91W5FKTSlxYn/yS5IhXlKMybAuTSyF0sMfeBfide6fSmHe3U3 TB1M26cBNPeXmvTjB2stMVdc35jX4jy2Za43WwkoKnkCQLAK62LTSWTuYYH28HF7EPTxtI iZNqp/4P+EmipPN852oiEa2TmDzzZ7M= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b="XJ1/7aSq"; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf05.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715161226; a=rsa-sha256; cv=none; b=T/fofX76n+Ct9yTe+QTEpxzlVavgOV5Y7ucsUiHIFjfv9IBTYoEgCZtt8OCUtGZIx/2RoL G4bVtnc+fO1N1rOGoz7AemMoPeBO/SpoYMC0ZTxSBJAqaB8uDyemGqxEY1jHdPFquXHOcN 2bo7feOBshuUN0whxT2jDgqhRkkBGB4= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1715161222; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=7PolV6oZOy6l4rky9sVZcKOydBFtU8Dw4oGyzGtNEmk=; b=XJ1/7aSqVuFwfQRJ7CXhJ0/NvSX/Hd4MNkMf5DGn63YxLjFIDpVSp9kA4RtsRZY0JSEzfYsgaYEWC4dv3jPOAuKueDzzuEa13KiruigaWIbomcZLTzjzEkulq90FA2bTcNcekBZkgHX4kf/nlv5yrx+kyott16Ae9UCJpRUg0D4= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033022160150;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=13;SR=0;TI=SMTPD_---0W63EItG_1715161219; Received: from 30.97.56.69(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W63EItG_1715161219) by smtp.aliyun-inc.com; Wed, 08 May 2024 17:40:21 +0800 Message-ID: Date: Wed, 8 May 2024 17:40:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/8] mm: move highest_order() and next_order() out of the THP config To: Ryan Roberts , akpm@linux-foundation.org, hughd@google.com Cc: willy@infradead.org, david@redhat.com, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ying.huang@intel.com, 21cnbao@gmail.com, shy828301@gmail.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <9576c979-8a11-48e2-aec4-646acf0d8e26@arm.com> <2fcd6dfc-21b7-4e3f-9741-8f0d23d2da5f@linux.alibaba.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3C170100004 X-Stat-Signature: mkanfjd68uk5b3e1tdsodwhkmab895ai X-Rspam-User: X-HE-Tag: 1715161224-699118 X-HE-Meta: U2FsdGVkX19khuDMBe9J0TSAFVC7xtDvStvS65c3Q/ZddDAcAjW6gaopMOSGetLCqt2aKXhlrqo5f5ysoKFU8TczJwVd+yWYVYpNW09P+1e1ISQrzMz8ZQQfgrJwj160Jo+4AZkJQMRDMxkNob6IBuERAln2J0cCO9p2iD4SrMp09sZQlbGRQYSob/3XfUPCRTPhkTSvL5APgBhZFNMzyL6unjFN/Kk+im7oPg+mU77F35XVDz7TKAnzcfPyl9FxFevUGYCQCCIJ12l6E9dW2BbD3QmEMQR5JoIL5Sk+ZtbPXAGLObhFhOUWdDJZE9T6BDDpoxBrEqFYusbd2prGmZ+6YgEye2/pZwuD/CcForrnzm/jGgjWqUEbiGkpozk3co+CEh4gSy1n1jo6n7T+d4SnW2CfhkLyhLOg0p8Vq2h40gWcu8xusw1mDS6vRyMFK27Phw5c9JZlMHp27m6fnCpggXE1CBOiCHaS1ECdgocNWvh9848qZmTarry/lZr/7tlDQG1qeASv9JheuIxp/1Ybz8nCTg0wH8N54hBnXEb9YHp1GaWbPZ2XdmBf0jXraTT8hwyAb8F46IciPwYfjub+/eunyNwuBx8kGXlU6eQ0UHwCfTfE6lEAjFNEyedSw7OWzMI2IbMboQrhySq3ud48qwwjfOX32d1/63FjunYx6uzdghWSUPvdTk3hrjhSpzjPnRV0OaBJ4VkwywFMOCKkUTLtqX0/gxc6LgPNKUO3Bm7q/UG67oE+FdA2dGkfNQzQrbsf+wKelBNjiTB0PJAjFGaucn+6uYt4uFAq/mpiGxYuCSTyD+gY+rNZgaoTYS5DBaxo1Ym7N8Rv5PhOIU/zDIu83p/TBZXOoOKGj0SEbf88f96RxgYjQ/iFtEKGG/HSCfbNZb3IQ2dM3hounrcOnnq5cLDiO37aKDkYeFluv0xwBtxGcUY6EZOTP+G4Mwq3tJFDv0yZBWuIfLi H/L7tA7m AIfIpIDO0le8x9ZAqjkHiaLrG2USxvoSWUMHmKpTiZNuPVhEZ0ssZnOUk/wNt96jh8J6dCqEc3denohqLpBGcNfuU0PJ2ZwE11W394Wh6PniTlJr2I6Yuqds4NvQJbFW8o4AGMxJXppLChUERRogzDwIdrCYQmmuyDg5jjDmvBd8MP+HSGHXj26UqsJ3EVTqMTOEes1GbO5MiVHX0hnjFRoWt5xdWoSn+XI2GqShBbYeU30TrWRTHmAKDxbmqeQ3v7IAwOJdL2TvEAqNCdNFQBw6awqotTNYcR37ZYYrH2oFBEdHig0l0iIxKd/bun8oaCg5x7yWAwEomyue8SAzZCFmhOO/r2plwJ9Ck X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/8 17:06, Ryan Roberts wrote: > On 08/05/2024 03:13, Baolin Wang wrote: >> >> >> On 2024/5/7 18:21, Ryan Roberts wrote: >>> On 06/05/2024 09:46, Baolin Wang wrote: >>>> Move highest_order() and next_order() out of the CONFIG_TRANSPARENT_HUGEPAGE >>>> macro, which can be common functions to be used. >>> >>> Sorry if I haven't kept up with the discussion, but why is this needed? I >>> wouldn't expect a need to iterate over orders if THP is compile-time disabled >>> because we will never try to allocate THP? >> >> Cause I don't want to add some dummy functions to avoid building errors if >> CONFIG_TRANSPARENT_HUGEPAGE is not enabled in patch 6. Another thought is that >> the pagecache can also allocate a large folio even when THP is not enabled, so >> these helpers may be used in the future (not sure though). > > OK, I'll admit I haven't looked at the latter patches yet - I'd like to conclude > on the interface and mapping/alignment strategy first. > > But it wasn't necessary to access these functions for the anon/private case > without CONFIG_TRANSPARENT_HUGEPAGE, so I'm wondering why it's needed for shmem > case. I would expect that they don't need to be defined at all. Currently in the shmem_alloc_and_add_folio() function, the hugepage allocating is not guarded with '#ifdef CONFIG_TRANSPARENT_HUGEPAGE', but rather with 'IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)', which can lead to some building errors when CONFIG_TRANSPARENT_HUGEPAGE is not enabled. However, this is not a big issue, and I will make some adjustments to avoid defining dummy functions.