From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B964CC3DA64 for ; Wed, 31 Jul 2024 04:46:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34B046B0085; Wed, 31 Jul 2024 00:46:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FB106B0088; Wed, 31 Jul 2024 00:46:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EA7B6B0089; Wed, 31 Jul 2024 00:46:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F38416B0085 for ; Wed, 31 Jul 2024 00:46:10 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A33018020C for ; Wed, 31 Jul 2024 04:46:10 +0000 (UTC) X-FDA: 82398810900.11.8BBED55 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf14.hostedemail.com (Postfix) with ESMTP id 2BFF5100008 for ; Wed, 31 Jul 2024 04:46:07 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722401113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Kf0XK8Ls8Zq/povzIZl6NHCjQeEBe2f9hyswcNljfQ=; b=Bq2ZmOalmD4UlWxM7/eHnieb+G2fdexVzhIyC0tRG3IeQUJPBwopJaFbyfPSyv2Z+TxMQO R17rnP2MsAoxrBQdbk7ATEl3MfwoUzZwLx46borjZZAYaNlHszvXuJxaSjrAK+P5oKvjVp WxI4drOxtS45zUMzaDIyvMIvjlXVOQ0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722401113; a=rsa-sha256; cv=none; b=j4fIpM3gPO1sZt9RF+frA08PMtPp3+aw7FqCI+aKIZcyBWvCE78VmjwvswiOWubEhvsl+e byNCqnDGtT6sNGBEYgIlSU1Sx1X9rnPY9IHTYUTBJUJM6vlJUwHS56ti46USj8qyq/wmH2 To7LzKL5ctgJ79R1cZbaRHTZHiKr5VY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4WYfg52VG7z1L99d; Wed, 31 Jul 2024 12:45:53 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 55937140360; Wed, 31 Jul 2024 12:46:04 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 31 Jul 2024 12:46:03 +0800 Message-ID: Date: Wed, 31 Jul 2024 12:46:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] mm: memory-failure: add unmap_posioned_folio() Content-Language: en-US To: David Hildenbrand , Andrew Morton CC: Oscar Salvador , Miaohe Lin , Naoya Horiguchi , References: <20240725011647.1306045-1-wangkefeng.wang@huawei.com> <20240725011647.1306045-2-wangkefeng.wang@huawei.com> <95d372e0-e272-4669-a3cc-7da32e866504@redhat.com> From: Kefeng Wang In-Reply-To: <95d372e0-e272-4669-a3cc-7da32e866504@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2BFF5100008 X-Stat-Signature: u5bikipbf1u8r8bst3to75fr5y7q74ky X-HE-Tag: 1722401167-933450 X-HE-Meta: U2FsdGVkX18ksR81yVM5L44rMgVB+8X+/tDGjlLFoWK7jMeohXXG7Nbot57bR1WZwBE5nnte88rDu+eE7Px5//8DwzmgVnew9NAhAGpgJCTsDTn4uJQf43qujXS+Im2iOMj/lxrUD9kxWpnw7al2/BnM1+X2DmhHNOLl0wznHISVxJw1m6/p2gEOygY3gYvlKLvpkFyBeqFgwZav8Rd63sOGaGqYZFTeeEFKpAVqOKfvcVaAcK8fV9eRwp9EhTRX50oZKiH2j7gQ4NqzKLoZSnPoPKBvikFK06mOSAe+wXNGO+56cYM7uXGxAZHqHiGY+8iKvd7TJ2VZVgzANn0jehFPHTatrhQhWC6Cysinti8XwP7mlLa50Iscysh2ZSKfljcKatvFZdf3jCcREKjLD58dh3ivkzZQegRafzqqhMMgCE0KEApzul3djfzEJGoetDbLLkD+NNYHKTWqoD1Q8+4YTDdd9Gpm0pQX078MFlIHs/WQ1t84oo6dh8yl6da7jukDztyn3TVG25H4UYKSIhTgAj7tHlHi0M4+mPYVrL2bbJ8MhFP9Ex0dcQb/yTf7unjdD0Amz/41aNEzhA6MvxBDw7YuCZ6+0J+CBJa3OWRXD7qWw+HDUC8XQc9SihKGuoUaWid4cN0C8dGkFQM3pgzBgcYR1M4ChStrqj70qs4YaBQ7me11pHgPe2bQSXb7hTxOPQ7DFhFPnHdjC/FvjW0uqgxVR4UN6GoBS/E7e0cGZT3HZLcKffGA4DMzacBjBZ5uU3ceT/TkQaOPOsxPJmkM0rSDamDOaBQdRKBRDt3FVPDcRjckVj75Hvvz3ThCshJRxrsOZSyepLvemgL33YFM2Rf4fmWCtKKnCei2Y8gS28LST3XLz0EBwKBPvqYDnlkHwkCvFkuHvFTbGqC+Nm4Oyb9sSd4XTIR1Wu4SevrxZl0MkBIwCB13cNfP9dtlAmAoQv25Nvw5LcA1K7Y O64dR3GC kxhg5SuwbNwAlAmJUEQAxWvvYvUP3sJ5QtTgOv5hC7AGb1G59VIa03W+pW5YiVopTjy1Id8EwQHFtLoKFjEHl8g241EEBHai9rx2ee4XGCuaR7Cqyd59sgQIiH3sBPCP4nlPpuieNMRksOgYt6yk4MtsofOqsZaGE6mQeNpOCjCRax7eu13GfpF8gEQ/uABd276T2gjafmSsalJ2GZsgOtixCad0deQkYHhEZw5LKVGOCB6xSigSXQjAGu8aF8gArU1Fv7VondB5sNDqV/4SqTrQvwzsb+CFWxvAgzYhhr0n326xy/rp1AJGY2da26ti+uLrO8GSCQ4wwA2MkCZq5aQwXmNVCMpXR0dIr+Z2nXv4T9xc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/30 18:20, David Hildenbrand wrote: > On 25.07.24 03:16, Kefeng Wang wrote: >> Add unmap_posioned_folio() helper which will be reused by >> do_migrate_range() from memory hotplug soon. >> >> Signed-off-by: Kefeng Wang >> --- >>   mm/internal.h       |  9 +++++++++ >>   mm/memory-failure.c | 43 ++++++++++++++++++++++++++----------------- >>   2 files changed, 35 insertions(+), 17 deletions(-) >> >> diff --git a/mm/internal.h b/mm/internal.h >> index 7a3bcc6d95e7..c5bd24c4fa3a 100644 >> --- a/mm/internal.h >> +++ b/mm/internal.h >> @@ -1069,6 +1069,8 @@ static inline int find_next_best_node(int node, >> nodemask_t *used_node_mask) >>   /* >>    * mm/memory-failure.c >>    */ >> +#ifdef CONFIG_MEMORY_FAILURE >> +int unmap_posioned_folio(struct folio *folio, enum ttu_flags ttu); >>   void shake_folio(struct folio *folio); >>   extern int hwpoison_filter(struct page *p); >> @@ -1089,6 +1091,13 @@ void add_to_kill_ksm(struct task_struct *tsk, >> struct page *p, >>                unsigned long ksm_addr); >>   unsigned long page_mapped_in_vma(struct page *page, struct >> vm_area_struct *vma); >> +#else >> +static inline int unmap_posioned_folio(struct folio *folio, enum >> ttu_flags ttu) >> +{ >> +    return 0; >> +} >> +#endif >> + > > Was wondering if we could come up with a better name (something that > starts with folio_*), but wasn't able to come up with something I liked > more. Uh, pool at naming, I can't find a better one... > > Acked-by: David Hildenbrand > Thanks.