From: Raghavendra K T <raghavendra.kt@amd.com>
To: David Rientjes <rientjes@google.com>, Raghavendra K T <rkodsara@amd.com>
Cc: Aneesh Kumar <AneeshKumar.KizhakeVeetil@arm.com>,
David Hildenbrand <david@redhat.com>,
John Hubbard <jhubbard@nvidia.com>,
Kirill Shutemov <k.shutemov@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
Mel Gorman <mel.gorman@gmail.com>,
"Rao, Bharata Bhasker" <bharata@amd.com>,
Rik van Riel <riel@surriel.com>, Wei Xu <weixugc@google.com>,
Suyeon Lee <leesuyeon0506@gmail.com>,
Lei Chen <leillc@google.com>,
"Shukla, Santosh" <santosh.shukla@amd.com>,
"Grimm, Jon" <jon.grimm@amd.com>,
sj@kernel.org, shy828301@gmail.com, Zi Yan <ziy@nvidia.com>,
Liam Howlett <liam.howlett@oracle.com>,
Gregory Price <gregory.price@memverge.com>,
linux-mm@kvack.org, ligang.bdlg@bytedance.com
Subject: Re: Slow-tier Page Promotion discussion recap and open questions
Date: Wed, 8 Jan 2025 11:13:13 +0530 [thread overview]
Message-ID: <aecd0d69-293b-4090-bfdc-6791a588e3b5@amd.com> (raw)
In-Reply-To: <abffa289-b627-173e-ed09-f94d6169f8e6@google.com>
+ Gang Li
On 1/2/2025 10:14 AM, David Rientjes wrote:
> On Fri, 20 Dec 2024, Raghavendra K T wrote:
[...]
>>> Wei Xu asked if the scan period should be interpreted as the minimal
>>> interval between scans because kmmscand is single threaded and there are
>>> many processes. Raghu confirmed this is correct, the minimal delay.
>>> Even if the scan period is 400ms, in reality it could be multiple seconds
>>> based on load.
>>>
>>> Liam Howlett asked how we could have two scans colliding in a time
>>> segment. Raghu noted if we are able to complete the last scan in less
>>> time than 400ms, then we have this delay to avoid continuously scanning
>>> that results in increased cpu overhead. Liam further asked if processes
>>> opt into a scan or out of the scan, Raghu noted we always scan every
>>> process. John Hubbard suggested that we have per-process control.
>>
>> +1 for prctl()
>>
>> Also I want to add that, I will get data on:
>>
>> what is the min and max time required to finish the entire scan for the
>> current micro-benchmark and one of the real workload (such as Redis/
>> Rocksdb...), so that we can check if we are meeting the deadline of
>> scanning with single kthread.
>>
>
> Do we want more fine-grained per-process control other than just the
> ability to opt out entire processes? There may be situations where we
> want to always serve latency tolerant jobs from CXL extended memory, we
> don't care to ever promote its memory, but I also think there will be
> processes that are between the two extremes (latency critical and latency
> tolerant).
>
> I think careful consideration needs to be given to how we handle
> per-process policy for multi-tenant systems that have different levels of
> latency sensitivity. If kmmscand becomes the standard way of doing page
> promotion in the kernel, the userspace API to inform it of these policy
> decisions is going to be key. There have been approaches where this was
> primarily driven by BPF that has to solve the same challenge.
>
Came across prctl() approach for NUMAB by Gang Li,
Link:
https://lore.kernel.org/lkml/20220224075227.27127-1-ligang.bdlg@bytedance.com/T/
I hope there was no stronger reason against the merging (just to ensure
since it will be almost same for our case here).
[...]
Regards
- Raghu
prev parent reply other threads:[~2025-01-08 5:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 4:19 David Rientjes
2024-12-18 14:50 ` Zi Yan
2024-12-19 6:38 ` Shivank Garg
2024-12-30 5:30 ` David Rientjes
2024-12-30 17:33 ` Zi Yan
2025-01-06 9:14 ` Shivank Garg
2024-12-18 15:21 ` Nadav Amit
2024-12-20 11:28 ` Raghavendra K T
2024-12-18 19:23 ` SeongJae Park
2024-12-19 0:56 ` Gregory Price
2024-12-26 1:28 ` Karim Manaouil
2024-12-30 5:36 ` David Rientjes
2024-12-30 6:51 ` Raghavendra K T
2025-01-06 17:02 ` Gregory Price
2024-12-20 11:21 ` Raghavendra K T
2025-01-02 4:44 ` David Rientjes
2025-01-06 6:29 ` Raghavendra K T
2025-01-08 5:43 ` Raghavendra K T [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aecd0d69-293b-4090-bfdc-6791a588e3b5@amd.com \
--to=raghavendra.kt@amd.com \
--cc=AneeshKumar.KizhakeVeetil@arm.com \
--cc=bharata@amd.com \
--cc=david@redhat.com \
--cc=gregory.price@memverge.com \
--cc=jhubbard@nvidia.com \
--cc=jon.grimm@amd.com \
--cc=k.shutemov@gmail.com \
--cc=leesuyeon0506@gmail.com \
--cc=leillc@google.com \
--cc=liam.howlett@oracle.com \
--cc=ligang.bdlg@bytedance.com \
--cc=linux-mm@kvack.org \
--cc=mel.gorman@gmail.com \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=rkodsara@amd.com \
--cc=santosh.shukla@amd.com \
--cc=shy828301@gmail.com \
--cc=sj@kernel.org \
--cc=weixugc@google.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox