linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Magnus Damm" <magnus.damm@gmail.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Magnus Damm <magnus@valinux.co.jp>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org, Nick Piggin <nickpiggin@yahoo.com.au>
Subject: Re: [PATCH 01/03] Unmapped: Implement two LRU:s
Date: Sat, 11 Mar 2006 21:14:14 +0900	[thread overview]
Message-ID: <aec7e5c30603110414m1690ecd4qf2dcd545858cc8a5@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0603101113210.28805@schroedinger.engr.sgi.com>

On 3/11/06, Christoph Lameter <clameter@sgi.com> wrote:
> On Fri, 10 Mar 2006, Magnus Damm wrote:
>
> > Use separate LRU:s for mapped and unmapped pages.
> >
> > This patch creates two instances of "struct lru" per zone, both protected by
> > zone->lru_lock. A new bit in page->flags named PG_mapped is used to determine
> > which LRU the page belongs to. The rmap code is changed to move pages to the
> > mapped LRU, while the vmscan code moves pages back to the unmapped LRU when
> > needed. Pages moved to the mapped LRU are added to the inactive list, while
> > pages moved back to the unmapped LRU are added to the active list.
>
> The swapper moves pages to the unmapped list? So the mapped LRU
> lists contains unmapped pages? That would get rid of the benefit that I
> saw from this scheme. Pretty inconsistent.

The first (non released) versions of these patches modified rmap.c to
move the pages between the LRU:s both during adding and removing
rmap:s, so the mapped LRU would in that case keep mapped pages only.
This did however introduce more overhead, because pages only mapped by
a single process would bounce between the LRU:s when a such process
starts or terminates.

The split active list implementation by Nick Piggin did however only
move pages between the active lists during vmscan (if I understood the
patch correctly), which is something that I have not tried yet.

I think it would be interesting with 3 active lists, one for unmapped
pages, one for mapped file-backed pages and one for mapped anonymous
pages. And then let the vmscan code move pages between the lists.

Thank you for the comments!

/ magnus

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2006-03-11 12:14 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-10  3:44 [PATCH 00/03] Unmapped: Separate unmapped and mapped pages Magnus Damm
2006-03-10  3:44 ` [PATCH 01/03] Unmapped: Implement two LRU:s Magnus Damm
2006-03-10 19:16   ` Christoph Lameter
2006-03-11 12:14     ` Magnus Damm [this message]
2006-03-10  3:44 ` [PATCH 02/03] Unmapped: Modify LRU behaviour Magnus Damm
2006-03-10  3:44 ` [PATCH 03/03] Unmapped: Add guarantee code Magnus Damm
2006-03-10  4:57   ` Nick Piggin
2006-03-10  6:04     ` Magnus Damm
2006-03-10 15:41       ` Chandra Seetharaman
2006-03-11 12:29         ` Magnus Damm
2006-03-15 15:32           ` Chandra Seetharaman
2006-03-10  4:55 ` [PATCH 00/03] Unmapped: Separate unmapped and mapped pages Nick Piggin
2006-03-10  5:55   ` Magnus Damm
2006-03-10  7:52 ` Arjan van de Ven
2006-03-10 13:19   ` Magnus Damm
2006-03-10 14:05     ` Arjan van de Ven
2006-03-11 11:52       ` Magnus Damm
2006-03-11 20:58     ` Peter Zijlstra
2006-03-13  2:28       ` Magnus Damm
2006-03-10 12:22 ` Peter Zijlstra
2006-03-10 13:38   ` Magnus Damm
2006-03-11 21:08     ` Peter Zijlstra
2006-03-13  3:05       ` Magnus Damm
2006-03-10 19:12 ` Christoph Lameter
2006-03-11 11:56   ` Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aec7e5c30603110414m1690ecd4qf2dcd545858cc8a5@mail.gmail.com \
    --to=magnus.damm@gmail.com \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=magnus@valinux.co.jp \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox