From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by uproxy.gmail.com with SMTP id k40so195972ugc for ; Tue, 17 Jan 2006 00:29:15 -0800 (PST) Message-ID: Date: Tue, 17 Jan 2006 17:29:15 +0900 From: Magnus Damm Subject: Re: Race in new page migration code? In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Content-Disposition: inline References: <20060114155517.GA30543@wotan.suse.de> <20060114181949.GA27382@wotan.suse.de> <43C9DD98.5000506@yahoo.com.au> Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Nick Piggin , Nick Piggin , Andrew Morton , Linux Kernel Mailing List , Linux Memory Management List List-ID: On 1/16/06, Christoph Lameter wrote: > On Sun, 15 Jan 2006, Nick Piggin wrote: > > > OK (either way is fine), but you should still drop the __isolate_lru_page > > nonsense and revert it like my patch does. > > Ok with me. Magnus: You needed the __isolate_lru_page for some other > purpose. Is that still the case? It made sense to have it broken out when it was used twice within vmscan.c, but now when the patch changed a lot and the function is used only once I guess the best thing is to inline it as Nick suggested. I will re-add it myself later on when I need it. Thanks. / magnus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org