Re: [PATCH] i386: nid_zone_sizes_init() update

[Magnus Damm <magnus.damm@gmail.com>]

On 10/6/05, Dave Hansen <haveblue@us.ibm.com> wrote:
> On Wed, 2005-10-05 at 17:35 +0900, Magnus Damm wrote:
> > Broken out nid_zone_sizes_init() change from i386 NUMA emulation code.
> ...
> > -static inline unsigned long  nid_size_pages(int nid)
> > -{
> > -     return node_end_pfn[nid] - node_start_pfn[nid];
> > -}
> > -static inline int nid_starts_in_highmem(int nid)
> > -{
> > -     return node_start_pfn[nid] >= max_low_pfn;
> > -}
>
> Hey, I liked those helpers!

Well, too bad for you! ;)

> When I suggested that you make your patches apply on top of the existing
> -mhp stuff, I didn't just mean that they should _apply_, they should
> probably mesh a little bit better.  For instance, it would be very
> helpful to use those 'static inlines', or make a couple new ones if you
> need them.

Okey, I think I understand. And I agree that more effort could be put
into this to make the code look better.  I thought this change was
required for the NUMA emulation code, but it turns out it wasn't. I
guess keeping the code as is and ignoring the patch is probably the
best solution.

Thanks!

/ magnus

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>