From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6968AC5321D for ; Tue, 27 Aug 2024 01:38:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0114C6B0095; Mon, 26 Aug 2024 21:38:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDC696B0096; Mon, 26 Aug 2024 21:38:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D55B36B0098; Mon, 26 Aug 2024 21:38:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B70EF6B0095 for ; Mon, 26 Aug 2024 21:38:33 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 59492815A9 for ; Tue, 27 Aug 2024 01:38:33 +0000 (UTC) X-FDA: 82496315706.11.108A19B Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf22.hostedemail.com (Postfix) with ESMTP id C8838C0004 for ; Tue, 27 Aug 2024 01:38:29 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of yukaixiong@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=yukaixiong@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724722596; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fgfD/JK0ZpwfH5n+1ywtgAif+5BJrNnHUbUFk2hJdjw=; b=z1m68jocOMcmx24tGoCL7D4FtbnaLVfJRwD0Vlw/yiEvIGdryL0OlGDMpak2VI+dGedZlr +XGhUNHU4mnAR4YESqZNkfnx58DPf12Bwiqz+hz4QspAd1QWqEZ5zfeBfqFC04MnXKwq5E +UnV2g6CFaEMJ0KRRJ3eeQZ7FqlH8V0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of yukaixiong@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=yukaixiong@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724722596; a=rsa-sha256; cv=none; b=nrWlPadSrhofJI7ccqRNG8mdxuTqlwAJLGj+lh+RjEWKBeoqjALT2kDxorzRhQ4yoG1FSI 4tMApRb4EkrGu8lLnh8v0MpcVlqOTrhZwVeP/0cdasNgieiNdWo6MkGNjchtsJ+v5iMeXY s/DDSvP0t+1xNMbCA5xmDNts/9oVgqc= Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Wt96n1CSJz20mqk; Tue, 27 Aug 2024 09:33:37 +0800 (CST) Received: from kwepemh100016.china.huawei.com (unknown [7.202.181.102]) by mail.maildlp.com (Postfix) with ESMTPS id EFFF7140120; Tue, 27 Aug 2024 09:38:24 +0800 (CST) Received: from [10.174.178.75] (10.174.178.75) by kwepemh100016.china.huawei.com (7.202.181.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 27 Aug 2024 09:38:22 +0800 Subject: Re: [PATCH -next 07/15] security: min_addr: move sysctl into its own file To: Paul Moore References: <20240826120449.1666461-1-yukaixiong@huawei.com> <20240826120449.1666461-8-yukaixiong@huawei.com> CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , From: yukaixiong Message-ID: Date: Tue, 27 Aug 2024 09:38:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.75] X-ClientProxiedBy: dggpeml500020.china.huawei.com (7.185.36.88) To kwepemh100016.china.huawei.com (7.202.181.102) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C8838C0004 X-Stat-Signature: tmrwcgt5reghaqe479yxinikus8pzte1 X-Rspam-User: X-HE-Tag: 1724722709-510146 X-HE-Meta: U2FsdGVkX1+NTFQhrI7NyPLelON6Xw9FSgfMHSYM+Y0cgCcVaF7/sjmEh8sSU2tiFcEBAcNhpeZg+TESRSomwN7pYUGrzgMZ++jjDtSm2l/wNanXTR74+EyavoGqadWDgG+P4sRIq4gi9f/0tUX+oN7GG/eXcM44rTKSnlJvYCqtS8pAUdFwYZ/ViVAvZ9vgN4nvnKMM8TIPvKa3E7OUYMbhx2mi+4oaI0qDHRp6WTxDZgI3rYncOQkJh6wYM2NGd/LlsCn0oPDjshEnYlSpzH4rI5yrLPkncZdT/XZ06j6OqaXjWZVWRtjMEqkm/68iIuMsGRENu/1B8r3zyOYY5S+gUTrFjA0hwG/KcRgIdGN2rzCOeyQLlaR752/5CelVhEOM6DKRTjr9DOXq4EYchP3/qZRd9XkCxd6ZtsUj6FekXIBOwdqvIZIoEncwrxQpmwCGTnnMwisSSf5xO+NVai8FXp2+GjesZCeYMeunxrqSnJXGTohz+VX8nejS6P4USR/+BLvp04tpAT/X4XE+lVtlLW+8zhMF+RXcY2RjV1uR+fhvXPNLVHoTGYlKn/13ykC5unZGCqMA63NBH1wWu7zCKYBL7SEekt+0y4w+jpMeY9o2JiD+ugFaFXeuezW6kjjLAX4g6HYj9T4E1dLCnhuwbTGDyrRUP+/Ht+HunkBUmUFOlLH+swgf1U/+SOONm9K5/NFvmAx1FN1yEu77UR4yjp+92fLtwdYlZyEbHt4deqBkh8CEu2FE1N0zGsj6KYcBeWVTLnr8fgMoUjsEauuBaQ+Y/aJMk/9aZAzmsvohQkMgW/CJwk2m+OfPmMH184RAmRfF5Ev0i8VU6buIrlDSrdwdRemKbmGOT44E4LVWzk75ep82BLn4auF4SF/HGgNDKXsQ4a4SL6B9zYbcflQQFqX6JKaZgOQemySbRrsu46AADdktmCAPipuC0fhqd8WNzMBB77X0klHGrnX u2Wut0/o NmAA9X2xfWFGNJ87pNW+QQ/syB2ICFtCZVP25mxTVXTsrXJR4v3+AwwlmJ1JNpiqwrbaP2JKVJYkeXR7OrztuovCDlY7O/y7mKdvLsqvJEXgBaLawlcKH8ylYzNYvTRZ3MRRdlI/BJrmbZ/EDoaZb19wqH2tucaBKzRox+ouxYGZji/l9IxoZFJ7tqz3ON4lpiOVST7ZgQ6cg8sGbKS4flKMSwGCWcpwTIr8+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/8/27 6:49, Paul Moore wrote: > On Mon, Aug 26, 2024 at 8:05 AM Kaixiong Yu wrote: >> The dac_mmap_min_addr belongs to min_addr.c, move it into >> its own file from /kernel/sysctl.c. In the previous Linux kernel >> boot process, sysctl_init_bases needs to be executed before >> init_mmap_min_addr, So, register_sysctl_init should be executed >> before update_mmap_min_addr in init_mmap_min_addr. >> >> Signed-off-by: Kaixiong Yu >> --- >> kernel/sysctl.c | 9 --------- >> security/min_addr.c | 11 +++++++++++ >> 2 files changed, 11 insertions(+), 9 deletions(-) >> >> diff --git a/kernel/sysctl.c b/kernel/sysctl.c >> index 41d4afc978e6..0c0bab3dad7d 100644 >> --- a/kernel/sysctl.c >> +++ b/kernel/sysctl.c >> @@ -2059,15 +2059,6 @@ static struct ctl_table vm_table[] = { >> .proc_handler = proc_dointvec_minmax, >> .extra1 = SYSCTL_ZERO, >> }, >> -#ifdef CONFIG_MMU >> - { >> - .procname = "mmap_min_addr", >> - .data = &dac_mmap_min_addr, >> - .maxlen = sizeof(unsigned long), >> - .mode = 0644, >> - .proc_handler = mmap_min_addr_handler, >> - }, >> -#endif >> #if (defined(CONFIG_X86_32) && !defined(CONFIG_UML))|| \ >> (defined(CONFIG_SUPERH) && defined(CONFIG_VSYSCALL)) >> { >> diff --git a/security/min_addr.c b/security/min_addr.c >> index 0ce267c041ab..b2f61649e110 100644 >> --- a/security/min_addr.c >> +++ b/security/min_addr.c >> @@ -44,8 +44,19 @@ int mmap_min_addr_handler(const struct ctl_table *table, int write, >> return ret; >> } >> >> +static struct ctl_table min_addr_sysctl_table[] = { >> + { >> + .procname = "mmap_min_addr", >> + .data = &dac_mmap_min_addr, >> + .maxlen = sizeof(unsigned long), >> + .mode = 0644, >> + .proc_handler = mmap_min_addr_handler, >> + }, >> +}; > I haven't chased all of the Kconfig deps to see if there is a problem, > but please provide a quick explanation in the commit description about > why it is okay to drop the CONFIG_MMU check. According to the compilation condition in security/Makefile: obj-$(CONFIG_MMU) += min_addr.o if CONFIG_MMU is not defined, min_addr.c would not be included in the compilation process. So，it is okay to drop the CONFIG_MMU check. >> static int __init init_mmap_min_addr(void) >> { >> + register_sysctl_init("vm", min_addr_sysctl_table); >> update_mmap_min_addr(); >> >> return 0; >> -- >> 2.25.1