linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Ojaswin Mujoo <ojaswin@linux.ibm.com>
To: "Pankaj Raghav (Samsung)" <pankaj.raghav@linux.dev>
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	djwong@kernel.org, john.g.garry@oracle.com, willy@infradead.org,
	hch@lst.de, ritesh.list@gmail.com, jack@suse.cz,
	Luis Chamberlain <mcgrof@kernel.org>,
	dgc@kernel.org, tytso@mit.edu, p.raghav@samsung.com,
	andres@anarazel.de, brauner@kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC PATCH v2 0/5] Add buffered write-through support to iomap & xfs
Date: Sat, 18 Apr 2026 12:56:54 +0530	[thread overview]
Message-ID: <aeMyFgfHYy6FToBS@li-dc0c254c-257c-11b2-a85c-98b6c1322444.ibm.com> (raw)
In-Reply-To: <q5ksnnwwnjqyvzqrlx5u2zzsq2rs4uoirn4xvt6dfrdck7df5e@pxyaupfbdb3u>

On Fri, Apr 17, 2026 at 05:54:46AM +0200, Pankaj Raghav (Samsung) wrote:
> Thanks for the patches.
> 
> > The implementation of write-through combines the buffered IO frontend
> > with dio backend, which leads to some interesting interactions.
> > I've added most of the design notes in respective patches. Please note
> > that this is an initial RFC to iron out any early design issues. This is
> > largely based on suggestions from Dave an Jan in [1] so thanks for the
> > pointers!
> > 
> > 
> > * Testing Notes (UPDATED) *
> > 
> > - I've added support for RWF_WRITETHROUGH to fsx and fsstress in
> >   xfstests and these patches survive fsx with integrity verification as
> >   well as fsstress parallel stressing.
> 
> Could you point me to your xfstests repo where you have added this
> support? :)
> I have been traveling the whole week. I can give the patches a spin in
> my setup in the coming days.

Hi Pankaj, you can find the xfstests support here:

https://github.com/OjaswinM/xfstests/tree/iomap-buf-writethrough2

For fsstress, I was using generic/013 modified to run more operations.
For fsx, any of the run_fsx stressing tests would do, or you could use
the following command (writethrough should auto enable if kernel
supports it):

/home/ojas/workspace/xfstests-dev/ltp/fsx \
 -N 100000 \
 -o 65536 \
 -l 500000 \
 -r 4096 \
 -t 512 \
 -w 512 \
 --record-ops=rwf_rt.fsxops \
 $MNT/junk

Regards,
Ojaswin

> 
> > - -g quick with blocks size == page size and blocksize < pagesize shows
> >   no new regressions.
> > 
> > 
> > * Design TODOs (UPDATED) *
> > 
> > - Evaluate if we need to tag page cache dirty bit in xarray, since 
> >   PG_Writeback is already set on the folio.
> > - Look into a better way to refactor writethrough path by reusing common
> >   parts of dio code.
> > 


      reply	other threads:[~2026-04-18  7:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08 18:45 Ojaswin Mujoo
2026-04-08 18:45 ` [RFC PATCH v2 1/5] mm: Refactor folio_clear_dirty_for_io() Ojaswin Mujoo
2026-04-15  6:14   ` Christoph Hellwig
2026-04-08 18:45 ` [RFC PATCH v2 2/5] iomap: Add initial support for buffered RWF_WRITETHROUGH Ojaswin Mujoo
2026-04-16 12:05   ` Jan Kara
2026-04-16 12:34   ` Jan Kara
2026-04-17 19:42     ` Ojaswin Mujoo
2026-04-17  4:13   ` Pankaj Raghav (Samsung)
2026-04-18  7:33     ` Ojaswin Mujoo
2026-04-08 18:45 ` [RFC PATCH v2 3/5] xfs: Add RWF_WRITETHROUGH support to xfs Ojaswin Mujoo
2026-04-08 18:45 ` [RFC PATCH v2 4/5] iomap: Add aio support to RWF_WRITETHROUGH Ojaswin Mujoo
2026-04-08 18:45 ` [RFC PATCH v2 5/5] iomap: Add DSYNC support to writethrough Ojaswin Mujoo
2026-04-17  3:54 ` [RFC PATCH v2 0/5] Add buffered write-through support to iomap & xfs Pankaj Raghav (Samsung)
2026-04-18  7:26   ` Ojaswin Mujoo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aeMyFgfHYy6FToBS@li-dc0c254c-257c-11b2-a85c-98b6c1322444.ibm.com \
    --to=ojaswin@linux.ibm.com \
    --cc=andres@anarazel.de \
    --cc=brauner@kernel.org \
    --cc=dgc@kernel.org \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=john.g.garry@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=p.raghav@samsung.com \
    --cc=pankaj.raghav@linux.dev \
    --cc=ritesh.list@gmail.com \
    --cc=tytso@mit.edu \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox