From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D7E8C54E76 for ; Mon, 20 Nov 2023 10:55:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 397F06B0134; Mon, 20 Nov 2023 05:55:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3237E6B031B; Mon, 20 Nov 2023 05:55:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FC4C6B0328; Mon, 20 Nov 2023 05:55:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id ED90F6B0134 for ; Mon, 20 Nov 2023 05:55:19 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C9FD7120864 for ; Mon, 20 Nov 2023 10:55:19 +0000 (UTC) X-FDA: 81478025958.12.0356A59 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 83CB616000D for ; Mon, 20 Nov 2023 10:55:17 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Xmcgbcig; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700477717; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xSIGRF/7VBbZlLtEMWR+fp7S8tCj8dJX1So74Eiu2Zg=; b=jB4Xis1/UW8G2JM+5bhWW4et8rNM2PhdVo9tjfzezgReXvLjyDue01nUX+GdlOCIG/TKot i9nRI9Vabp9YSLa7rBwfF1F42YiU7Wvk/gnPYTtRus6crhPtXA08Zd/EQ3B7VElbqAD84j jHzMe8nPuraHYmsVFfv7kbA2enaGlPE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Xmcgbcig; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700477717; a=rsa-sha256; cv=none; b=sthTt9VruVHaUi8Nu5QXgSZxRKxM+r+jRX4Gx3IHaoPhJLeDk3JK29j2BXUKoYIX1JYYmE J3Ya7SpIUPtJyG0+GS7kSqXBej/W6rsyJt2owI/6llm1Qel5RuYGDrZbeHLyXvVTSh0tWD H20wT22m01h+yoCHyH/ZjOuzwLwxViQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700477716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xSIGRF/7VBbZlLtEMWR+fp7S8tCj8dJX1So74Eiu2Zg=; b=Xmcgbcigo/OPbHbP0DBeVLUtLsdz4N8WPmS3cYfEKFaF3LvPseWy0M48b0zfmSTXywlhnN Y2ig+ePB78u2nz+yVkP8lVv8PmYCkADIllDURmAKrsn/d8kmOeCtLmxDmkCMSB5HFO1XVJ CVo4LcW4QtZTdyUoht78LNNc+SgsLJM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-203-S-vFWdBnO22bMI6MVbsV6Q-1; Mon, 20 Nov 2023 05:55:15 -0500 X-MC-Unique: S-vFWdBnO22bMI6MVbsV6Q-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-40853e14f16so10992365e9.1 for ; Mon, 20 Nov 2023 02:55:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700477714; x=1701082514; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xSIGRF/7VBbZlLtEMWR+fp7S8tCj8dJX1So74Eiu2Zg=; b=sh0sN1Hy2y89WmzjPhop67gnffmLCi4skuo6KaWRMO0c2xkd5S+KTaFl64rtWzcCYf 9JURfGlsjFjBPzhkUJlacBoUOsyl74/zzN1OdkzKB3kj+aT0em1TS+XM6m7dcYkooDPL ho21pyOZ6pJ7EQqU2k1dv3KY52yevRHhNp9ltSKhaGrsDETYbG7eEFME4+JGHcNMYeSs VD1l92whBPBdMDXXKMwl3+ryBVYEJPXNdOXu+5+d1mech3PgJtWdre1dRZMfRFCuOia0 61U5lSrZ9OnWaLXQrTlv98FV0HE4P8VVOX+tCnT/59pTCQtf+6aW/qOuRrO5OWsbooY0 dwpQ== X-Gm-Message-State: AOJu0Yy5sGt+JPjIub9dGQlwhbir4rpBOdRo9UHG532IzYeXvUl5wIyv JU4/VdRjvQE0a8lBL8F3zn0gDZ6F9mHuC9DVCNNWSAf1pfc8M9RkANQlStus0y2Mwn4E3w4fEXL W5sQe7r4dUoXuziWGGHM= X-Received: by 2002:a05:600c:4289:b0:406:8496:bd8b with SMTP id v9-20020a05600c428900b004068496bd8bmr5056524wmc.9.1700477714095; Mon, 20 Nov 2023 02:55:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IH0McoI7xSESM8bl+W66YBAk/AMaRM4vUIiYOo17Iy5QLcM986P3yoIU3IsHbmFHdqPMzPgGA== X-Received: by 2002:a05:600c:4289:b0:406:8496:bd8b with SMTP id v9-20020a05600c428900b004068496bd8bmr5056500wmc.9.1700477713627; Mon, 20 Nov 2023 02:55:13 -0800 (PST) Received: from ?IPV6:2003:cb:c746:7700:9885:6589:b1e3:f74c? (p200300cbc746770098856589b1e3f74c.dip0.t-ipconnect.de. [2003:cb:c746:7700:9885:6589:b1e3:f74c]) by smtp.gmail.com with ESMTPSA id h18-20020a05600c351200b004063ea92492sm13154818wmq.22.2023.11.20.02.55.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Nov 2023 02:55:13 -0800 (PST) Message-ID: Date: Mon, 20 Nov 2023 11:55:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] mm: use vmem_altmap code without CONFIG_ZONE_DEVICE To: Sumanth Korikkar , linux-mm , Andrew Morton Cc: Oscar Salvador , Michal Hocko , "Aneesh Kumar K.V" , Anshuman Khandual , Gerald Schaefer , Alexander Gordeev , Heiko Carstens , Vasily Gorbik , linux-s390 , LKML , stable@vger.kernel.org References: <20231120102734.2001576-1-sumanthk@linux.ibm.com> <20231120102734.2001576-4-sumanthk@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231120102734.2001576-4-sumanthk@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 83CB616000D X-Stat-Signature: j61o41jdixabb75p3ha4wgia4eqwnxbt X-Rspam-User: X-HE-Tag: 1700477717-978752 X-HE-Meta: U2FsdGVkX19X8q83vxMYLtzpntGq4dMSRkoAsoRlzM2LSUyn5yM5/VbqOgE2Pj3Hzu/r9ICfEYEZKsqAvxjT9ocWZQbJpEw2shXhVWXAJ2/YPRaY0gt4RUcmf4kE3J22t0htNASPbHScYx/2IK2RCrR6wvr3YHNfnb2w5Q5C+t0F7ZOozbQnRRrisDCltmydiWZXpggLpV2NUcHFFzs3Cl8+ODrwtktPBgfrnSoyPGWR+8h7M6B9Ueu8omFQmNU5fp9lEYmzPd4lDGPK+oWExAurMVYVh74z6fm2GWZR1F5pJ4GIp2esQW3J+LASKlM0+a08w6hlQKktqrc5xtfXwONvyyoJ7vudouMQ3XdPYNbjooR2PxFAZ7PQX+Sf82bHQ5l1Ig+Z6MG+mjPzLojKa1S0yKptCyFg4WlW8rh5J6fG3Kbjn3lFN9YcS0pAf3ef5k3REjaadpLlcNgrjERnsxN5FM1Ny4Gwv3aFu5u0zSR7FACCtBKBU/FiFH1nDnxZSKOq89lGUqDbR+EEN5wznx0qZGwbVSZvXnhNk8tvwo/NLSgEYVlIjIXiVgqfwysu/5leH6jDOqwZapmymT9Yht1N1OjEjFB2WEYZtG0RhvlWOGISKkLprdnf0eKV7VFmIR0FaypJe76pVEca6MF7GWI21WlW8eHs0DzxaFzbSVupc4NAoiJufLbNT3pv5BJbvZHRPxuSA096nZuLaVDKWRndxP5Bn3y+cYaGnqdYYbXdqUHtSwPw5wicmwQByfRgSa6Qr+grEVJFdq3bpG9dvxXOiAyqpxva1yN/b7G5pSlZVeEzK5iOebE6ee1XlkkeYaz4rzOxCGKzxt667UDfDArtzuPyzPhwMWiDOa0chjXfwP8TbrTfdp/s3ScKPF3BRFmgcEnuwmBNxcJVn3n3zqHHmcAloAaL5RGbUK3cmO7sYJh4pqVRbdWiRiZhdJBXPjSSARNszFHIVUR9WVK aKNSTnqh 637jaEl/zanwM1W/Q5HqaAeNpDr0unLGgbnO2yLJ0veflvl3kaxpp1oyygFYpW/R7U5LZaKU0UvzHjYWOO8EHY4Pod3v+sSVzYnzvi4EMhW/+Qyrcd0Q/mehOpKt5L9vUUTRxMGfD8ixRodykj1dL4C8mCKqrt0VCdiTP/0j/iKLY8LVQGwf+6ORxFEh92XTNozcPUEdpb5LvTbnThvVUEpOq3T26xAI2fa6gccuK6Dle7RIJkOBvvrMHS7h4SGSkyT8b7nIMIzluCRs+ga4dixKUXQvSCQUc10CZgpIDBxZ+4+T6zFOUct/LRN0hQb7UyTc20eDojs6iq+cIpJilZwz0j75UyXCNaJFSx585YKkL0g+6sau7+ckcb+SksSWmgZGq/cHV69ZWRA0fyzChSLjdj3IfcWDGgKVuy2ui9m+E7mzkhN3KyXWxR6Z76WRkFYUyxpWM1ZUMeNkzCKsnJhkmTvdDG+8RKl+ymdVuk7OhJ4yMi4ZlVKN2mg6+BfGTUuB2g1VCTQMwpZPpRmdecCUb3xP0c2J19TBWHowahQ3NgzO0BqRtjmyXgw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.11.23 11:27, Sumanth Korikkar wrote: > vmem_altmap_free() and vmem_altmap_offset() could be utlized without > CONFIG_ZONE_DEVICE enabled. For example, > mm/memory_hotplug.c:__add_pages() relies on that. The altmap is no > longer restricted to ZONE_DEVICE handling, but instead depends on > CONFIG_SPARSEMEM_VMEMMAP. > > When CONFIG_SPARSEMEM_VMEMMAP is disabled, these functions are defined > as inline stubs, ensuring compatibility with configurations that do not > use sparsemem vmemmap. Without it, lkp reported the following: > > ld: arch/x86/mm/init_64.o: in function `remove_pagetable': > init_64.c:(.meminit.text+0xfc7): undefined reference to > `vmem_altmap_free' > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202311180545.VeyRXEDq-lkp@intel.com/ > Reviewed-by: Gerald Schaefer > Signed-off-by: Sumanth Korikkar Acked-by: David Hildenbrand -- Cheers, David / dhildenb