From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D38EFC433EF for ; Fri, 22 Apr 2022 11:06:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 502DB6B0075; Fri, 22 Apr 2022 07:06:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B2526B0078; Fri, 22 Apr 2022 07:06:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32D4A6B007B; Fri, 22 Apr 2022 07:06:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 21EAB6B0075 for ; Fri, 22 Apr 2022 07:06:37 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DADDB25680 for ; Fri, 22 Apr 2022 11:06:36 +0000 (UTC) X-FDA: 79384236792.08.7AC91D5 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf03.hostedemail.com (Postfix) with ESMTP id 656E12000D for ; Fri, 22 Apr 2022 11:06:34 +0000 (UTC) Received: by mail-ed1-f51.google.com with SMTP id be20so1658741edb.12 for ; Fri, 22 Apr 2022 04:06:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3oAXziqhWecaTicJ1TJAzNJot2O+F74s+fvWsJ5jiW0=; b=Z3UhoC2SUhjVWlGPrlQSCEy7Q2VUy1KM4Eawia1E0+bVsrQRDiAdB6aIu4tDq2rs+W l9URZMyEh1mlY2HNOo0fbW8C4oce1X3bqvloH5MOIvkgz3r2jqhRYvjTsifFBwC26dWz 5u/OY2dcl/pTD5xnO1Ni/MGueOugkU/ZLsAfbDYl7NqXeIQgGYKNTCcaQywEZyd7ps8i bPdq5KKW1neU+1Bd7F3mozZg+0jDg3J3+YRy5LENlRrOK8obiW4Z2YyZ2F6IKRhopHVL s1vBPqS9vZo27+goT+fgxRzTty8QEX+Y/XPWBFQacTwOcOmSKZgZtV1qMUX4xQ0CcbVI Pjpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3oAXziqhWecaTicJ1TJAzNJot2O+F74s+fvWsJ5jiW0=; b=6GDz4HlEQlipetB21QFd+XK2ZnpoLtLDl2rNpRdezS8EM4sNYDCLxeZ6E30bErPlF/ 1Qy/WlzgnLlscZDwFVpm9UH1Q4C3c9mh1b3+V5471xsrfZgO5vSjzkelvYlO5AcOZfIn LwsPMlCoOTpDCAtJmhnMobW6Pmq97bkNubF71Y/NcwEWSnqZxGng2zJ9nBnvV1AwKgnC okAoyHi8m77k5gSeC/CjX/UJwOI2HWA5LWn2DGAsRLOBwxp52raQ26PuLOGTIxwrkBQK ytGcNkbdrpKBzo0JAQI7ts3D5W/+zJvMYjWw7naiHNUC+Cle5wkl1xs89D2HghkrCiQW TMaw== X-Gm-Message-State: AOAM531Tyykctfb00cXYCzkN42CcgqDCvxdjSb6X+FFwgZWPYF3y6axm 77vxowfhk/KEylsEV4/9VZGY+mOWxca3sg== X-Google-Smtp-Source: ABdhPJwM5GvWcrt60tN0WmgY/AWsqlmKQqrmRmCB40Mt12b/qqhMcJz2Oau7CJ0N11yndzI6Kklg6g== X-Received: by 2002:a05:6402:1385:b0:413:2bc6:4400 with SMTP id b5-20020a056402138500b004132bc64400mr4272735edv.94.1650625595094; Fri, 22 Apr 2022 04:06:35 -0700 (PDT) Received: from ?IPV6:2001:b07:add:ec09:c399:bc87:7b6c:fb2a? ([2001:b07:add:ec09:c399:bc87:7b6c:fb2a]) by smtp.googlemail.com with ESMTPSA id x19-20020a05640226d300b004228faf83desm808347edd.12.2022.04.22.04.06.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Apr 2022 04:06:34 -0700 (PDT) Message-ID: Date: Fri, 22 Apr 2022 13:06:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v5 00/13] KVM: mm: fd-based approach for supporting KVM guest private memory Content-Language: en-US To: Chao Peng , Sean Christopherson Cc: Quentin Perret , Andy Lutomirski , Steven Price , kvm list , Linux Kernel Mailing List , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Linux API , qemu-devel@nongnu.org, Jonathan Corbet , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , the arch/x86 maintainers , "H. Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Mike Rapoport , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A. Shutemov" , "Nakajima, Jun" , Dave Hansen , Andi Kleen , David Hildenbrand , Marc Zyngier , Will Deacon References: <80aad2f9-9612-4e87-a27a-755d3fa97c92@www.fastmail.com> <83fd55f8-cd42-4588-9bf6-199cbce70f33@www.fastmail.com> <20220422105612.GB61987@chaop.bj.intel.com> From: Paolo Bonzini In-Reply-To: <20220422105612.GB61987@chaop.bj.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 656E12000D X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Z3UhoC2S; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (imf03.hostedemail.com: domain of paolo.bonzini@gmail.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=paolo.bonzini@gmail.com X-Stat-Signature: gswbnethe93biskjqn53y57hqhhf1tjr X-HE-Tag: 1650625594-641176 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/22/22 12:56, Chao Peng wrote: > /* memfile notifier flags */ > #define MFN_F_USER_INACCESSIBLE 0x0001 /* memory allocated in the file is inaccessible from userspace (e.g. read/write/mmap) */ > #define MFN_F_UNMOVABLE 0x0002 /* memory allocated in the file is unmovable */ > #define MFN_F_UNRECLAIMABLE 0x0003 /* memory allocated in the file is unreclaimable (e.g. via kswapd or any other pathes) */ You probably mean BIT(0/1/2) here. Paolo > When memfile_notifier is being registered, memfile_register_notifier will > need check these flags. E.g. for MFN_F_USER_INACCESSIBLE, it fails when > previous mmap-ed mapping exists on the fd (I'm still unclear on how to do > this). When multiple consumers are supported it also need check all > registered consumers to see if any conflict (e.g. all consumers should have > MFN_F_USER_INACCESSIBLE set). Only when the register succeeds, the fd is > converted into a private fd, before that, the fd is just a normal (shared) > one. During this conversion, the previous data is preserved so you can put > some initial data in guest pages (whether the architecture allows this is > architecture-specific and out of the scope of this patch).