From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69FA2C04A95 for ; Wed, 28 Sep 2022 14:29:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A05106B0072; Wed, 28 Sep 2022 10:29:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B3DE6B0073; Wed, 28 Sep 2022 10:29:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 853B56B0074; Wed, 28 Sep 2022 10:29:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 764866B0072 for ; Wed, 28 Sep 2022 10:29:10 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 025664188B for ; Wed, 28 Sep 2022 14:29:09 +0000 (UTC) X-FDA: 79961726460.04.96CE357 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 7032E40011 for ; Wed, 28 Sep 2022 14:29:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664375341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CsRvdNuB3v/SNcrkexdVjS7ITSiCQeyOBq5LFv9LGBc=; b=azwact4EHnEy2AqE3J1zlnN5+YkcPj5t/OR+rfoeT5PUZX3SXiBICIb/Psut5/sPAGVuRW /YOCG1QXuzuOdyjh3ecDEN5TTEMAveds4d0AcUYlYPajoEfLExAsENqFs8BzRvjq8Kdham 12MryGx6QWc6CWH0XK0LL0jPY1sPzFw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664375349; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CsRvdNuB3v/SNcrkexdVjS7ITSiCQeyOBq5LFv9LGBc=; b=FYuFwyWFp2dyMSMR033j6iLDMsPRnE3GTN4wpz/odHDhW5Grsm6qS2FosjpDdnGkXs7cor E4KkVxA0nb/mzCEqmaAVJOLfxecZkVQygpnI99m67UQoSsjwsSvpxMTGqnvnvZyre2+/po WZKS69mYoig3moBNrKaOwSF61+cRcUE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-317-djIp5-SnP4esKAzRTUcLEA-1; Wed, 28 Sep 2022 10:27:40 -0400 X-MC-Unique: djIp5-SnP4esKAzRTUcLEA-1 Received: by mail-wr1-f71.google.com with SMTP id s16-20020adf9790000000b0022cc14c6114so1395921wrb.0 for ; Wed, 28 Sep 2022 07:27:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=CsRvdNuB3v/SNcrkexdVjS7ITSiCQeyOBq5LFv9LGBc=; b=EDOHn56ehGW+AdVMf1zjirPhxApU0NCglFJe3c5zgj6/x4vfMLBpW6Uuwb4vjMmxlK DTxDIOIalHZ71Dwxw8tfFz1hv4WandNvnw7pEQo5KKCI0zi5OUFLmY8LN4Hi70SXbzcK jYjOKrwAAMRDPXOXl2uTCgzUXo22xDQkH4cwBWmd2l12Zvu+IL8EnXvJg0GCmgfSLZIk eCl8G7//KYOalc8wsWPukJWCBSRADeKidv4C4O9/pwh8rj17+e4FfbtTFtXBaIxvwZb9 wDWlgkKyjgFlM5DhV4sIpw0X3FV2ejljomhklz2GnUbQHhFA3tOw5tIcfKFpEJl6bRKz WA8w== X-Gm-Message-State: ACrzQf3Vlvn833Et/AypjEaBO9U8h/7PoHRmt9Q6aijZhrOpPE+8hgnl 9JChQwZkr7DIbzNjlQn5ONDxLmG70ye4Pmxc8j43r48TrUVF4rdsFHHUsAuI+2D4xJAYovnx9eP j+TYwbCAvbXg= X-Received: by 2002:a05:600c:198a:b0:3b4:c06a:28b1 with SMTP id t10-20020a05600c198a00b003b4c06a28b1mr7253790wmq.72.1664375258855; Wed, 28 Sep 2022 07:27:38 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6PL6DSJpi05ycxfM4eUOHcWUfX6Va9hKc9hPOOGXegD1eig35izDc6V95YS8RX3LTd0YVPBQ== X-Received: by 2002:a05:600c:198a:b0:3b4:c06a:28b1 with SMTP id t10-20020a05600c198a00b003b4c06a28b1mr7253764wmq.72.1664375258586; Wed, 28 Sep 2022 07:27:38 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:1100:add9:5f61:6b94:7540? (p200300cbc7041100add95f616b947540.dip0.t-ipconnect.de. [2003:cb:c704:1100:add9:5f61:6b94:7540]) by smtp.gmail.com with ESMTPSA id b8-20020a5d45c8000000b0022ca921dc67sm4288199wrs.88.2022.09.28.07.27.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Sep 2022 07:27:38 -0700 (PDT) Message-ID: Date: Wed, 28 Sep 2022 16:27:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] mm: rmap: rename page_not_mapped() to folio_not_mapped() To: Kefeng Wang , Andrew Morton , linux-mm@kvack.org Cc: Matthew Wilcox , linux-kernel@vger.kernel.org References: <20220927063826.159590-1-wangkefeng.wang@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220927063826.159590-1-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664375349; a=rsa-sha256; cv=none; b=6HCeDW6kZmOEaq+IhfyO3weN9xaLzEQfYxCQQOXTcY2ORgMXQV5+x6XEsjyGpDDVMxnK6M BrskHx7+DsWjWTkcSSnPP6QQil8pMI6dHb+RmFoWO5kwXD3u5gCCyFicEH+9cbpbmZKoS8 ymeDU0KjbKO55d/uJmA9EViC4DOASac= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=azwact4E; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FYuFwyWF; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664375349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CsRvdNuB3v/SNcrkexdVjS7ITSiCQeyOBq5LFv9LGBc=; b=egmXCH89AWwnpU4D+xJnFZF9VfHCGpK2TxwvHKm0nF0ULNwfkp7W9iVNXsHEGcjcYicRF2 o/juEXhZToLbn4bRuJd5nzuOBaWr/g8DcsKCQJrwRmh64ucYobhsf6Gl6rKyIzPxnnDVgo t7CHGoCreaF5BcyVSzoDQjEV1mJJ98E= X-Rspamd-Server: rspam10 X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=azwact4E; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FYuFwyWF; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: s6u3g8a76ofas3erkzc4iokhp58dq68f X-Rspamd-Queue-Id: 7032E40011 X-HE-Tag: 1664375349-511826 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 27.09.22 08:38, Kefeng Wang wrote: > Since commit 2f031c6f042c ("mm/rmap: Convert rmap_walk() to > take a folio"), page_not_mapped() takes folio as parameter, > rename it to be consistent. > > Signed-off-by: Kefeng Wang > --- > mm/rmap.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/rmap.c b/mm/rmap.c > index 2ec925e5fa6a..df228602cf0e 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1801,7 +1801,7 @@ static bool invalid_migration_vma(struct vm_area_struct *vma, void *arg) > return vma_is_temporary_stack(vma); > } > > -static int page_not_mapped(struct folio *folio) > +static int folio_not_mapped(struct folio *folio) > { > return !folio_mapped(folio); > } > @@ -1822,7 +1822,7 @@ void try_to_unmap(struct folio *folio, enum ttu_flags flags) > struct rmap_walk_control rwc = { > .rmap_one = try_to_unmap_one, > .arg = (void *)flags, > - .done = page_not_mapped, > + .done = folio_not_mapped, > .anon_lock = folio_lock_anon_vma_read, > }; > > @@ -2150,7 +2150,7 @@ void try_to_migrate(struct folio *folio, enum ttu_flags flags) > struct rmap_walk_control rwc = { > .rmap_one = try_to_migrate_one, > .arg = (void *)flags, > - .done = page_not_mapped, > + .done = folio_not_mapped, > .anon_lock = folio_lock_anon_vma_read, > }; > > @@ -2297,7 +2297,7 @@ static bool folio_make_device_exclusive(struct folio *folio, > }; > struct rmap_walk_control rwc = { > .rmap_one = page_make_device_exclusive_one, > - .done = page_not_mapped, > + .done = folio_not_mapped, > .anon_lock = folio_lock_anon_vma_read, > .arg = &args, > }; I'm wondering if we should call it "folio_unmapped()". Anyhow Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb