From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 436B3C48BEF for ; Fri, 16 Feb 2024 18:04:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B3518D0009; Fri, 16 Feb 2024 13:04:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 73BCE8D0007; Fri, 16 Feb 2024 13:04:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DC658D0009; Fri, 16 Feb 2024 13:04:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4BE368D0007 for ; Fri, 16 Feb 2024 13:04:24 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C2F821A0332 for ; Fri, 16 Feb 2024 18:04:23 +0000 (UTC) X-FDA: 81798441606.15.97505A1 Received: from relay.hostedemail.com (unirelay08 [10.200.18.71]) by imf16.hostedemail.com (Postfix) with ESMTP id 0381B18000E for ; Fri, 16 Feb 2024 18:04:21 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708106662; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LlTGVV9UTceKhqzrgZ0p9EOcCHPQOeCMznZmHyCHuZs=; b=IrHDuyeEiiyOZA+akCVX4SxpqfLOuOVp1ANZQawxYS4ED3uapP9MOLSDjidLZg+BIXd2Yi TNqwfvD/sOo6quZ30ChiH4c1rN1mPE0c4HF/YeOpQaOKt7XjFTFQ+BDBSnlzy3JtlMnogo /1yjqd1XnOP9nZ3d8heXjtgZR36Nmcc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708106662; a=rsa-sha256; cv=none; b=GYoy4neeSnwSXYkRh4JrChuwnwiQKcApQOmNsg7wfVrmMsS/2UC6qyVvERtC4h7pgZ5GQs SQQvq1NCA1cn8PsGWPnyvZ8Dh6w5Ers7/OV+/26tlHK6VRGREoIDGmonwhLyqnQwK5S8L5 xxkS58eNYrlJ6xGClQv5CwBOrAa5Vvg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; none Received: from omf18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 46727140384; Fri, 16 Feb 2024 18:04:20 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf18.hostedemail.com (Postfix) with ESMTPA id 037A72E; Fri, 16 Feb 2024 18:04:16 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2] mm: document memalloc_noreclaim_save() and memalloc_pin_save() From: Joe Perches To: Andrew Morton , Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Mel Gorman , Matthew Wilcox , Mike Rapoport , Pasha Tatashin , Kent Overstreet , Michal Hocko Date: Fri, 16 Feb 2024 10:04:16 -0800 In-Reply-To: <20240215155557.93b23f4a69c6062e7878ed14@linux-foundation.org> References: <20240215095827.13756-2-vbabka@suse.cz> <20240215155557.93b23f4a69c6062e7878ed14@linux-foundation.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+wtkNzcOB/1WKKBtCElicsJyKKLDKd3hA= X-HE-Meta: U2FsdGVkX1+FiGm4mZ12FSCruZ5Iaz7enFXCASYoTcEyCtTXf1RxwhuRsrl/MmkjORqcdTSP/M5gxsakBwbEbonMV70LxsHr81vL49Wwu06KxXK4fedoeqtNDZeu/wfCRS04UB4Vdh3ulGRryqZgrICnyM1TM2ojZWyn+aU1sFpdABJMmcrVRbnMytV6cG7NkXqCcwRMIg27E210dh8wI68ZSGw+74lRHKFjlu+wZHy3bD9ISqRvHtWl4EpQJ/okaK24t3Uug68p7OtewOQSFwfnE94BpiBwmghVJBC5vUQZufYDKoDUUU0QtBYYvz22 X-Rspamd-Queue-Id: 0381B18000E X-Rspam-User: X-HE-Tag-Orig: 1708106656-416423 X-Stat-Signature: 7xjdpuwo1fq7ossn3ubx6pa34tr635q7 X-Rspamd-Server: rspam03 X-HE-Tag: 1708106661-265860 X-HE-Meta: U2FsdGVkX1/dSrG+aTs7wC45EdvS0PJO5hG2Zq5g3bwnBJ+/GDvAD2KwQ8o/jKJl5ppqbWBf0X1iupYDDiqUobxjufeRmph9zfsUDLwVroZoR3x61wH0+giPuawHCQgYf8iPCIBL37SY+McwqhO51DdgOFnOVSx83lPkAeYEkAxc3dgfZt4NcshqMQTU931sLTzyd+ZsKCttGfgWZuB4RTm+++634Lput+KK2VNscLhRmhXYpptid/Qq4y35U5jVJic3L1d4qyvK0b84imhpojknVM04rd43VCdpvEwzMF1aOIlJgETcEQKNpSneadQDY/RD8Z42fXPbq8SV8CCkHtHhs/M6s4FgciKP/mMJQdYS0tpp3T7twH0HTr4EN4Bo0RkNwInqL0639RCYhBf77QqiyXaGYIo9nzVMEtTRdXjbL4x5nkaUxD0+NS4fjqRljRyd4AujcYgeS20GJXV/2C20mmUVdcUHdOCFbq2bOQwi3CJiG2pt2gUz8JNfd/+IzQQMuqtmielcxgZZCN+LgxADfwtxB/ES8XoekHtnivfDVp56duAbQ6DNG7iKIARiqwOcfsofbmA2lQUieBeG25Q2JTe8SzqTwBBeaznqDoz91qLDciKIGWuhN+BA/MzYIOu2wCjVfc7dUyscHfhHmRRvPfq4mEhC9LXmXVQHSZmN00ZkaHmYPdsS4qXypxSTGQrdyC4Jygw3E6Pk6bJQ5afNUFRcH1l6UizfbNxPBCLrPLdBLaZHHs5bIinYleMvD3WUioCxg7QaUDu1eb66JKmUVpwEi03wynRLzXrzmF3EADhdrLcOqqRyKI7wQCLu4K5tL4WEdDkEUjeMGpIOcj7lQ/rB7kQmH8a/+XqGO/K88r0xfZP+1KbU0oYYky334u3xfyKcx8qwVEc0v7nZXgQD4m+odA1E++B/5MF/9HJpCRWUEcq45OqVX76LjHT/rg+9C3CMhq6thtTHooM igHmIUva TrGNgjga96+Y3+B6HD92NTJqZvg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 2024-02-15 at 15:55 -0800, Andrew Morton wrote: > + * This function marks the beginning of the __GFP_MEMALLOC allocation sc= ope. > > ... > >=20 > > + * This function marks the beginning of the ~__GFP_MOVABLE allocation = scope. >=20 > pet peeves. We can assume that the reader knows that this is a > function! Perhaps we should teach checkpatch to whine. >=20 > Like "the function foo" and "the function foo()" in changelogs.=20 > "foo()" is enough! IMO: checkpatch should not be a grammar checker. It's stupid enough as is let alone trying to get it to analyze sentence structure.